From fe93ea9f68ce1900193b99b8692fc0d709401485 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=9D=B4=EC=A0=95=ED=99=98?= Date: Sat, 2 Apr 2022 15:59:29 +0900 Subject: [PATCH 1/2] Update cra-template for react18 --- packages/cra-template-typescript/template/src/index.tsx | 7 ++++--- packages/cra-template/template/src/index.js | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/cra-template-typescript/template/src/index.tsx b/packages/cra-template-typescript/template/src/index.tsx index ef2edf8ea3f..11671e39f2f 100644 --- a/packages/cra-template-typescript/template/src/index.tsx +++ b/packages/cra-template-typescript/template/src/index.tsx @@ -1,14 +1,15 @@ import React from 'react'; -import ReactDOM from 'react-dom'; +import ReactDOM from 'react-dom/client'; import './index.css'; import App from './App'; import reportWebVitals from './reportWebVitals'; -ReactDOM.render( +const rootElment = document.getElementById('root'); +const root = ReactDOM.createRoot(rootElment); +root.render( , - document.getElementById('root') ); // If you want to start measuring performance in your app, pass a function diff --git a/packages/cra-template/template/src/index.js b/packages/cra-template/template/src/index.js index ef2edf8ea3f..11671e39f2f 100644 --- a/packages/cra-template/template/src/index.js +++ b/packages/cra-template/template/src/index.js @@ -1,14 +1,15 @@ import React from 'react'; -import ReactDOM from 'react-dom'; +import ReactDOM from 'react-dom/client'; import './index.css'; import App from './App'; import reportWebVitals from './reportWebVitals'; -ReactDOM.render( +const rootElment = document.getElementById('root'); +const root = ReactDOM.createRoot(rootElment); +root.render( , - document.getElementById('root') ); // If you want to start measuring performance in your app, pass a function From 4c4f6a652b9f949d7f2408d1ed60a53c01cfb6b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=9D=B4=EC=A0=95=ED=99=98?= Date: Sat, 2 Apr 2022 16:13:49 +0900 Subject: [PATCH 2/2] Fix type for rootElement --- packages/cra-template-typescript/template/src/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cra-template-typescript/template/src/index.tsx b/packages/cra-template-typescript/template/src/index.tsx index 11671e39f2f..a3526f15591 100644 --- a/packages/cra-template-typescript/template/src/index.tsx +++ b/packages/cra-template-typescript/template/src/index.tsx @@ -4,7 +4,7 @@ import './index.css'; import App from './App'; import reportWebVitals from './reportWebVitals'; -const rootElment = document.getElementById('root'); +const rootElment = document.getElementById('root') as HTMLElement const root = ReactDOM.createRoot(rootElment); root.render(