Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Don't scroll node into view if it's already fully in the view #1104

Closed
gaearon opened this issue Aug 21, 2018 · 2 comments
Closed

Don't scroll node into view if it's already fully in the view #1104

gaearon opened this issue Aug 21, 2018 · 2 comments
Assignees

Comments

@gaearon
Copy link
Contributor

gaearon commented Aug 21, 2018

See here:

scrolling

I wouldn't expect scroll to happen because all of these nodes are already into view. The jumping happens too often and I think it's a bit jarring.

Ideally we shouldn't jump if a node is already fully in the view.

@gaearon gaearon changed the title Scrolling into view is more aggressive than necesasry Don't scroll node into view if it's already fully in the view Aug 21, 2018
@gaearon
Copy link
Contributor Author

gaearon commented Aug 21, 2018

We'll release with this behavior but the plan is that @bvaughn will look into it next week after he's back from a vacation

@bvaughn
Copy link
Contributor

bvaughn commented Aug 27, 2018

Fixed via cca8b0c (PR #1112)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants