Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Elements: Auto scroll to show selected node when collapsed/expanded #1132

Closed
bvaughn opened this issue Aug 28, 2018 · 3 comments
Closed

Elements: Auto scroll to show selected node when collapsed/expanded #1132

bvaughn opened this issue Aug 28, 2018 · 3 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Aug 28, 2018

Feedback from PR #1112

the autoscroll doesn't seem to trigger on node collapse/expansion via keyboard (left and right arrow buttons). would be nice if it did

@gaearon gaearon changed the title Profiler: Auto scroll to show selected node when collapsed/expanded Elements: Auto scroll to show selected node when collapsed/expanded Aug 31, 2018
@gaearon
Copy link
Contributor

gaearon commented Aug 31, 2018

This is not about the profiler so I renamed.

@gaearon
Copy link
Contributor

gaearon commented Aug 31, 2018

You said you couldn't reproduce before so here are detailed instructions.

  1. Install 3.3.2 from the Chrome store
  2. Go to https://reactjs.org/tutorial/tutorial.html
  3. Go to React tab, use "click to select" and locate the sidebar <ul>
  4. Select sidebar <ul>
  5. Scroll down a bit until <ul> is no longer visible (but still selected)
  6. Press left and right arrows

Expected: when I press left and right arrows with ul selected, the ul should jump back into view because I'm interacting with it. Actual: scroll is not adjusted so I just see the content shifting.

(Seems like gif got cut off but you should be able to repro with above instructions)

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 19, 2019

React DevTools has been rewritten and recently launched a new version 4 UI. The source code for this rewrite was done in a separate repository and now lives in the main React repo (github.com/facebook/react).

Because version 4 was a total rewrite, and all issues in this repository are related to the old version 3 of the extension, I am closing all issues in this repository. If you can still reproduce this issue, or believe this feature request is still relevant, please open a new issue in the React repo: https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools

@bvaughn bvaughn closed this as completed Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants