Skip to content

Commit 06b5c6e

Browse files
yungstersfacebook-github-bot
authored andcommitted
RN: Use a Private Property in EventEmitter (#39395)
Summary: Pull Request resolved: #39395 Switches `EventEmitter` to use a private property. Support for private properties was [only recently added](#39318), so this will be the first end-to-end validation of support in the `facebook/react-native` project. Changelog: [Internal] Reviewed By: voideanvalue Differential Revision: D49167908 fbshipit-source-id: 6a496ed130bfe5671663166626b1acbd80b0e9c3
1 parent 34a7526 commit 06b5c6e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

packages/react-native/Libraries/vendor/emitter/EventEmitter.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ type Registry<TEventToArgsMap: {...}> = $ObjMap<
6363
export default class EventEmitter<TEventToArgsMap: {...}>
6464
implements IEventEmitter<TEventToArgsMap>
6565
{
66-
_registry: Registry<TEventToArgsMap> = {};
66+
#registry: Registry<TEventToArgsMap> = {};
6767

6868
/**
6969
* Registers a listener that is called when the supplied event is emitted.
@@ -83,7 +83,7 @@ export default class EventEmitter<TEventToArgsMap: {...}>
8383
TEventToArgsMap,
8484
TEvent,
8585
TEventToArgsMap[TEvent],
86-
>(this._registry, eventType);
86+
>(this.#registry, eventType);
8787
const registration: Registration<TEventToArgsMap[TEvent]> = {
8888
context,
8989
listener,
@@ -107,7 +107,7 @@ export default class EventEmitter<TEventToArgsMap: {...}>
107107
...args: TEventToArgsMap[TEvent]
108108
): void {
109109
const registrations: ?Set<Registration<TEventToArgsMap[TEvent]>> =
110-
this._registry[eventType];
110+
this.#registry[eventType];
111111
if (registrations != null) {
112112
for (const registration of [...registrations]) {
113113
registration.listener.apply(registration.context, args);
@@ -122,17 +122,17 @@ export default class EventEmitter<TEventToArgsMap: {...}>
122122
eventType?: ?TEvent,
123123
): void {
124124
if (eventType == null) {
125-
this._registry = {};
125+
this.#registry = {};
126126
} else {
127-
delete this._registry[eventType];
127+
delete this.#registry[eventType];
128128
}
129129
}
130130

131131
/**
132132
* Returns the number of registered listeners for the supplied event.
133133
*/
134134
listenerCount<TEvent: $Keys<TEventToArgsMap>>(eventType: TEvent): number {
135-
const registrations: ?Set<Registration<mixed>> = this._registry[eventType];
135+
const registrations: ?Set<Registration<mixed>> = this.#registry[eventType];
136136
return registrations == null ? 0 : registrations.size;
137137
}
138138
}

0 commit comments

Comments
 (0)