Skip to content

Commit 1be3892

Browse files
hramoskelset
authored andcommitted
Disable failing tests (#20622)
Summary: `test_detox_end_to_end` and `test_objc_end_to_end` are both failing on master. This is polluting internal diffs that do not introduce failures. As we just now started tracking Circle CI on our internal builds, I want to make sure we only nag internal diffs when the failure can actually be attributed to the diff. The failures in the e2e tests precede the Circle CI integration and are adding unnecessary noise. Going forward, we will immediately go back to a diff and push the author to fix the broken CI, so this PR is a temporary fix. Pull Request resolved: #20622 Differential Revision: D9272360 Pulled By: hramos fbshipit-source-id: 2f8d22e35d301aa7eb67ed08f6deed21bf971acd
1 parent f885710 commit 1be3892

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

.circleci/config.yml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,7 @@ jobs:
467467
path: ~/react-native/reports/junit
468468

469469
# Runs end to end tests (Detox)
470+
# Disabled.
470471
test_detox_end_to_end:
471472
<<: *macos_defaults
472473
steps:
@@ -674,16 +675,18 @@ workflows:
674675
requires:
675676
- checkout_code
676677

678+
# Disabled on master.
679+
677680
# End-to-end tests
678-
- test_objc_end_to_end:
679-
filters: *filter-ignore-gh-pages
680-
requires:
681-
- checkout_code
681+
# - test_objc_end_to_end:
682+
# filters: *filter-ignore-gh-pages
683+
# requires:
684+
# - checkout_code
682685

683-
- test_detox_end_to_end:
684-
filters: *filter-ignore-gh-pages
685-
requires:
686-
- checkout_code
686+
# - test_detox_end_to_end:
687+
# filters: *filter-ignore-gh-pages
688+
# requires:
689+
# - checkout_code
687690

688691

689692
# Only runs on vX.X.X tags if all tests are green
@@ -698,7 +701,7 @@ workflows:
698701
- test_javascript
699702
- test_objc
700703
- test_android
701-
- test_objc_end_to_end
704+
# - test_objc_end_to_end
702705

703706
# Only runs on PRs
704707
analyze:

0 commit comments

Comments
 (0)