Skip to content

Commit 320dc4e

Browse files
cipolleschifacebook-github-bot
cipolleschi
authored and
facebook-github-bot
committed
RN][CI] Remove Flipper integration from iOS CI (#41003)
Summary: Pull Request resolved: #41003 Following up the deprecation of Flipper in 0.73 and preparing for the removal of Flipper in 0.74, we are removing Flipper integration from the CI. ## Changelog: [Internal] - Remove the Flipper integration from CI Reviewed By: dmytrorykun Differential Revision: D50321335 fbshipit-source-id: 04885d3dbaab9b2834c9461e0580dfbef386244f
1 parent 899e7cd commit 320dc4e

File tree

3 files changed

+11
-155
lines changed

3 files changed

+11
-155
lines changed

‎.circleci/configurations/jobs.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -403,11 +403,6 @@ jobs:
403403
description: Which JavaScript engine to use. Must be one of "Hermes", "JSC".
404404
type: enum
405405
enum: ["Hermes", "JSC"]
406-
flipper:
407-
default: "WithFlipper"
408-
description: Whether Flipper is enabled. Must be one of "WithFlipper", "WithoutFlipper".
409-
type: enum
410-
enum: ["WithFlipper", "WithoutFlipper"]
411406
use_frameworks:
412407
default: "StaticLibraries"
413408
description: Which kind of option we want to use for `use_frameworks!`
@@ -465,7 +460,7 @@ jobs:
465460
podfile_lock_cache_key: << parameters.podfile_lock_cache_key >>
466461
steps:
467462
- run:
468-
name: Install iOS dependencies - Configuration << parameters.flavor >>; New Architecture << parameters.architecture >>; JS Engine << parameters.jsengine>>; Flipper << parameters.flipper >>
463+
name: Install iOS dependencies - Configuration << parameters.flavor >>; New Architecture << parameters.architecture >>; JS Engine << parameters.jsengine>>
469464
command: |
470465
cd /tmp/$PROJECT_NAME/ios
471466
@@ -477,10 +472,6 @@ jobs:
477472
export USE_HERMES=0
478473
fi
479474
480-
if [[ << parameters.flipper >> == "WithoutFlipper" ]]; then
481-
export NO_FLIPPER=1
482-
fi
483-
484475
if [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then
485476
export USE_FRAMEWORKS=dynamic
486477
fi
@@ -561,7 +552,6 @@ jobs:
561552
fi
562553
563554
if [[ << parameters.use_frameworks >> == "DynamicFrameworks" ]]; then
564-
export NO_FLIPPER=1
565555
export USE_FRAMEWORKS=dynamic
566556
fi
567557

‎.circleci/configurations/test_workflows/testAll.yml

Lines changed: 5 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -69,83 +69,12 @@
6969
architecture: ["NewArch", "OldArch"]
7070
flavor: ["Debug", "Release"]
7171
jsengine: ["Hermes", "JSC"]
72-
flipper: ["WithFlipper", "WithoutFlipper"]
7372
use_frameworks: ["StaticLibraries", "DynamicFrameworks"]
7473
exclude:
75-
- architecture: "NewArch"
76-
flavor: "Release"
77-
jsengine: "Hermes"
78-
flipper: "WithFlipper"
79-
use_frameworks: "StaticLibraries"
80-
- architecture: "NewArch"
81-
flavor: "Release"
82-
jsengine: "Hermes"
83-
flipper: "WithFlipper"
84-
use_frameworks: "DynamicFrameworks"
85-
- architecture: "NewArch"
86-
flavor: "Release"
87-
jsengine: "JSC"
88-
flipper: "WithFlipper"
89-
use_frameworks: "StaticLibraries"
90-
- architecture: "NewArch"
91-
flavor: "Release"
92-
jsengine: "JSC"
93-
flipper: "WithFlipper"
94-
use_frameworks: "DynamicFrameworks"
95-
- architecture: "OldArch"
96-
flavor: "Release"
97-
jsengine: "Hermes"
98-
flipper: "WithFlipper"
99-
use_frameworks: "StaticLibraries"
100-
- architecture: "OldArch"
101-
flavor: "Release"
102-
jsengine: "Hermes"
103-
flipper: "WithFlipper"
104-
use_frameworks: "DynamicFrameworks"
105-
- architecture: "OldArch"
106-
flavor: "Release"
107-
jsengine: "JSC"
108-
flipper: "WithFlipper"
109-
use_frameworks: "StaticLibraries"
110-
- architecture: "OldArch"
111-
flavor: "Release"
112-
jsengine: "JSC"
113-
flipper: "WithFlipper"
114-
use_frameworks: "DynamicFrameworks"
74+
# This config is tested with Ruby 3.2.0. Let's not double test it.
11575
- architecture: "NewArch"
11676
flavor: "Debug"
11777
jsengine: "Hermes"
118-
flipper: "WithFlipper"
119-
use_frameworks: "DynamicFrameworks"
120-
- architecture: "NewArch"
121-
flavor: "Debug"
122-
jsengine: "JSC"
123-
flipper: "WithFlipper"
124-
use_frameworks: "DynamicFrameworks"
125-
- architecture: "OldArch"
126-
flavor: "Debug"
127-
jsengine: "Hermes"
128-
flipper: "WithFlipper"
129-
use_frameworks: "DynamicFrameworks"
130-
- architecture: "OldArch"
131-
flavor: "Debug"
132-
jsengine: "JSC"
133-
flipper: "WithFlipper"
134-
use_frameworks: "DynamicFrameworks"
135-
- architecture: "NewArch"
136-
flavor: "Debug"
137-
jsengine: "Hermes"
138-
flipper: "WithFlipper"
139-
use_frameworks: "StaticLibraries"
140-
- architecture: "NewArch"
141-
flavor: "Debug"
142-
jsengine: "JSC"
143-
flipper: "WithFlipper"
144-
use_frameworks: "StaticLibraries"
145-
- architecture: "OldArch"
146-
flavor: "Debug"
147-
jsengine: "JSC"
148-
flipper: "WithFlipper"
14978
use_frameworks: "StaticLibraries"
15079
- test_ios_rntester:
15180
requires:
@@ -170,6 +99,10 @@
17099
- architecture: "OldArch"
171100
jsengine: "JSC"
172101
use_frameworks: "StaticLibraries"
102+
# Tested with Ruby 3.2.0, do not test this twice.
103+
- architecture: "NewArch"
104+
jsengine: "Hermes"
105+
use_frameworks: "StaticLibraries"
173106
- test_ios_rntester:
174107
run_unit_tests: true
175108
architecture: "OldArch"

‎.circleci/configurations/test_workflows/testIOS.yml

Lines changed: 5 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -60,83 +60,12 @@
6060
architecture: ["NewArch", "OldArch"]
6161
flavor: ["Debug", "Release"]
6262
jsengine: ["Hermes", "JSC"]
63-
flipper: ["WithFlipper", "WithoutFlipper"]
6463
use_frameworks: ["StaticLibraries", "DynamicFrameworks"]
6564
exclude:
66-
- architecture: "NewArch"
67-
flavor: "Release"
68-
jsengine: "Hermes"
69-
flipper: "WithFlipper"
70-
use_frameworks: "StaticLibraries"
71-
- architecture: "NewArch"
72-
flavor: "Release"
73-
jsengine: "Hermes"
74-
flipper: "WithFlipper"
75-
use_frameworks: "DynamicFrameworks"
76-
- architecture: "NewArch"
77-
flavor: "Release"
78-
jsengine: "JSC"
79-
flipper: "WithFlipper"
80-
use_frameworks: "StaticLibraries"
81-
- architecture: "NewArch"
82-
flavor: "Release"
83-
jsengine: "JSC"
84-
flipper: "WithFlipper"
85-
use_frameworks: "DynamicFrameworks"
86-
- architecture: "OldArch"
87-
flavor: "Release"
88-
jsengine: "Hermes"
89-
flipper: "WithFlipper"
90-
use_frameworks: "StaticLibraries"
91-
- architecture: "OldArch"
92-
flavor: "Release"
93-
jsengine: "Hermes"
94-
flipper: "WithFlipper"
95-
use_frameworks: "DynamicFrameworks"
96-
- architecture: "OldArch"
97-
flavor: "Release"
98-
jsengine: "JSC"
99-
flipper: "WithFlipper"
100-
use_frameworks: "StaticLibraries"
101-
- architecture: "OldArch"
102-
flavor: "Release"
103-
jsengine: "JSC"
104-
flipper: "WithFlipper"
105-
use_frameworks: "DynamicFrameworks"
65+
# Tested with Ruby 3.2.0, let's not double test this
10666
- architecture: "NewArch"
10767
flavor: "Debug"
10868
jsengine: "Hermes"
109-
flipper: "WithFlipper"
110-
use_frameworks: "DynamicFrameworks"
111-
- architecture: "NewArch"
112-
flavor: "Debug"
113-
jsengine: "JSC"
114-
flipper: "WithFlipper"
115-
use_frameworks: "DynamicFrameworks"
116-
- architecture: "OldArch"
117-
flavor: "Debug"
118-
jsengine: "Hermes"
119-
flipper: "WithFlipper"
120-
use_frameworks: "DynamicFrameworks"
121-
- architecture: "OldArch"
122-
flavor: "Debug"
123-
jsengine: "JSC"
124-
flipper: "WithFlipper"
125-
use_frameworks: "DynamicFrameworks"
126-
- architecture: "NewArch"
127-
flavor: "Debug"
128-
jsengine: "Hermes"
129-
flipper: "WithFlipper"
130-
use_frameworks: "StaticLibraries"
131-
- architecture: "NewArch"
132-
flavor: "Debug"
133-
jsengine: "JSC"
134-
flipper: "WithFlipper"
135-
use_frameworks: "StaticLibraries"
136-
- architecture: "OldArch"
137-
flavor: "Debug"
138-
jsengine: "JSC"
139-
flipper: "WithFlipper"
14069
use_frameworks: "StaticLibraries"
14170
- test_ios_rntester:
14271
requires:
@@ -161,6 +90,10 @@
16190
- architecture: "OldArch"
16291
jsengine: "JSC"
16392
use_frameworks: "StaticLibraries"
93+
# Tested with Ruby 3.2.0, let's not double test this
94+
- architecture: "NewArch"
95+
jsengine: "Hermes"
96+
use_frameworks: "StaticLibraries"
16497
- test_ios_rntester:
16598
run_unit_tests: true
16699
architecture: "OldArch"

0 commit comments

Comments
 (0)