Skip to content

Commit 4b163fe

Browse files
christophpurrerpull[bot]
christophpurrer
authored and
pull[bot]
committed
Use C++17 namespace for compoments (#41791)
Summary: Pull Request resolved: #41791 Same as #41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740 fbshipit-source-id: 87f4db5dabfce4639f16fdcb1b1df0fee338a555
1 parent a34a959 commit 4b163fe

25 files changed

+792
-1584
lines changed

‎packages/react-native-codegen/e2e/__tests__/components/__snapshots__/GenerateComponentDescriptorH-test.js.snap

Lines changed: 36 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@ Object {
1717
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
1818
#include <react/renderer/core/ConcreteComponentDescriptor.h>
1919
20-
namespace facebook {
21-
namespace react {
20+
namespace facebook::react {
2221
2322
using ArrayPropsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<ArrayPropsNativeComponentViewShadowNode>;
2423
25-
} // namespace react
26-
} // namespace facebook
24+
} // namespace facebook::react
2725
",
2826
}
2927
`;
@@ -45,13 +43,11 @@ Object {
4543
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
4644
#include <react/renderer/core/ConcreteComponentDescriptor.h>
4745
48-
namespace facebook {
49-
namespace react {
46+
namespace facebook::react {
5047
5148
using BooleanPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<BooleanPropNativeComponentViewShadowNode>;
5249
53-
} // namespace react
54-
} // namespace facebook
50+
} // namespace facebook::react
5551
",
5652
}
5753
`;
@@ -73,13 +69,11 @@ Object {
7369
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
7470
#include <react/renderer/core/ConcreteComponentDescriptor.h>
7571
76-
namespace facebook {
77-
namespace react {
72+
namespace facebook::react {
7873
7974
using ColorPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<ColorPropNativeComponentViewShadowNode>;
8075
81-
} // namespace react
82-
} // namespace facebook
76+
} // namespace facebook::react
8377
",
8478
}
8579
`;
@@ -101,13 +95,11 @@ Object {
10195
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
10296
#include <react/renderer/core/ConcreteComponentDescriptor.h>
10397
104-
namespace facebook {
105-
namespace react {
98+
namespace facebook::react {
10699
107100
using DimensionPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<DimensionPropNativeComponentViewShadowNode>;
108101
109-
} // namespace react
110-
} // namespace facebook
102+
} // namespace facebook::react
111103
",
112104
}
113105
`;
@@ -129,13 +121,11 @@ Object {
129121
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
130122
#include <react/renderer/core/ConcreteComponentDescriptor.h>
131123
132-
namespace facebook {
133-
namespace react {
124+
namespace facebook::react {
134125
135126
using EdgeInsetsPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<EdgeInsetsPropNativeComponentViewShadowNode>;
136127
137-
} // namespace react
138-
} // namespace facebook
128+
} // namespace facebook::react
139129
",
140130
}
141131
`;
@@ -157,13 +147,11 @@ Object {
157147
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
158148
#include <react/renderer/core/ConcreteComponentDescriptor.h>
159149
160-
namespace facebook {
161-
namespace react {
150+
namespace facebook::react {
162151
163152
using EnumPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<EnumPropNativeComponentViewShadowNode>;
164153
165-
} // namespace react
166-
} // namespace facebook
154+
} // namespace facebook::react
167155
",
168156
}
169157
`;
@@ -185,13 +173,11 @@ Object {
185173
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
186174
#include <react/renderer/core/ConcreteComponentDescriptor.h>
187175
188-
namespace facebook {
189-
namespace react {
176+
namespace facebook::react {
190177
191178
using EventNestedObjectPropsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<EventNestedObjectPropsNativeComponentViewShadowNode>;
192179
193-
} // namespace react
194-
} // namespace facebook
180+
} // namespace facebook::react
195181
",
196182
}
197183
`;
@@ -213,13 +199,11 @@ Object {
213199
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
214200
#include <react/renderer/core/ConcreteComponentDescriptor.h>
215201
216-
namespace facebook {
217-
namespace react {
202+
namespace facebook::react {
218203
219204
using EventPropsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<EventPropsNativeComponentViewShadowNode>;
220205
221-
} // namespace react
222-
} // namespace facebook
206+
} // namespace facebook::react
223207
",
224208
}
225209
`;
@@ -241,13 +225,11 @@ Object {
241225
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
242226
#include <react/renderer/core/ConcreteComponentDescriptor.h>
243227
244-
namespace facebook {
245-
namespace react {
228+
namespace facebook::react {
246229
247230
using FloatPropsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<FloatPropsNativeComponentViewShadowNode>;
248231
249-
} // namespace react
250-
} // namespace facebook
232+
} // namespace facebook::react
251233
",
252234
}
253235
`;
@@ -269,13 +251,11 @@ Object {
269251
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
270252
#include <react/renderer/core/ConcreteComponentDescriptor.h>
271253
272-
namespace facebook {
273-
namespace react {
254+
namespace facebook::react {
274255
275256
using ImagePropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<ImagePropNativeComponentViewShadowNode>;
276257
277-
} // namespace react
278-
} // namespace facebook
258+
} // namespace facebook::react
279259
",
280260
}
281261
`;
@@ -297,13 +277,11 @@ Object {
297277
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
298278
#include <react/renderer/core/ConcreteComponentDescriptor.h>
299279
300-
namespace facebook {
301-
namespace react {
280+
namespace facebook::react {
302281
303282
using IntegerPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<IntegerPropNativeComponentViewShadowNode>;
304283
305-
} // namespace react
306-
} // namespace facebook
284+
} // namespace facebook::react
307285
",
308286
}
309287
`;
@@ -325,13 +303,11 @@ Object {
325303
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
326304
#include <react/renderer/core/ConcreteComponentDescriptor.h>
327305
328-
namespace facebook {
329-
namespace react {
306+
namespace facebook::react {
330307
331308
332309
333-
} // namespace react
334-
} // namespace facebook
310+
} // namespace facebook::react
335311
",
336312
}
337313
`;
@@ -353,13 +329,11 @@ Object {
353329
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
354330
#include <react/renderer/core/ConcreteComponentDescriptor.h>
355331
356-
namespace facebook {
357-
namespace react {
332+
namespace facebook::react {
358333
359334
using MixedPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<MixedPropNativeComponentViewShadowNode>;
360335
361-
} // namespace react
362-
} // namespace facebook
336+
} // namespace facebook::react
363337
",
364338
}
365339
`;
@@ -381,13 +355,11 @@ Object {
381355
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
382356
#include <react/renderer/core/ConcreteComponentDescriptor.h>
383357
384-
namespace facebook {
385-
namespace react {
358+
namespace facebook::react {
386359
387360
using MultiNativePropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<MultiNativePropNativeComponentViewShadowNode>;
388361
389-
} // namespace react
390-
} // namespace facebook
362+
} // namespace facebook::react
391363
",
392364
}
393365
`;
@@ -409,13 +381,11 @@ Object {
409381
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
410382
#include <react/renderer/core/ConcreteComponentDescriptor.h>
411383
412-
namespace facebook {
413-
namespace react {
384+
namespace facebook::react {
414385
415386
using NoPropsNoEventsNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<NoPropsNoEventsNativeComponentViewShadowNode>;
416387
417-
} // namespace react
418-
} // namespace facebook
388+
} // namespace facebook::react
419389
",
420390
}
421391
`;
@@ -437,13 +407,11 @@ Object {
437407
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
438408
#include <react/renderer/core/ConcreteComponentDescriptor.h>
439409
440-
namespace facebook {
441-
namespace react {
410+
namespace facebook::react {
442411
443412
using ObjectPropsNativeComponentComponentDescriptor = ConcreteComponentDescriptor<ObjectPropsNativeComponentShadowNode>;
444413
445-
} // namespace react
446-
} // namespace facebook
414+
} // namespace facebook::react
447415
",
448416
}
449417
`;
@@ -465,13 +433,11 @@ Object {
465433
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
466434
#include <react/renderer/core/ConcreteComponentDescriptor.h>
467435
468-
namespace facebook {
469-
namespace react {
436+
namespace facebook::react {
470437
471438
using PointPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<PointPropNativeComponentViewShadowNode>;
472439
473-
} // namespace react
474-
} // namespace facebook
440+
} // namespace facebook::react
475441
",
476442
}
477443
`;
@@ -493,13 +459,11 @@ Object {
493459
#include <react/renderer/components/RNCodegenModuleFixtures/ShadowNodes.h>
494460
#include <react/renderer/core/ConcreteComponentDescriptor.h>
495461
496-
namespace facebook {
497-
namespace react {
462+
namespace facebook::react {
498463
499464
using StringPropNativeComponentViewComponentDescriptor = ConcreteComponentDescriptor<StringPropNativeComponentViewShadowNode>;
500465
501-
} // namespace react
502-
} // namespace facebook
466+
} // namespace facebook::react
503467
",
504468
}
505469
`;

0 commit comments

Comments
 (0)