Skip to content

Commit 545366a

Browse files
aeulitzfacebook-github-bot
authored andcommitted
Pass execution context ID in Debugger.scriptParsed event (#34640)
Summary: As generated by ReactCommon code, the CDP [Debugger.scriptParsed](https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#event-scriptParsed) event carries a zero execution context ID. It should match the execution context ID contained in the []() argument of the [Runtime.executionContextCreated](https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#event-executionContextCreated) event. Tracking issue is RN:34639](#34639). ## Changelog [General] [Changed] - Correct execution context ID in Debugger.scriptParsed event. Pull Request resolved: #34640 Test Plan: Verified via packet tracer (Wireshark, Chrome DevTools protocol monitor) that Debugger.scriptParsed carries execution context ID. Reviewed By: jpporto Differential Revision: D39385622 Pulled By: mattbfb fbshipit-source-id: 9060041cfa2a784adf4ad371fbe63f530e3362ad
1 parent 09a910f commit 545366a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

ReactCommon/hermes/inspector/chrome/Connection.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,7 @@ void Connection::Impl::onScriptParsed(
390390
m::debugger::ScriptParsedNotification note;
391391
note.scriptId = folly::to<std::string>(info.fileId);
392392
note.url = info.fileName;
393-
// TODO(jpporto): fix test cases sending invalid context id.
394-
// note.executionContextId = kHermesExecutionContextId;
393+
note.executionContextId = kHermesExecutionContextId;
395394

396395
if (!info.sourceMappingUrl.empty()) {
397396
note.sourceMapURL = info.sourceMappingUrl;

0 commit comments

Comments
 (0)