Make TextInput.onContentSizeChange event direct (#41012)

sammy-SC · facebook-github-bot · commit 744fb4a0d23d · 2023-10-17T05:36:59.000-07:00
Summary: Pull Request resolved: #41012 changelog: [iOS][Breaking] Make TextInput.onContentSizeChange a direct event TextInput.onContentSizeChange should be a direct event. It is a [direct event on Android](https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/NativeComponent/BaseViewConfig.android.js#L126C3-L126C23) and even on iOS there are traits that it was meant to be a direct event (https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputShadowView.h#L19C47-L19C47) Seems like an oversight. Reviewed By: javache Differential Revision: D50323402 fbshipit-source-id: 3d1b1f1f0df010d61fbab672ef30e06cf2e2ad39
diff --git a/packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputViewManager.mm b/packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputViewManager.mm
@@ -71,7 +71,7 @@ @implementation RCTBaseTextInputViewManager {
 
 RCT_EXPORT_SHADOW_PROPERTY(text, NSString)
 RCT_EXPORT_SHADOW_PROPERTY(placeholder, NSString)
-RCT_EXPORT_SHADOW_PROPERTY(onContentSizeChange, RCTBubblingEventBlock)
+RCT_EXPORT_SHADOW_PROPERTY(onContentSizeChange, RCTDirectEventBlock)
 
 RCT_CUSTOM_VIEW_PROPERTY(multiline, BOOL, UIView)
 {

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ @implementation RCTBaseTextInputViewManager {`
`71`	`71`
`72`	`72`	`RCT_EXPORT_SHADOW_PROPERTY(text, NSString)`
`73`	`73`	`RCT_EXPORT_SHADOW_PROPERTY(placeholder, NSString)`
`74`		`-RCT_EXPORT_SHADOW_PROPERTY(onContentSizeChange, RCTBubblingEventBlock)`
	`74`	`+RCT_EXPORT_SHADOW_PROPERTY(onContentSizeChange, RCTDirectEventBlock)`
`75`	`75`
`76`	`76`	`RCT_CUSTOM_VIEW_PROPERTY(multiline, BOOL, UIView)`
`77`	`77`	`{`