Skip to content

Commit c21e36d

Browse files
sunnylqmfacebook-github-bot
authored andcommitted
Bump hermes to v0.1.1 (#25908)
Summary: Hermes has been updated to [v0.1.1](https://github.com/facebook/hermes/releases/tag/v0.1.1) and [renamed from 'hermesvm' to 'hermes-engine'](facebook/hermes@c74842e) ## Changelog [Android] [Changed] - Bump hermes to v0.1.1 Pull Request resolved: #25908 Test Plan: RNTester builds and runs as expected Differential Revision: D16645811 Pulled By: cpojer fbshipit-source-id: 4fb6a3160df2c6d08140dd1fee51acf9ff8baffc
1 parent a5b925d commit c21e36d

File tree

8 files changed

+16
-16
lines changed

8 files changed

+16
-16
lines changed

RNTester/android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ project.ext.react = [
7070
root: "$rootDir",
7171
inputExcludes: ["android/**", "./**", ".gradle/**"],
7272
composeSourceMapsPath: "$rootDir/scripts/compose-source-maps.js",
73-
hermesCommand: "../../../node_modules/hermesvm/%OS-BIN%/hermes",
73+
hermesCommand: "../../../node_modules/hermes-engine/%OS-BIN%/hermes",
7474
enableHermesForVariant: { def v -> v.name.contains("hermes") }
7575
]
7676

@@ -165,7 +165,7 @@ dependencies {
165165
// Build React Native from source
166166
implementation project(':ReactAndroid')
167167

168-
def hermesPath = '$projectDir/../../../../node_modules/hermesvm/android/'
168+
def hermesPath = '$projectDir/../../../../node_modules/hermes-engine/android/'
169169
debugImplementation files(hermesPath + "hermes-debug.aar")
170170
releaseImplementation files(hermesPath + "hermes-release.aar")
171171

ReactAndroid/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,15 +92,15 @@ task prepareFolly(dependsOn: dependenciesPath ? [] : [downloadFolly], type: Copy
9292
}
9393

9494
task prepareHermes() {
95-
def hermesAAR = file("$projectDir/../node_modules/hermesvm/android/hermes-debug.aar")
95+
def hermesAAR = file("$projectDir/../node_modules/hermes-engine/android/hermes-debug.aar")
9696
if (!hermesAAR.exists()) {
97-
// For an app to build from RN source, hermesvm is located at /path/to/app/node_modules
97+
// For an app to build from RN source, hermes-engine is located at /path/to/app/node_modules
9898
// and $projectDir is located at /path/to/app/node_modules/react-native/ReactAndroid
99-
hermesAAR = file("$projectDir/../../hermesvm/android/hermes-debug.aar")
99+
hermesAAR = file("$projectDir/../../hermes-engine/android/hermes-debug.aar")
100100

101101
if (!hermesAAR.exists()) {
102102
// At Facebook, this file is in a different folder
103-
hermesAAR = file("$projectDir/../../node_modules/hermesvm/android/hermes-debug.aar")
103+
hermesAAR = file("$projectDir/../../node_modules/hermes-engine/android/hermes-debug.aar")
104104
}
105105
}
106106
def soFiles = zipTree(hermesAAR).matching({ it.include "**/*.so" })

ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/Android.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ LOCAL_MODULE := hermes-executor-release
1212

1313
LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp)
1414

15-
LOCAL_C_INCLUDES := $(LOCAL_PATH) $(REACT_NATIVE)/ReactCommon/jsi $(REACT_NATIVE)/node_modules/hermesvm/android/include $(REACT_NATIVE)/../hermesvm/android/include $(REACT_NATIVE)/../node_modules/hermesvm/include
15+
LOCAL_C_INCLUDES := $(LOCAL_PATH) $(REACT_NATIVE)/ReactCommon/jsi $(REACT_NATIVE)/node_modules/hermes-engine/android/include $(REACT_NATIVE)/../hermes-engine/android/include $(REACT_NATIVE)/../node_modules/hermes-engine/include
1616

1717
LOCAL_CPP_FEATURES := exceptions
1818

@@ -30,7 +30,7 @@ LOCAL_CFLAGS := -DHERMES_ENABLE_DEBUGGER=1
3030

3131
LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp)
3232

33-
LOCAL_C_INCLUDES := $(LOCAL_PATH) $(REACT_NATIVE)/ReactCommon/jsi $(REACT_NATIVE)/node_modules/hermesvm/android/include $(REACT_NATIVE)/../hermesvm/android/include $(REACT_NATIVE)/../node_modules/hermesvm/include
33+
LOCAL_C_INCLUDES := $(LOCAL_PATH) $(REACT_NATIVE)/ReactCommon/jsi $(REACT_NATIVE)/node_modules/hermes-engine/android/include $(REACT_NATIVE)/../hermes-engine/android/include $(REACT_NATIVE)/../node_modules/hermes-engine/include
3434

3535
LOCAL_CPP_FEATURES := exceptions
3636

ReactCommon/hermes/inspector/Android.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp $(LOCAL_PATH)/detail/*.cpp $(L
1515
LOCAL_C_ROOT := $(LOCAL_PATH)/../..
1616

1717
LOCAL_CFLAGS := -DHERMES_ENABLE_DEBUGGER=1
18-
LOCAL_C_INCLUDES := $(LOCAL_C_ROOT) $(REACT_NATIVE)/ReactCommon/jsi $(REACT_NATIVE)/node_modules/hermesvm/android/include $(REACT_NATIVE)/../hermesvm/android/include $(REACT_NATIVE)/../node_modules/hermesvm/include
18+
LOCAL_C_INCLUDES := $(LOCAL_C_ROOT) $(REACT_NATIVE)/ReactCommon/jsi $(REACT_NATIVE)/node_modules/hermes-engine/android/include $(REACT_NATIVE)/../hermes-engine/android/include $(REACT_NATIVE)/../node_modules/hermes-engine/include
1919
LOCAL_EXPORT_C_INCLUDES := $(LOCAL_C_ROOT)
2020

2121
LOCAL_CPP_FEATURES := exceptions

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
"event-target-shim": "^5.0.1",
9898
"fbjs": "^1.0.0",
9999
"fbjs-scripts": "^1.1.0",
100-
"hermesvm": "^0.1.0",
100+
"hermes-engine": "^0.1.1",
101101
"invariant": "^2.2.4",
102102
"jsc-android": "^245459.0.0",
103103
"metro-babel-register": "0.54.1",

react.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def reactRoot = file(config.root ?: "../../")
1616
def inputExcludes = config.inputExcludes ?: ["android/**", "ios/**"]
1717
def bundleConfig = config.bundleConfig ? "${reactRoot}/${config.bundleConfig}" : null ;
1818
def enableVmCleanup = config.enableVmCleanup == null ? true : config.enableVmCleanup
19-
def hermesCommand = config.hermesCommand ?: "../../node_modules/hermesvm/%OS-BIN%/hermes"
19+
def hermesCommand = config.hermesCommand ?: "../../node_modules/hermes-engine/%OS-BIN%/hermes"
2020

2121
def reactNativeDevServerPort() {
2222
def value = project.getProperties().get("reactNativeDevServerPort")

template/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ dependencies {
192192
implementation "com.facebook.react:react-native:+" // From node_modules
193193

194194
if (enableHermes) {
195-
def hermesPath = "../../node_modules/hermesvm/android/";
195+
def hermesPath = "../../node_modules/hermes-engine/android/";
196196
debugImplementation files(hermesPath + "hermes-debug.aar")
197197
releaseImplementation files(hermesPath + "hermes-release.aar")
198198
} else {

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3459,10 +3459,10 @@ has@^1.0.1, has@^1.0.3:
34593459
dependencies:
34603460
function-bind "^1.1.1"
34613461

3462-
hermesvm@^0.1.0:
3463-
version "0.1.0"
3464-
resolved "https://registry.yarnpkg.com/hermesvm/-/hermesvm-0.1.0.tgz#4bfaf4ac682a2fd407b862ab641eb8deb232de83"
3465-
integrity sha512-GbP6dKaVW/V2QpB+DZPxcmhBhJVFa9cHS/xRX7FD1MGfa6Z1aHHD83VDCwo3SgcqNj5yHlVbe9UgrK1PFGCXpw==
3462+
hermes-engine@^0.1.1:
3463+
version "0.1.1"
3464+
resolved "https://registry.yarnpkg.com/hermes-engine/-/hermes-engine-0.1.1.tgz#33d5da1a3b7289667f121dc1aca3566171e86fd8"
3465+
integrity sha512-5nPNtJg3ZiUT14SfU5KcETWrDFadn9R0hv2FCihiLZUeNHuLxaoiFy0bAMrXukKPyXG76XZ4zl5iGXr7E7Nhpw==
34663466

34673467
home-or-tmp@^3.0.0:
34683468
version "3.0.0"

0 commit comments

Comments
 (0)