Skip to content

Commit d282ebe

Browse files
robhoganfacebook-github-bot
authored andcommitted
Verdaccio: proxy @react-native/normalize-colors from NPM (#40971)
Summary: To address the root cause of a recurring issue (#40797, #39692) where breaking changes to `react-native/normalize-colors` would be pulled into old versions of `deprecated-react-native-prop-types`, we recently change the dependency in the latter to use a semver range (facebook/react-native-deprecated-modules#27, #40869). For CI, we generally force `react-native/*` to be resolved only from Verdaccio locally published packages - ie, the current versions at source. The source version (currently `0.74.1`) isn't semver-compatible with `deprecated-react-native-prop-types`'s dependency (`^0.73.0`), so `npm install` was failing in CI with "no package found". We should be getting `0.73.2` from the public registry in this case. This restores a previous workaround added in #34571 but not updated since facebook/react-native-deprecated-modules#11 meant the dependency was now on the pluralised package. We have no dependency on the old non-plural package any more. ## Changelog: [INTERNAL] [FIXED] - CI/Verdaccio: Proxy `react-native/normalize-colors` from NPM for the `deprecated-react-native-prop-types` dependency. Pull Request resolved: #40971 Test Plan: CI Reviewed By: cipolleschi Differential Revision: D50298291 Pulled By: robhogan fbshipit-source-id: 4bf6503108335ffa52654346d1874c217071ff91
1 parent 9497203 commit d282ebe

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.circleci/verdaccio.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ uplinks:
1515
maxSockets: 40
1616
maxFreeSockets: 10
1717
packages:
18-
# Get @react-native/normalize-color from npm registry, since its used in deprecated-react-native-prop-types package
19-
'@react-native/normalize-color':
18+
# Get @react-native/normalize-colors from npm registry, since its used in deprecated-react-native-prop-types package
19+
'@react-native/normalize-colors':
2020
access: $all
2121
publish: $authenticated
2222
proxy: npmjs

0 commit comments

Comments
 (0)