Skip to content

Commit d7d5de9

Browse files
cortinicofacebook-github-bot
authored andcommitted
Stable API - Make NativeModulePerfLogger internal (#47415)
Summary: Pull Request resolved: #47415 This class should not be accessed directly, therefore I'm making it internal. Technically breaking but I verified that there are no meaningful usages in OSS: https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+com.facebook.react.reactperflogger.NativeModulePerfLogger Changelog: [Android] [Breaking] - Stable API - Make NativeModulePerfLogger internal Reviewed By: mdvacca Differential Revision: D65479550 fbshipit-source-id: 545c33e2c526e396084af65fc19314f59c8a74f8
1 parent d1fb01c commit d7d5de9

File tree

2 files changed

+11
-27
lines changed

2 files changed

+11
-27
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3763,22 +3763,6 @@ public abstract interface class com/facebook/react/packagerconnection/Responder
37633763
public abstract fun respond (Ljava/lang/Object;)V
37643764
}
37653765

3766-
public abstract class com/facebook/react/reactperflogger/NativeModulePerfLogger {
3767-
protected fun <init> ()V
3768-
protected abstract fun initHybrid ()Lcom/facebook/jni/HybridData;
3769-
protected final fun maybeLoadOtherSoLibraries ()V
3770-
public abstract fun moduleCreateCacheHit (Ljava/lang/String;I)V
3771-
public abstract fun moduleCreateConstructEnd (Ljava/lang/String;I)V
3772-
public abstract fun moduleCreateConstructStart (Ljava/lang/String;I)V
3773-
public abstract fun moduleCreateEnd (Ljava/lang/String;I)V
3774-
public abstract fun moduleCreateFail (Ljava/lang/String;I)V
3775-
public abstract fun moduleCreateSetUpEnd (Ljava/lang/String;I)V
3776-
public abstract fun moduleCreateSetUpStart (Ljava/lang/String;I)V
3777-
public abstract fun moduleCreateStart (Ljava/lang/String;I)V
3778-
public abstract fun moduleDataCreateEnd (Ljava/lang/String;I)V
3779-
public abstract fun moduleDataCreateStart (Ljava/lang/String;I)V
3780-
}
3781-
37823766
public abstract class com/facebook/react/runtime/BindingsInstaller {
37833767
public fun <init> (Lcom/facebook/jni/HybridData;)V
37843768
}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/NativeModulePerfLogger.kt

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ package com.facebook.react.reactperflogger
99

1010
import com.facebook.jni.HybridData
1111

12-
public abstract class NativeModulePerfLogger protected constructor() {
12+
internal abstract class NativeModulePerfLogger protected constructor() {
1313

1414
@Suppress("NoHungarianNotation") private val mHybridData: HybridData
1515

@@ -20,25 +20,25 @@ public abstract class NativeModulePerfLogger protected constructor() {
2020

2121
protected abstract fun initHybrid(): HybridData
2222

23-
public abstract fun moduleDataCreateStart(moduleName: String, id: Int)
23+
abstract fun moduleDataCreateStart(moduleName: String, id: Int)
2424

25-
public abstract fun moduleDataCreateEnd(moduleName: String, id: Int)
25+
abstract fun moduleDataCreateEnd(moduleName: String, id: Int)
2626

27-
public abstract fun moduleCreateStart(moduleName: String, id: Int)
27+
abstract fun moduleCreateStart(moduleName: String, id: Int)
2828

29-
public abstract fun moduleCreateCacheHit(moduleName: String, id: Int)
29+
abstract fun moduleCreateCacheHit(moduleName: String, id: Int)
3030

31-
public abstract fun moduleCreateConstructStart(moduleName: String, id: Int)
31+
abstract fun moduleCreateConstructStart(moduleName: String, id: Int)
3232

33-
public abstract fun moduleCreateConstructEnd(moduleName: String, id: Int)
33+
abstract fun moduleCreateConstructEnd(moduleName: String, id: Int)
3434

35-
public abstract fun moduleCreateSetUpStart(moduleName: String, id: Int)
35+
abstract fun moduleCreateSetUpStart(moduleName: String, id: Int)
3636

37-
public abstract fun moduleCreateSetUpEnd(moduleName: String, id: Int)
37+
abstract fun moduleCreateSetUpEnd(moduleName: String, id: Int)
3838

39-
public abstract fun moduleCreateEnd(moduleName: String, id: Int)
39+
abstract fun moduleCreateEnd(moduleName: String, id: Int)
4040

41-
public abstract fun moduleCreateFail(moduleName: String, id: Int)
41+
abstract fun moduleCreateFail(moduleName: String, id: Int)
4242

4343
/** Subclasses will override this method to load their own SO libraries. */
4444
@Synchronized

0 commit comments

Comments
 (0)