Skip to content

Commit db600b2

Browse files
robhogancipolleschi
authored andcommitted
[LOCAL] Backout #46896 - Attempt to fix #50274 (#52515)
1 parent a853919 commit db600b2

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1399,14 +1399,14 @@ private void detachRootViewFromInstance(ReactRoot reactRoot, ReactContext reactC
13991399
new RuntimeException(
14001400
"detachRootViewFromInstance called with ReactRootView with invalid id"));
14011401
}
1402-
1403-
clearReactRoot(reactRoot);
14041402
} else {
14051403
reactContext
14061404
.getCatalystInstance()
14071405
.getJSModule(AppRegistry.class)
14081406
.unmountApplicationComponentAtRootTag(reactRoot.getRootViewTag());
14091407
}
1408+
1409+
clearReactRoot(reactRoot);
14101410
}
14111411

14121412
@ThreadConfined(UI)

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -671,9 +671,6 @@ public synchronized void removeRootView(int rootViewTag) {
671671
View rootView = mTagsToViews.get(rootViewTag);
672672
dropView(rootView);
673673
mRootTags.delete(rootViewTag);
674-
if (rootView != null) {
675-
rootView.setId(View.NO_ID);
676-
}
677674
}
678675

679676
/**

0 commit comments

Comments
 (0)