Skip to content

Commit f25abe5

Browse files
cortinicofacebook-github-bot
authored andcommitted
Remove Deprecated DefaultDevSupportManagerFactory.create() (#46959)
Summary: Pull Request resolved: #46959 This method was deprecated in: b8893c7 since React Native 0.72. I verified that no-one is using it in OSS so I'm removing it. This is necessary as I'll need to refactor the BridgelessDevSupportManager a bit. Changelog: [Android] [Breaking] - Remove Deprecated DefaultDevSupportManagerFactory.create() Reviewed By: javache Differential Revision: D64184635 fbshipit-source-id: a4081b2189d2e22cd9b2067f982a6ffd4f8b054e
1 parent e4bdde6 commit f25abe5

File tree

2 files changed

+0
-26
lines changed

2 files changed

+0
-26
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2133,7 +2133,6 @@ public final class com/facebook/react/devsupport/DefaultDevLoadingViewImplementa
21332133

21342134
public final class com/facebook/react/devsupport/DefaultDevSupportManagerFactory : com/facebook/react/devsupport/DevSupportManagerFactory {
21352135
public fun <init> ()V
2136-
public final fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZI)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
21372136
public fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
21382137
}
21392138

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -23,31 +23,6 @@ import com.facebook.react.packagerconnection.RequestHandler
2323
*/
2424
public class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
2525

26-
@Deprecated(
27-
"in favor of the customisable create for DevSupportManagerFactory",
28-
ReplaceWith(
29-
"create(applicationContext, reactInstanceManagerHelper, packagerPathForJSBundleName, enableOnCreate, redBoxHandler, devBundleDownloadListener, minNumShakes, customPackagerCommandHandlers, surfaceDelegateFactory, devLoadingViewManager, pausedInDebuggerOverlayManager)"))
30-
public fun create(
31-
applicationContext: Context,
32-
reactInstanceDevHelper: ReactInstanceDevHelper,
33-
packagerPathForJSBundleName: String?,
34-
enableOnCreate: Boolean,
35-
minNumShakes: Int
36-
): DevSupportManager {
37-
return create(
38-
applicationContext,
39-
reactInstanceDevHelper,
40-
packagerPathForJSBundleName,
41-
enableOnCreate,
42-
null,
43-
null,
44-
minNumShakes,
45-
null,
46-
null,
47-
null,
48-
null)
49-
}
50-
5126
public override fun create(
5227
applicationContext: Context,
5328
reactInstanceManagerHelper: ReactInstanceDevHelper,

0 commit comments

Comments
 (0)