From 8227c4f0f0e03dbf9fceb6685d35a7cb8bfbe7e6 Mon Sep 17 00:00:00 2001 From: Brent Vatne Date: Thu, 28 May 2015 19:59:25 -0700 Subject: [PATCH] [UIManager] Remove updateView viewName param --- Libraries/ReactIOS/NativeMethodsMixin.js | 1 - Libraries/ReactNative/ReactNativeBaseComponent.js | 1 - Libraries/ReactNative/ReactNativeTextComponent.js | 1 - React/Modules/RCTUIManager.m | 2 -- 4 files changed, 5 deletions(-) diff --git a/Libraries/ReactIOS/NativeMethodsMixin.js b/Libraries/ReactIOS/NativeMethodsMixin.js index e31b0e43a85a18..e61d65846f1eeb 100644 --- a/Libraries/ReactIOS/NativeMethodsMixin.js +++ b/Libraries/ReactIOS/NativeMethodsMixin.js @@ -115,7 +115,6 @@ var NativeMethodsMixin = { RCTUIManager.updateView( findNodeHandle(this), - this.viewConfig.uiViewClassName, props ); }, diff --git a/Libraries/ReactNative/ReactNativeBaseComponent.js b/Libraries/ReactNative/ReactNativeBaseComponent.js index 95af2902353007..410e37ca41ce9a 100644 --- a/Libraries/ReactNative/ReactNativeBaseComponent.js +++ b/Libraries/ReactNative/ReactNativeBaseComponent.js @@ -196,7 +196,6 @@ ReactNativeBaseComponent.Mixin = { if (updatePayload) { RCTUIManager.updateView( ReactNativeTagHandles.mostRecentMountedNodeHandleForRootNodeID(this._rootNodeID), - this.viewConfig.uiViewClassName, updatePayload ); } diff --git a/Libraries/ReactNative/ReactNativeTextComponent.js b/Libraries/ReactNative/ReactNativeTextComponent.js index bdca141c06424f..b2743fe2d25f72 100644 --- a/Libraries/ReactNative/ReactNativeTextComponent.js +++ b/Libraries/ReactNative/ReactNativeTextComponent.js @@ -49,7 +49,6 @@ assign(ReactNativeTextComponent.prototype, { ReactNativeTagHandles.mostRecentMountedNodeHandleForRootNodeID( this._rootNodeID ), - 'RCTRawText', {text: this._stringText} ); } diff --git a/React/Modules/RCTUIManager.m b/React/Modules/RCTUIManager.m index 0edca85d9ed0e7..0c96b160795da1 100644 --- a/React/Modules/RCTUIManager.m +++ b/React/Modules/RCTUIManager.m @@ -849,9 +849,7 @@ static void RCTSetShadowViewProps(NSDictionary *props, RCTShadowView *shadowView }]; } -// TODO: remove viewName param as it isn't needed RCT_EXPORT_METHOD(updateView:(NSNumber *)reactTag - viewName:(__unused NSString *)_ props:(NSDictionary *)props) { RCTViewManager *viewManager = _viewManagerRegistry[reactTag];