From a119642b876fe31b9ddc9d65cb32ffc611c4a319 Mon Sep 17 00:00:00 2001 From: nd-02110114 Date: Sun, 4 Nov 2018 12:30:09 +0900 Subject: [PATCH 1/3] add flow strict --- Libraries/Components/DatePicker/DatePickerIOS.ios.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Libraries/Components/DatePicker/DatePickerIOS.ios.js b/Libraries/Components/DatePicker/DatePickerIOS.ios.js index 8df54ec3169b93..a2f56e72fd0519 100644 --- a/Libraries/Components/DatePicker/DatePickerIOS.ios.js +++ b/Libraries/Components/DatePicker/DatePickerIOS.ios.js @@ -8,7 +8,7 @@ * This is a controlled component version of RCTDatePickerIOS * * @format - * @flow + * @flow strict-local */ 'use strict'; @@ -21,10 +21,15 @@ const View = require('View'); const requireNativeComponent = require('requireNativeComponent'); import type {ViewProps} from 'ViewPropTypes'; +import type {SyntheticEvent} from 'CoreEventTypes'; const RCTDatePickerIOS = requireNativeComponent('RCTDatePicker'); -type Event = Object; +type Event = SyntheticEvent< + $ReadOnly<{| + timestamp: string | number, + |}>, +>; type Props = $ReadOnly<{| ...ViewProps, @@ -154,7 +159,7 @@ class DatePickerIOS extends React.Component { ? props.initialDate.getTime() : undefined } - locale={props.locale ? props.locale : undefined} + locale={props.locale} maximumDate={ props.maximumDate ? props.maximumDate.getTime() : undefined } From debbcfd37f15ee594336225d142a2096f4b0118c Mon Sep 17 00:00:00 2001 From: nd-02110114 Date: Sun, 4 Nov 2018 16:49:34 +0900 Subject: [PATCH 2/3] fix annotation --- Libraries/Components/DatePicker/DatePickerIOS.ios.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/Components/DatePicker/DatePickerIOS.ios.js b/Libraries/Components/DatePicker/DatePickerIOS.ios.js index a2f56e72fd0519..73e8090183a1d8 100644 --- a/Libraries/Components/DatePicker/DatePickerIOS.ios.js +++ b/Libraries/Components/DatePicker/DatePickerIOS.ios.js @@ -27,7 +27,7 @@ const RCTDatePickerIOS = requireNativeComponent('RCTDatePicker'); type Event = SyntheticEvent< $ReadOnly<{| - timestamp: string | number, + timestamp: number, |}>, >; From 1ce3ef82a8eb3b0097300addadd8734faa22f394 Mon Sep 17 00:00:00 2001 From: nd-02110114 Date: Mon, 5 Nov 2018 11:06:10 +0900 Subject: [PATCH 3/3] fix error --- Libraries/Components/DatePicker/DatePickerIOS.ios.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Libraries/Components/DatePicker/DatePickerIOS.ios.js b/Libraries/Components/DatePicker/DatePickerIOS.ios.js index 73e8090183a1d8..ff78c9f0fb44c3 100644 --- a/Libraries/Components/DatePicker/DatePickerIOS.ios.js +++ b/Libraries/Components/DatePicker/DatePickerIOS.ios.js @@ -159,7 +159,11 @@ class DatePickerIOS extends React.Component { ? props.initialDate.getTime() : undefined } - locale={props.locale} + locale={ + props.locale != null && props.locale !== '' + ? props.locale + : undefined + } maximumDate={ props.maximumDate ? props.maximumDate.getTime() : undefined }