Added e2e tests for npm@2 and npm@3 #6364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considering that community runs both we need to make sure that react native can be published and installed with both
|
@frantic now the exit codes and stderr is ok? |
|
By analyzing the blame information on this pull request, we identified @mkonicek, @bestander and @frantic to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@mkonicek this is what you had in mind?
But I did not want to make e2e-test script more complex and maybe it will be an overkill |
…hes don't work in travis anyway
|
@bestander updated the pull request. |
| @@ -2,11 +2,6 @@ language: objective-c | |||
|
|
|||
| osx_image: xcode7.2 | |||
|
|
|||
| cache: | |||
There was a problem hiding this comment.
I tested this setting does not do anything, .nvm is empty on every build and npm install is done fresh.
Not too bad, npm is stable recentlly and takes just 3 minutes
|
👍 |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to make sure we can use both versions of npm client for publishing and installing
Test plan (required)
Make sure tests pass on both Travis and Circle CI.