Skip to content

Commit 012c527

Browse files
committed
[Fizz] Support aborting with Postpone (#28183)
Semantically if you make your reason for aborting a Postpone instance the render should not hit the error pathways but should instead follow the postpone pathways. It's awkward today to actually get your hands on a Postpone instance because you have to catch the throw from postpone and then pass that into `abort()` or `AbortController.abort()` (depending on the renderer API you are using) This change makes it so that in most circumstances if you abort with a postpone the `onPostpone` handler will be called and the Suspense boundaries still pending will be put into client render mode with the appropriate postpone digest to avoid trigger recoverable error pathways on the client. Similar to postponing in the shell during a resume or render however if you abort before the shell is complete in a resume or render we will fatally error. The fatal error is contextualized by React to avoid passing the postpone object itself to the `onError` and related options. DiffTrain build for commit 1219d57.
1 parent bedf028 commit 012c527

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25623,7 +25623,7 @@ if (__DEV__) {
2562325623
return root;
2562425624
}
2562525625

25626-
var ReactVersion = "18.3.0-canary-d29f7d973-20240131";
25626+
var ReactVersion = "18.3.0-canary-1219d57fc-20240201";
2562725627

2562825628
// Might add PROFILE later.
2562925629

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9149,7 +9149,7 @@ var devToolsConfig$jscomp$inline_1031 = {
91499149
throw Error("TestRenderer does not support findFiberByHostInstance()");
91509150
},
91519151
bundleType: 0,
9152-
version: "18.3.0-canary-d29f7d973-20240131",
9152+
version: "18.3.0-canary-1219d57fc-20240201",
91539153
rendererPackageName: "react-test-renderer"
91549154
};
91559155
var internals$jscomp$inline_1207 = {
@@ -9180,7 +9180,7 @@ var internals$jscomp$inline_1207 = {
91809180
scheduleRoot: null,
91819181
setRefreshHandler: null,
91829182
getCurrentFiber: null,
9183-
reconcilerVersion: "18.3.0-canary-d29f7d973-20240131"
9183+
reconcilerVersion: "18.3.0-canary-1219d57fc-20240201"
91849184
};
91859185
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91869186
var hook$jscomp$inline_1208 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9577,7 +9577,7 @@ var devToolsConfig$jscomp$inline_1073 = {
95779577
throw Error("TestRenderer does not support findFiberByHostInstance()");
95789578
},
95799579
bundleType: 0,
9580-
version: "18.3.0-canary-d29f7d973-20240131",
9580+
version: "18.3.0-canary-1219d57fc-20240201",
95819581
rendererPackageName: "react-test-renderer"
95829582
};
95839583
var internals$jscomp$inline_1248 = {
@@ -9608,7 +9608,7 @@ var internals$jscomp$inline_1248 = {
96089608
scheduleRoot: null,
96099609
setRefreshHandler: null,
96109610
getCurrentFiber: null,
9611-
reconcilerVersion: "18.3.0-canary-d29f7d973-20240131"
9611+
reconcilerVersion: "18.3.0-canary-1219d57fc-20240201"
96129612
};
96139613
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96149614
var hook$jscomp$inline_1249 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-canary-d29f7d973-20240131";
27+
var ReactVersion = "18.3.0-canary-1219d57fc-20240201";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,4 +545,4 @@ exports.useSyncExternalStore = function (
545545
exports.useTransition = function () {
546546
return ReactCurrentDispatcher.current.useTransition();
547547
};
548-
exports.version = "18.3.0-canary-d29f7d973-20240131";
548+
exports.version = "18.3.0-canary-1219d57fc-20240201";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ exports.useSyncExternalStore = function (
541541
exports.useTransition = function () {
542542
return ReactCurrentDispatcher.current.useTransition();
543543
};
544-
exports.version = "18.3.0-canary-d29f7d973-20240131";
544+
exports.version = "18.3.0-canary-1219d57fc-20240201";
545545
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
546546
"function" ===
547547
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
d29f7d973da616a02d6240ea10306a6f33e35ca1
1+
1219d57fc9fcbf44c873c0b10e5acbd31f613c15

0 commit comments

Comments
 (0)