Skip to content

Commit 029d735

Browse files
committed
Add ReactDOMClient to ServerIntegrationSelect (#28132)
## Overview Branched off #28130 ## React for count changing ### Before These tests are weird because on main they pass, but log to the console: ``` We expected 2 warning(s), but saw 1 warning(s). We saw these warnings: Warning: Expected server HTML to contain a matching <select> in <div>. at select ``` The other one is ignored. The `expect(console.errors).toBeCalledWith(2)` doesn't account for ignored calls, so the test passes with the two expected (the +1 is in the test utiles). The ignored warning is ``` Warning: ReactDOM.hydrate is no longer supported in React 18. Use hydrateRoot instead. ``` So the mismatch is in the ignored warnings. ### After After switching to `createRoot`, it still logs: ``` We expected 2 warning(s), but saw 1 warning(s). We saw these warnings: Warning: Expected server HTML to contain a matching <select> in <div>. at select ``` But the test fails due to an unexpected error count. The new ignored errors are: ``` Error: Uncaught [Error: Hydration failed because the initial UI does not match what was rendered on the server.] Warning: An error occurred during hydration. The server HTML was replaced with client content in <div>. Error: Hydration failed because the initial UI does not match what was rendered on the server. Error: There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering. ``` These seem to be the correct warnings to fire in `createRoot`, so the fix is to update the number of warnings we expect. DiffTrain build for commit c42e7c7.
1 parent 06365e8 commit 029d735

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25622,7 +25622,7 @@ if (__DEV__) {
2562225622
return root;
2562325623
}
2562425624

25625-
var ReactVersion = "18.3.0-canary-6054be9c8-20240201";
25625+
var ReactVersion = "18.3.0-canary-c42e7c7ad-20240201";
2562625626

2562725627
// Might add PROFILE later.
2562825628

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9149,7 +9149,7 @@ var devToolsConfig$jscomp$inline_1031 = {
91499149
throw Error("TestRenderer does not support findFiberByHostInstance()");
91509150
},
91519151
bundleType: 0,
9152-
version: "18.3.0-canary-6054be9c8-20240201",
9152+
version: "18.3.0-canary-c42e7c7ad-20240201",
91539153
rendererPackageName: "react-test-renderer"
91549154
};
91559155
var internals$jscomp$inline_1207 = {
@@ -9180,7 +9180,7 @@ var internals$jscomp$inline_1207 = {
91809180
scheduleRoot: null,
91819181
setRefreshHandler: null,
91829182
getCurrentFiber: null,
9183-
reconcilerVersion: "18.3.0-canary-6054be9c8-20240201"
9183+
reconcilerVersion: "18.3.0-canary-c42e7c7ad-20240201"
91849184
};
91859185
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
91869186
var hook$jscomp$inline_1208 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9577,7 +9577,7 @@ var devToolsConfig$jscomp$inline_1073 = {
95779577
throw Error("TestRenderer does not support findFiberByHostInstance()");
95789578
},
95799579
bundleType: 0,
9580-
version: "18.3.0-canary-6054be9c8-20240201",
9580+
version: "18.3.0-canary-c42e7c7ad-20240201",
95819581
rendererPackageName: "react-test-renderer"
95829582
};
95839583
var internals$jscomp$inline_1248 = {
@@ -9608,7 +9608,7 @@ var internals$jscomp$inline_1248 = {
96089608
scheduleRoot: null,
96099609
setRefreshHandler: null,
96109610
getCurrentFiber: null,
9611-
reconcilerVersion: "18.3.0-canary-6054be9c8-20240201"
9611+
reconcilerVersion: "18.3.0-canary-c42e7c7ad-20240201"
96129612
};
96139613
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
96149614
var hook$jscomp$inline_1249 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-canary-6054be9c8-20240201";
27+
var ReactVersion = "18.3.0-canary-c42e7c7ad-20240201";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,4 +545,4 @@ exports.useSyncExternalStore = function (
545545
exports.useTransition = function () {
546546
return ReactCurrentDispatcher.current.useTransition();
547547
};
548-
exports.version = "18.3.0-canary-6054be9c8-20240201";
548+
exports.version = "18.3.0-canary-c42e7c7ad-20240201";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ exports.useSyncExternalStore = function (
541541
exports.useTransition = function () {
542542
return ReactCurrentDispatcher.current.useTransition();
543543
};
544-
exports.version = "18.3.0-canary-6054be9c8-20240201";
544+
exports.version = "18.3.0-canary-c42e7c7ad-20240201";
545545
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
546546
"function" ===
547547
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
6054be9c86f2e01e5e24c1fe2182479fec8667e4
1+
c42e7c7adc3a036c0c176d5b3dd7cf9215862815

0 commit comments

Comments
 (0)