[compiler] Fix false positive memo validation (alternative) (#34319)

Alternative to #34276

---
(Summary taken from @josephsavona 's #34276)
Partial fix for #34262. Consider this example:

```js
function useInputValue(input) {
  const object = React.useMemo(() => {
    const {value} = transform(input);
    return {value};
  }, [input]);
  return object;
}
```

React Compiler breaks this code into two reactive scopes:
* One for `transform(input)`
* One for `{value}`

When we run ValidatePreserveExistingMemo, we see that the scope for
`{value}` has the dependency `value`, whereas the original memoization
had the dependency `input`, and throw an error that the dependencies
didn't match.

In other words, we're flagging the fact that memoized _better than the
user_ as a problem. The more complete solution would be to validate that
there is a subgraph of reactive scopes with a single input and output
node, where the input node has the same dependencies as the original
useMemo, and the output has the same outputs. That is true in this case,
with the subgraph being the two consecutive scopes mentioned above.

But that's complicated. As a shortcut, this PR checks for any
dependencies that are defined after the start of the original useMemo.
If we find one, we know that it's a case where we were able to memoize
more precisely than the original, and we don't report an error on the
dependency. We still check that the original _output_ value is able to
be memoized, though. So if the scope of `object` were extended, eg with
a call to `mutate(object)`, then we'd still correctly report an error
that we couldn't preserve memoization.

Co-authored-by: Joe Savona <[email protected]>

DiffTrain build for [eda778b](eda778b)

Author: mofeiZ

compiled/eslint-plugin-react-hooks/index.js

@@ -49869,41 +49869,43 @@ class Visitor extends ReactiveFunctionVisitor {
                 for (const instr of value.instructions) {
                     this.visitInstruction(instr, state);
                 }
-                const result = this.recordDepsInValue(value.value, state);
-                return result;
+                this.recordDepsInValue(value.value, state);
+                break;
             }
             case 'OptionalExpression': {
-                return this.recordDepsInValue(value.value, state);
+                this.recordDepsInValue(value.value, state);
+                break;
             }
             case 'ConditionalExpression': {
                 this.recordDepsInValue(value.test, state);
                 this.recordDepsInValue(value.consequent, state);
                 this.recordDepsInValue(value.alternate, state);
-                return null;
+                break;
             }
             case 'LogicalExpression': {
                 this.recordDepsInValue(value.left, state);
                 this.recordDepsInValue(value.right, state);
-                return null;
+                break;
             }
             default: {
-                const dep = collectMaybeMemoDependencies(value, this.temporaries, false);
-                if (value.kind === 'StoreLocal' || value.kind === 'StoreContext') {
-                    const storeTarget = value.lvalue.place;
-                    (_a = state.manualMemoState) === null || _a === void 0 ? void 0 : _a.decls.add(storeTarget.identifier.declarationId);
-                    if (((_b = storeTarget.identifier.name) === null || _b === void 0 ? void 0 : _b.kind) === 'named' && dep == null) {
-                        const dep = {
-                            root: {
-                                kind: 'NamedLocal',
-                                value: storeTarget,
-                            },
-                            path: [],
-                        };
-                        this.temporaries.set(storeTarget.identifier.id, dep);
-                        return dep;
+                collectMaybeMemoDependencies(value, this.temporaries, false);
+                if (value.kind === 'StoreLocal' ||
+                    value.kind === 'StoreContext' ||
+                    value.kind === 'Destructure') {
+                    for (const storeTarget of eachInstructionValueLValue(value)) {
+                        (_a = state.manualMemoState) === null || _a === void 0 ? void 0 : _a.decls.add(storeTarget.identifier.declarationId);
+                        if (((_b = storeTarget.identifier.name) === null || _b === void 0 ? void 0 : _b.kind) === 'named') {
+                            this.temporaries.set(storeTarget.identifier.id, {
+                                root: {
+                                    kind: 'NamedLocal',
+                                    value: storeTarget,
+                                },
+                                path: [],
+                            });
+                        }
                     }
                 }
-                return dep;
+                break;
             }
         }
     }
@@ -49919,20 +49921,15 @@ class Visitor extends ReactiveFunctionVisitor {
         if (lvalue !== null && isNamedLocal && state.manualMemoState != null) {
             state.manualMemoState.decls.add(lvalue.identifier.declarationId);
         }
-        const maybeDep = this.recordDepsInValue(value, state);
-        if (lvalId != null) {
-            if (maybeDep != null) {
-                temporaries.set(lvalId, maybeDep);
-            }
-            else if (isNamedLocal) {
-                temporaries.set(lvalId, {
-                    root: {
-                        kind: 'NamedLocal',
-                        value: Object.assign({}, instr.lvalue),
-                    },
-                    path: [],
-                });
-            }
+        this.recordDepsInValue(value, state);
+        if (lvalue != null) {
+            temporaries.set(lvalue.identifier.id, {
+                root: {
+                    kind: 'NamedLocal',
+                    value: Object.assign({}, lvalue),
+                },
+                path: [],
+            });
         }
     }
     visitScope(scopeBlock, state) {

compiled/facebook-www/REVISION

@@ -1 +1 @@
-a9410fb487776339ec68e57a57a570be952ccad0
+eda778b8ae1698fec5fc84ca2530727df8b557b5

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-a9410fb487776339ec68e57a57a570be952ccad0
+eda778b8ae1698fec5fc84ca2530727df8b557b5

compiled/facebook-www/React-dev.classic.js

@@ -1418,7 +1418,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-classic-a9410fb4-20250909";
+    exports.version = "19.2.0-www-classic-eda778b8-20250909";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1418,7 +1418,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-modern-a9410fb4-20250909";
+    exports.version = "19.2.0-www-modern-eda778b8-20250909";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -600,4 +600,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-a9410fb4-20250909";
+exports.version = "19.2.0-www-classic-eda778b8-20250909";

compiled/facebook-www/React-prod.modern.js

@@ -600,4 +600,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-a9410fb4-20250909";
+exports.version = "19.2.0-www-modern-eda778b8-20250909";

compiled/facebook-www/React-profiling.classic.js

@@ -604,7 +604,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-a9410fb4-20250909";
+exports.version = "19.2.0-www-classic-eda778b8-20250909";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -604,7 +604,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-a9410fb4-20250909";
+exports.version = "19.2.0-www-modern-eda778b8-20250909";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -19708,10 +19708,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.2.0-www-classic-a9410fb4-20250909",
+        version: "19.2.0-www-classic-eda778b8-20250909",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.2.0-www-classic-a9410fb4-20250909"
+        reconcilerVersion: "19.2.0-www-classic-eda778b8-20250909"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19745,7 +19745,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.2.0-www-classic-a9410fb4-20250909";
+    exports.version = "19.2.0-www-classic-eda778b8-20250909";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&