Skip to content

Commit 16619f1

Browse files
authored
Reduce install network flake (#27464)
## Summary Avoids potentially flaky network calls leading to failures such as https://app.circleci.com/pipelines/github/facebook/react/47096/workflows/b7966c1d-199c-4185-8d17-ac6485235c3a/jobs/727782. Also makes install faster since we don't need the binary in CI seemingly. Electron itself is used to start the standalone binary. ## How did you test this change? - [x] CI still passes without the binary downloaded. I'm just trusting [their docs](https://www.electronjs.org/docs/latest/tutorial/installation) here that setting this actually ensures the binary isn't downloaded.
1 parent 0fba3ec commit 16619f1

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.circleci/config.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ commands:
5353
if [ $? -ne 0 ]; then
5454
yarn install --frozen-lockfile --cache-folder ~/.cache/yarn
5555
fi
56+
environment:
57+
# If we start needing the Electron binary, please ensure the binary is cached in CI following https://www.electronjs.org/docs/latest/tutorial/installation
58+
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
5659
- save_cache:
5760
name: Save yarn cache
5861
key: v2-yarn_cache-{{ arch }}-{{ checksum "yarn.lock" }}

0 commit comments

Comments
 (0)