Skip to content

Commit 186e383

Browse files
sebmarkbagesebmarkbage
committed
Split out Edge and Node implementations of the Flight Client (#26187)
This splits out the Edge and Node implementations of Flight Client into their own implementations. The Node implementation now takes a Node Stream as input. I removed the bundler config from the Browser variant because you're never supposed to use that in the browser since it's only for SSR. Similarly, it's required on the server. This also enables generating a SSR manifest from the Webpack plugin. This is necessary for SSR so that you can reverse look up what a client module is called on the server. I also removed the option to pass a callServer from the server. We might want to add it back in the future but basically, we don't recommend calling Server Functions from render for initial render because if that happened client-side it would be a client-side waterfall. If it's never called in initial render, then it also shouldn't ever happen during SSR. This might be considered too restrictive. ~This also compiles the unbundled packages as ESM. This isn't strictly necessary because we only need access to dynamic import to load the modules but we don't have any other build options that leave `import(...)` intact, and seems appropriate that this would also be an ESM module.~ Went with `import(...)` in CJS instead. DiffTrain build for commit 60144a0.
1 parent 1041fb1 commit 186e383

28 files changed

+42
-42
lines changed

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
70b0bbda767ed016925889e8952b10f49921c0cf
1+
60144a04da7970e30266f591dbcd67afe1097e41

‎compiled/facebook-www/REVISION_TRANSFORMS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
70b0bbda767ed016925889e8952b10f49921c0cf
1+
60144a04da7970e30266f591dbcd67afe1097e41

‎compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
30+
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
30+
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
646646
);
647647
};
648648
exports.useTransition = useTransition;
649-
exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
649+
exports.version = "18.3.0-www-classic-60144a04d-20230221";

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
638638
);
639639
};
640640
exports.useTransition = useTransition;
641-
exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
641+
exports.version = "18.3.0-www-modern-60144a04d-20230221";

‎compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
657657
);
658658
};
659659
exports.useTransition = useTransition;
660-
exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
660+
exports.version = "18.3.0-www-classic-60144a04d-20230221";
661661

662662
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
663663
if (

‎compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
649649
);
650650
};
651651
exports.useTransition = useTransition;
652-
exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
652+
exports.version = "18.3.0-www-modern-60144a04d-20230221";
653653

654654
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
655655
if (

‎compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
72+
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;

‎compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
72+
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;

‎compiled/facebook-www/ReactART-prod.classic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9800,7 +9800,7 @@ var slice = Array.prototype.slice,
98009800
return null;
98019801
},
98029802
bundleType: 0,
9803-
version: "18.3.0-www-classic-70b0bbda7-20230221",
9803+
version: "18.3.0-www-classic-60144a04d-20230221",
98049804
rendererPackageName: "react-art"
98059805
};
98069806
var internals$jscomp$inline_1301 = {
@@ -9831,7 +9831,7 @@ var internals$jscomp$inline_1301 = {
98319831
scheduleRoot: null,
98329832
setRefreshHandler: null,
98339833
getCurrentFiber: null,
9834-
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
9834+
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
98359835
};
98369836
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
98379837
var hook$jscomp$inline_1302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactART-prod.modern.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9465,7 +9465,7 @@ var slice = Array.prototype.slice,
94659465
return null;
94669466
},
94679467
bundleType: 0,
9468-
version: "18.3.0-www-modern-70b0bbda7-20230221",
9468+
version: "18.3.0-www-modern-60144a04d-20230221",
94699469
rendererPackageName: "react-art"
94709470
};
94719471
var internals$jscomp$inline_1281 = {
@@ -9496,7 +9496,7 @@ var internals$jscomp$inline_1281 = {
94969496
scheduleRoot: null,
94979497
setRefreshHandler: null,
94989498
getCurrentFiber: null,
9499-
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
9499+
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
95009500
};
95019501
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
95029502
var hook$jscomp$inline_1282 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41996,7 +41996,7 @@ function createFiberRoot(
4199641996
return root;
4199741997
}
4199841998

41999-
var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
41999+
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
4200042000

4200142001
function createPortal$1(
4200242002
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41600,7 +41600,7 @@ function createFiberRoot(
4160041600
return root;
4160141601
}
4160241602

41603-
var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
41603+
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
4160441604

4160541605
function createPortal$1(
4160641606
children,

‎compiled/facebook-www/ReactDOM-prod.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15469,7 +15469,7 @@ Internals.Events = [
1546915469
var devToolsConfig$jscomp$inline_1742 = {
1547015470
findFiberByHostInstance: getClosestInstanceFromNode,
1547115471
bundleType: 0,
15472-
version: "18.3.0-www-classic-70b0bbda7-20230221",
15472+
version: "18.3.0-www-classic-60144a04d-20230221",
1547315473
rendererPackageName: "react-dom"
1547415474
};
1547515475
var internals$jscomp$inline_2109 = {
@@ -15499,7 +15499,7 @@ var internals$jscomp$inline_2109 = {
1549915499
scheduleRoot: null,
1550015500
setRefreshHandler: null,
1550115501
getCurrentFiber: null,
15502-
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
15502+
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
1550315503
};
1550415504
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1550515505
var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15747,4 +15747,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
1574715747
);
1574815748
};
1574915749
exports.unstable_runWithPriority = runWithPriority;
15750-
exports.version = "18.3.0-next-70b0bbda7-20230221";
15750+
exports.version = "18.3.0-next-60144a04d-20230221";

‎compiled/facebook-www/ReactDOM-prod.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14998,7 +14998,7 @@ Internals.Events = [
1499814998
var devToolsConfig$jscomp$inline_1701 = {
1499914999
findFiberByHostInstance: getClosestInstanceFromNode,
1500015000
bundleType: 0,
15001-
version: "18.3.0-www-modern-70b0bbda7-20230221",
15001+
version: "18.3.0-www-modern-60144a04d-20230221",
1500215002
rendererPackageName: "react-dom"
1500315003
};
1500415004
var internals$jscomp$inline_2073 = {
@@ -15029,7 +15029,7 @@ var internals$jscomp$inline_2073 = {
1502915029
scheduleRoot: null,
1503015030
setRefreshHandler: null,
1503115031
getCurrentFiber: null,
15032-
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
15032+
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
1503315033
};
1503415034
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1503515035
var hook$jscomp$inline_2074 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15213,4 +15213,4 @@ exports.unstable_flushControlled = function (fn) {
1521315213
}
1521415214
};
1521515215
exports.unstable_runWithPriority = runWithPriority;
15216-
exports.version = "18.3.0-next-70b0bbda7-20230221";
15216+
exports.version = "18.3.0-next-60144a04d-20230221";

‎compiled/facebook-www/ReactDOM-profiling.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16239,7 +16239,7 @@ Internals.Events = [
1623916239
var devToolsConfig$jscomp$inline_1822 = {
1624016240
findFiberByHostInstance: getClosestInstanceFromNode,
1624116241
bundleType: 0,
16242-
version: "18.3.0-www-classic-70b0bbda7-20230221",
16242+
version: "18.3.0-www-classic-60144a04d-20230221",
1624316243
rendererPackageName: "react-dom"
1624416244
};
1624516245
(function (internals) {
@@ -16283,7 +16283,7 @@ var devToolsConfig$jscomp$inline_1822 = {
1628316283
scheduleRoot: null,
1628416284
setRefreshHandler: null,
1628516285
getCurrentFiber: null,
16286-
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
16286+
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
1628716287
});
1628816288
assign(Internals, {
1628916289
ReactBrowserEventEmitter: {
@@ -16518,7 +16518,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
1651816518
);
1651916519
};
1652016520
exports.unstable_runWithPriority = runWithPriority;
16521-
exports.version = "18.3.0-next-70b0bbda7-20230221";
16521+
exports.version = "18.3.0-next-60144a04d-20230221";
1652216522

1652316523
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
1652416524
if (

‎compiled/facebook-www/ReactDOM-profiling.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15758,7 +15758,7 @@ Internals.Events = [
1575815758
var devToolsConfig$jscomp$inline_1781 = {
1575915759
findFiberByHostInstance: getClosestInstanceFromNode,
1576015760
bundleType: 0,
15761-
version: "18.3.0-www-modern-70b0bbda7-20230221",
15761+
version: "18.3.0-www-modern-60144a04d-20230221",
1576215762
rendererPackageName: "react-dom"
1576315763
};
1576415764
(function (internals) {
@@ -15803,7 +15803,7 @@ var devToolsConfig$jscomp$inline_1781 = {
1580315803
scheduleRoot: null,
1580415804
setRefreshHandler: null,
1580515805
getCurrentFiber: null,
15806-
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
15806+
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
1580715807
});
1580815808
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
1580915809
exports.createPortal = function (children, container) {
@@ -15974,7 +15974,7 @@ exports.unstable_flushControlled = function (fn) {
1597415974
}
1597515975
};
1597615976
exports.unstable_runWithPriority = runWithPriority;
15977-
exports.version = "18.3.0-next-70b0bbda7-20230221";
15977+
exports.version = "18.3.0-next-60144a04d-20230221";
1597815978

1597915979
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
1598015980
if (

‎compiled/facebook-www/ReactDOMServer-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (__DEV__) {
1919
var React = require("react");
2020
var ReactDOM = require("react-dom");
2121

22-
var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
22+
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
2323

2424
// This refers to a WWW module.
2525
var warningWWW = require("warning");

‎compiled/facebook-www/ReactDOMServer-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (__DEV__) {
1919
var React = require("react");
2020
var ReactDOM = require("react-dom");
2121

22-
var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
22+
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
2323

2424
// This refers to a WWW module.
2525
var warningWWW = require("warning");

‎compiled/facebook-www/ReactDOMServer-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3670,4 +3670,4 @@ exports.renderToString = function (children, options) {
36703670
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
36713671
);
36723672
};
3673-
exports.version = "18.3.0-www-classic-70b0bbda7-20230221";
3673+
exports.version = "18.3.0-www-classic-60144a04d-20230221";

‎compiled/facebook-www/ReactDOMServer-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3568,4 +3568,4 @@ exports.renderToString = function (children, options) {
35683568
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
35693569
);
35703570
};
3571-
exports.version = "18.3.0-www-modern-70b0bbda7-20230221";
3571+
exports.version = "18.3.0-www-modern-60144a04d-20230221";

‎compiled/facebook-www/ReactDOMTesting-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31233,7 +31233,7 @@ function createFiberRoot(
3123331233
return root;
3123431234
}
3123531235

31236-
var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
31236+
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
3123731237

3123831238
function createPortal$1(
3123931239
children,

‎compiled/facebook-www/ReactDOMTesting-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37624,7 +37624,7 @@ function createFiberRoot(
3762437624
return root;
3762537625
}
3762637626

37627-
var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
37627+
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
3762837628

3762937629
function createPortal$1(
3763037630
children,

‎compiled/facebook-www/ReactDOMTesting-prod.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11541,7 +11541,7 @@ Internals.Events = [
1154111541
var devToolsConfig$jscomp$inline_1536 = {
1154211542
findFiberByHostInstance: getClosestInstanceFromNode,
1154311543
bundleType: 0,
11544-
version: "18.3.0-www-classic-70b0bbda7-20230221",
11544+
version: "18.3.0-www-classic-60144a04d-20230221",
1154511545
rendererPackageName: "react-dom"
1154611546
};
1154711547
var internals$jscomp$inline_2059 = {
@@ -11571,7 +11571,7 @@ var internals$jscomp$inline_2059 = {
1157111571
scheduleRoot: null,
1157211572
setRefreshHandler: null,
1157311573
getCurrentFiber: null,
11574-
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
11574+
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
1157511575
};
1157611576
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1157711577
var hook$jscomp$inline_2060 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14749,4 +14749,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
1474914749
);
1475014750
};
1475114751
exports.unstable_runWithPriority = runWithPriority;
14752-
exports.version = "18.3.0-next-70b0bbda7-20230221";
14752+
exports.version = "18.3.0-next-60144a04d-20230221";

‎compiled/facebook-www/ReactDOMTesting-prod.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13856,7 +13856,7 @@ Internals.Events = [
1385613856
var devToolsConfig$jscomp$inline_1653 = {
1385713857
findFiberByHostInstance: getClosestInstanceFromNode,
1385813858
bundleType: 0,
13859-
version: "18.3.0-www-modern-70b0bbda7-20230221",
13859+
version: "18.3.0-www-modern-60144a04d-20230221",
1386013860
rendererPackageName: "react-dom"
1386113861
};
1386213862
var internals$jscomp$inline_2033 = {
@@ -13887,7 +13887,7 @@ var internals$jscomp$inline_2033 = {
1388713887
scheduleRoot: null,
1388813888
setRefreshHandler: null,
1388913889
getCurrentFiber: null,
13890-
reconcilerVersion: "18.3.0-next-70b0bbda7-20230221"
13890+
reconcilerVersion: "18.3.0-next-60144a04d-20230221"
1389113891
};
1389213892
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1389313893
var hook$jscomp$inline_2034 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14214,4 +14214,4 @@ exports.unstable_flushControlled = function (fn) {
1421414214
}
1421514215
};
1421614216
exports.unstable_runWithPriority = runWithPriority;
14217-
exports.version = "18.3.0-next-70b0bbda7-20230221";
14217+
exports.version = "18.3.0-next-60144a04d-20230221";

‎compiled/facebook-www/ReactTestRenderer-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23749,7 +23749,7 @@ function createFiberRoot(
2374923749
return root;
2375023750
}
2375123751

23752-
var ReactVersion = "18.3.0-www-classic-70b0bbda7-20230221";
23752+
var ReactVersion = "18.3.0-www-classic-60144a04d-20230221";
2375323753

2375423754
// Might add PROFILE later.
2375523755

‎compiled/facebook-www/ReactTestRenderer-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23749,7 +23749,7 @@ function createFiberRoot(
2374923749
return root;
2375023750
}
2375123751

23752-
var ReactVersion = "18.3.0-www-modern-70b0bbda7-20230221";
23752+
var ReactVersion = "18.3.0-www-modern-60144a04d-20230221";
2375323753

2375423754
// Might add PROFILE later.
2375523755

0 commit comments

Comments
 (0)