Skip to content

Commit 1b4f905

Browse files
author
Sebastian Silbermann
committed
Convert describeComponentFrame to createRoot
1 parent feed8f3 commit 1b4f905

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

packages/shared/__tests__/describeComponentFrame-test.js

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,18 @@
1010
'use strict';
1111

1212
let React;
13-
let ReactDOM;
13+
let ReactDOMClient;
14+
let act;
1415

1516
describe('Component stack trace displaying', () => {
1617
beforeEach(() => {
1718
React = require('react');
18-
ReactDOM = require('react-dom');
19+
ReactDOMClient = require('react-dom');
20+
act = require('internal-test-utils').act;
1921
});
2022

2123
// @gate !enableComponentStackLocations || !__DEV__
22-
it('should provide filenames in stack traces', () => {
24+
it('should provide filenames in stack traces', async () => {
2325
class Component extends React.Component {
2426
render() {
2527
return [<span>a</span>, <span>b</span>];
@@ -88,15 +90,21 @@ describe('Component stack trace displaying', () => {
8890
'C:\\funny long (path)/index.js': 'funny long (path)/index.js',
8991
'C:\\funny long (path)/index.jsx': 'funny long (path)/index.jsx',
9092
};
91-
Object.keys(fileNames).forEach((fileName, i) => {
93+
94+
const root = ReactDOMClient.createRoot(container);
95+
96+
let i = 0;
97+
for (const fileName in fileNames) {
9298
Component.displayName = 'Component ' + i;
93-
ReactDOM.render(
94-
<Component __source={{fileName, lineNumber: i}} />,
95-
container,
96-
);
97-
});
99+
100+
await act(() => {
101+
root.render(<Component __source={{fileName, lineNumber: i}} />);
102+
});
103+
104+
i++;
105+
}
98106
if (__DEV__) {
99-
let i = 0;
107+
i = 0;
100108
expect(console.error).toHaveBeenCalledTimes(
101109
Object.keys(fileNames).length,
102110
);

0 commit comments

Comments
 (0)