Skip to content

Commit 21aee59

Browse files
authored
Delete unused DOM files (#26387)
These used to be used by partial render. ReactDOMDispatcher ended up not being used in this way. Move shared DOM files to client. These are only used by client abstractions now. They're inlined in the Fizz code so they're no longer shared.
1 parent 56a3c18 commit 21aee59

28 files changed

+25
-145
lines changed

packages/react-dom-bindings/src/client/CSSPropertyOperations.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import {shorthandToLonghand} from './CSSShorthandProperty';
99

10-
import dangerousStyleValue from '../shared/dangerousStyleValue';
10+
import dangerousStyleValue from './dangerousStyleValue';
1111
import hyphenateStyleName from '../shared/hyphenateStyleName';
1212
import warnValidStyle from '../shared/warnValidStyle';
1313

packages/react-dom-bindings/src/client/ReactDOMComponent.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,14 @@ import {
5555
setValueForStyles,
5656
validateShorthandPropertyCollisionInDev,
5757
} from './CSSPropertyOperations';
58-
import {HTML_NAMESPACE, getIntrinsicNamespace} from '../shared/DOMNamespaces';
58+
import {HTML_NAMESPACE, getIntrinsicNamespace} from './DOMNamespaces';
5959
import {
6060
getPropertyInfo,
6161
shouldIgnoreAttribute,
6262
shouldRemoveAttribute,
6363
} from '../shared/DOMProperty';
64-
import assertValidProps from '../shared/assertValidProps';
65-
import {DOCUMENT_NODE} from '../shared/HTMLNodeType';
64+
import assertValidProps from './assertValidProps';
65+
import {DOCUMENT_NODE} from './HTMLNodeType';
6666
import isCustomComponent from '../shared/isCustomComponent';
6767
import possibleStandardNames from '../shared/possibleStandardNames';
6868
import {validateProperties as validateARIAProperties} from '../shared/ReactDOMInvalidARIAHook';

packages/react-dom-bindings/src/client/ReactDOMComponentTree.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import type {ReactScopeInstance} from 'shared/ReactTypes';
1313
import type {
1414
ReactDOMEventHandle,
1515
ReactDOMEventHandleListener,
16-
} from '../shared/ReactDOMTypes';
16+
} from './ReactDOMEventHandleTypes';
1717
import type {
1818
Container,
1919
TextInstance,

packages/react-dom-bindings/src/client/ReactDOMEventHandle.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import type {ReactScopeInstance} from 'shared/ReactTypes';
1212
import type {
1313
ReactDOMEventHandle,
1414
ReactDOMEventHandleListener,
15-
} from '../shared/ReactDOMTypes';
15+
} from './ReactDOMEventHandleTypes';
1616

1717
import {allNativeEvents} from '../events/EventRegistry';
1818
import {
@@ -21,7 +21,7 @@ import {
2121
doesTargetHaveEventHandle,
2222
addEventHandleToTarget,
2323
} from './ReactDOMComponentTree';
24-
import {ELEMENT_NODE} from '../shared/HTMLNodeType';
24+
import {ELEMENT_NODE} from './HTMLNodeType';
2525
import {listenToNativeEventForNonManagedEventTarget} from '../events/DOMPluginEventSystem';
2626

2727
import {

packages/react-dom-bindings/src/client/ReactDOMFloatClient.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ import ReactDOMSharedInternals from 'shared/ReactDOMSharedInternals.js';
1616
const {Dispatcher} = ReactDOMSharedInternals;
1717
import {checkAttributeStringCoercion} from 'shared/CheckStringCoercion';
1818

19-
import {DOCUMENT_NODE} from '../shared/HTMLNodeType';
20-
import {SVG_NAMESPACE} from '../shared/DOMNamespaces';
19+
import {DOCUMENT_NODE} from './HTMLNodeType';
20+
import {SVG_NAMESPACE} from './DOMNamespaces';
2121
import {
2222
validatePreloadArguments,
2323
validatePreinitArguments,

packages/react-dom-bindings/src/client/ReactDOMHostConfig.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,16 @@ import {
6161
getChildNamespace,
6262
SVG_NAMESPACE,
6363
MATH_NAMESPACE,
64-
} from '../shared/DOMNamespaces';
64+
} from './DOMNamespaces';
6565
import {
6666
ELEMENT_NODE,
6767
TEXT_NODE,
6868
COMMENT_NODE,
6969
DOCUMENT_NODE,
7070
DOCUMENT_TYPE_NODE,
7171
DOCUMENT_FRAGMENT_NODE,
72-
} from '../shared/HTMLNodeType';
73-
import dangerousStyleValue from '../shared/dangerousStyleValue';
72+
} from './HTMLNodeType';
73+
import dangerousStyleValue from './dangerousStyleValue';
7474

7575
import {retryIfBlockedOn} from '../events/ReactDOMEventReplaying';
7676

packages/react-dom-bindings/src/client/ReactDOMSelection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77

88
import getNodeForCharacterOffset from './getNodeForCharacterOffset';
9-
import {TEXT_NODE} from '../shared/HTMLNodeType';
9+
import {TEXT_NODE} from './HTMLNodeType';
1010

1111
/**
1212
* @param {DOMElement} outerNode

packages/react-dom-bindings/src/client/ReactInputSelection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import getActiveElement from './getActiveElement';
99

1010
import {getOffsets, setOffsets} from './ReactDOMSelection';
11-
import {ELEMENT_NODE, TEXT_NODE} from '../shared/HTMLNodeType';
11+
import {ELEMENT_NODE, TEXT_NODE} from './HTMLNodeType';
1212

1313
function isTextNode(node) {
1414
return node && node.nodeType === TEXT_NODE;

packages/react-dom-bindings/src/shared/dangerousStyleValue.js renamed to packages/react-dom-bindings/src/client/dangerousStyleValue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
import {isUnitlessNumber} from './CSSProperty';
8+
import {isUnitlessNumber} from '../shared/CSSProperty';
99
import {checkCSSPropertyStringCoercion} from 'shared/CheckStringCoercion';
1010

1111
/**

packages/react-dom-bindings/src/client/getNodeForCharacterOffset.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @flow
88
*/
99

10-
import {TEXT_NODE} from '../shared/HTMLNodeType';
10+
import {TEXT_NODE} from './HTMLNodeType';
1111

1212
/**
1313
* Given any node return the first leaf node without children.

packages/react-dom-bindings/src/client/setInnerHTML.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @flow
88
*/
99

10-
import {SVG_NAMESPACE} from '../shared/DOMNamespaces';
10+
import {SVG_NAMESPACE} from './DOMNamespaces';
1111
import createMicrosoftUnsafeLocalFunction from './createMicrosoftUnsafeLocalFunction';
1212
import {enableTrustedTypesIntegration} from 'shared/ReactFeatureFlags';
1313

packages/react-dom-bindings/src/client/setTextContent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @flow
88
*/
99

10-
import {TEXT_NODE} from '../shared/HTMLNodeType';
10+
import {TEXT_NODE} from './HTMLNodeType';
1111

1212
/**
1313
* Set the textContent property of a node. For text updates, it's faster

packages/react-dom-bindings/src/events/DOMPluginEventSystem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import {
4343
getEventListenerSet,
4444
getEventHandlerListeners,
4545
} from '../client/ReactDOMComponentTree';
46-
import {COMMENT_NODE, DOCUMENT_NODE} from '../shared/HTMLNodeType';
46+
import {COMMENT_NODE, DOCUMENT_NODE} from '../client/HTMLNodeType';
4747
import {batchedUpdates} from './ReactDOMUpdateBatching';
4848
import getListener from './getListener';
4949
import {passiveBrowserEventsSupported} from './checkPassiveEvents';

packages/react-dom-bindings/src/events/getEventTarget.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
import {TEXT_NODE} from '../shared/HTMLNodeType';
8+
import {TEXT_NODE} from '../client/HTMLNodeType';
99

1010
/**
1111
* Gets the target node from a native browser event by accounting for

packages/react-dom-bindings/src/events/plugins/SelectEventPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {registerTwoPhaseEvent} from '../EventRegistry';
2323
import getActiveElement from '../../client/getActiveElement';
2424
import {getNodeFromInstance} from '../../client/ReactDOMComponentTree';
2525
import {hasSelectionCapabilities} from '../../client/ReactInputSelection';
26-
import {DOCUMENT_NODE} from '../../shared/HTMLNodeType';
26+
import {DOCUMENT_NODE} from '../../client/HTMLNodeType';
2727
import {accumulateTwoPhaseListeners} from '../DOMPluginEventSystem';
2828

2929
const skipSelectionChangeEvent =

packages/react-dom-bindings/src/server/DOMMarkupOperations.js

Lines changed: 0 additions & 82 deletions
This file was deleted.

packages/react-dom-bindings/src/server/quoteAttributeValueForBrowser.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

packages/react-dom-bindings/src/shared/ReactDOMDispatcher.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

packages/react-dom/src/__tests__/ReactMount-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
'use strict';
1111

12-
const {COMMENT_NODE} = require('react-dom-bindings/src/shared/HTMLNodeType');
12+
const {COMMENT_NODE} = require('react-dom-bindings/src/client/HTMLNodeType');
1313

1414
let React;
1515
let ReactDOM;

packages/react-dom/src/client/ReactDOMLegacy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import {
2727
DOCUMENT_NODE,
2828
ELEMENT_NODE,
2929
COMMENT_NODE,
30-
} from 'react-dom-bindings/src/shared/HTMLNodeType';
30+
} from 'react-dom-bindings/src/client/HTMLNodeType';
3131

3232
import {
3333
createContainer,

packages/react-dom/src/client/ReactDOMRoot.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ import {
6666
COMMENT_NODE,
6767
DOCUMENT_NODE,
6868
DOCUMENT_FRAGMENT_NODE,
69-
} from 'react-dom-bindings/src/shared/HTMLNodeType';
69+
} from 'react-dom-bindings/src/client/HTMLNodeType';
7070

7171
import {
7272
createContainer,

packages/react-dom/src/test-utils/ReactTestUtils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
HostText,
2121
} from 'react-reconciler/src/ReactWorkTags';
2222
import {SyntheticEvent} from 'react-dom-bindings/src/events/SyntheticEvent';
23-
import {ELEMENT_NODE} from 'react-dom-bindings/src/shared/HTMLNodeType';
23+
import {ELEMENT_NODE} from 'react-dom-bindings/src/client/HTMLNodeType';
2424
import {
2525
rethrowCaughtError,
2626
invokeGuardedCallbackAndCatchFirstError,

0 commit comments

Comments
 (0)