Skip to content

Commit 22d5942

Browse files
authored
Add two event system cleanup TODOs (#26678)
There is so much old stuff in these files. I am weeping.
1 parent 767f522 commit 22d5942

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/react-dom-bindings/src/events/plugins/SimpleEventPlugin.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ function extractEvents(
7272
// Firefox creates a keypress event for function keys too. This removes
7373
// the unwanted keypress events. Enter is however both printable and
7474
// non-printable. One would expect Tab to be as well (but it isn't).
75+
// TODO: Fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=968056. Can
76+
// probably remove.
7577
if (getEventCharCode(((nativeEvent: any): KeyboardEvent)) === 0) {
7678
return;
7779
}
@@ -95,6 +97,8 @@ function extractEvents(
9597
case 'click':
9698
// Firefox creates a click event on right mouse clicks. This removes the
9799
// unwanted click events.
100+
// TODO: Fixed in https://phabricator.services.mozilla.com/D26793. Can
101+
// probably remove.
98102
if (nativeEvent.button === 2) {
99103
return;
100104
}

0 commit comments

Comments
 (0)