Skip to content

Commit 2cb6843

Browse files
committed
Add alwaysThrottleDisappearingFallbacks Flag
1 parent 7959a1d commit 2cb6843

11 files changed

+13
-2
lines changed

packages/react-reconciler/src/ReactFiberCommitWork.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import type {
4040
} from './ReactFiberTracingMarkerComponent';
4141

4242
import {
43+
alwaysThrottleDisappearingFallbacks,
4344
enableCreateEventHandleAPI,
4445
enableProfilerTimer,
4546
enableProfilerCommitHooks,
@@ -53,7 +54,6 @@ import {
5354
enableUseEffectEventHook,
5455
enableFloat,
5556
enableLegacyHidden,
56-
alwaysThrottleRetries,
5757
disableStringRefs,
5858
} from 'shared/ReactFeatureFlags';
5959
import {
@@ -2896,7 +2896,7 @@ function commitMutationEffectsOnFiber(
28962896
current !== null &&
28972897
(current.memoizedState: SuspenseState | null) !== null;
28982898

2899-
if (alwaysThrottleRetries) {
2899+
if (alwaysThrottleDisappearingFallbacks) {
29002900
if (isShowingFallback !== wasShowingFallback) {
29012901
// A fallback is either appearing or disappearing.
29022902
markCommitTimeOfFallback();

packages/shared/ReactFeatureFlags.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ export const enableUseEffectEventHook = __EXPERIMENTAL__;
113113
// (handled with an MutationObserver) instead of inline-scripts
114114
export const enableFizzExternalRuntime = true;
115115

116+
export const alwaysThrottleDisappearingFallbacks = true;
117+
116118
export const alwaysThrottleRetries = true;
117119

118120
export const passChildrenWhenCloningPersistedNodes = false;

packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import typeof * as DynamicFlagsType from 'ReactNativeInternalFeatureFlags';
2020
// flag here but it won't be set to `true` in any of our test runs. Need to
2121
// update the test configuration.
2222

23+
export const alwaysThrottleDisappearingFallbacks = __VARIANT__;
2324
export const alwaysThrottleRetries = __VARIANT__;
2425
export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__;
2526
export const enableAsyncActions = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import * as dynamicFlags from 'ReactNativeInternalFeatureFlags';
1818
// We destructure each value before re-exporting to avoid a dynamic look-up on
1919
// the exports object every time a flag is read.
2020
export const {
21+
alwaysThrottleDisappearingFallbacks,
2122
alwaysThrottleRetries,
2223
consoleManagedByDevToolsDuringStrictMode,
2324
enableAsyncActions,

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ export const enableInfiniteRenderLoopDetection = false;
8686

8787
export const enableAsyncActions = false;
8888

89+
export const alwaysThrottleDisappearingFallbacks = false;
8990
export const alwaysThrottleRetries = false;
9091

9192
export const passChildrenWhenCloningPersistedNodes = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ export const enableDeferRootSchedulingToMicrotask = true;
7676

7777
export const enableAsyncActions = true;
7878

79+
export const alwaysThrottleDisappearingFallbacks = true;
7980
export const alwaysThrottleRetries = true;
8081

8182
export const passChildrenWhenCloningPersistedNodes = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.native.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export const enableDeferRootSchedulingToMicrotask = false;
7777

7878
export const enableAsyncActions = true;
7979

80+
export const alwaysThrottleDisappearingFallbacks = true;
8081
export const alwaysThrottleRetries = true;
8182

8283
export const passChildrenWhenCloningPersistedNodes = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ export const enableDeferRootSchedulingToMicrotask = true;
7878

7979
export const enableAsyncActions = true;
8080

81+
export const alwaysThrottleDisappearingFallbacks = false;
8182
export const alwaysThrottleRetries = true;
8283

8384
export const passChildrenWhenCloningPersistedNodes = false;

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export const forceConcurrentByDefaultForTesting = __VARIANT__;
2323
export const enableUnifiedSyncLane = __VARIANT__;
2424
export const enableTransitionTracing = __VARIANT__;
2525
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
26+
export const alwaysThrottleDisappearingFallbacks = __VARIANT__;
2627
export const alwaysThrottleRetries = __VARIANT__;
2728
export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;
2829
export const enableUseDeferredValueInitialArg = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export const {
2626
enableRetryLaneExpiration,
2727
enableTransitionTracing,
2828
enableDeferRootSchedulingToMicrotask,
29+
alwaysThrottleDisappearingFallbacks,
2930
alwaysThrottleRetries,
3031
enableDO_NOT_USE_disableStrictPassiveEffect,
3132
disableSchedulerTimeoutInWorkLoop,

0 commit comments

Comments
 (0)