Remove enableComponentStackLocations (#31764)

This has landed everywhere

Author: rickhanlonii

packages/shared/ReactComponentStackFrame.js

@@ -9,8 +9,6 @@
 
 import type {LazyComponent} from 'react/src/ReactLazy';
 
-import {enableComponentStackLocations} from 'shared/ReactFeatureFlags';
-
 import {
   REACT_SUSPENSE_TYPE,
   REACT_SUSPENSE_LIST_TYPE,
@@ -28,30 +26,26 @@ import DefaultPrepareStackTrace from 'shared/DefaultPrepareStackTrace';
 let prefix;
 let suffix;
 export function describeBuiltInComponentFrame(name: string): string {
-  if (enableComponentStackLocations) {
-    if (prefix === undefined) {
-      // Extract the VM specific prefix used by each line.
-      try {
-        throw Error();
-      } catch (x) {
-        const match = x.stack.trim().match(/\n( *(at )?)/);
-        prefix = (match && match[1]) || '';
-        suffix =
-          x.stack.indexOf('\n    at') > -1
-            ? // V8
-              ' (<anonymous>)'
-            : // JSC/Spidermonkey
-              x.stack.indexOf('@') > -1
-              ? '@unknown:0:0'
-              : // Other
-                '';
-      }
+  if (prefix === undefined) {
+    // Extract the VM specific prefix used by each line.
+    try {
+      throw Error();
+    } catch (x) {
+      const match = x.stack.trim().match(/\n( *(at )?)/);
+      prefix = (match && match[1]) || '';
+      suffix =
+        x.stack.indexOf('\n    at') > -1
+          ? // V8
+            ' (<anonymous>)'
+          : // JSC/Spidermonkey
+            x.stack.indexOf('@') > -1
+            ? '@unknown:0:0'
+            : // Other
+              '';
     }
-    // We use the prefix to ensure our stacks line up with native stack frames.
-    return '\n' + prefix + name + suffix;
-  } else {
-    return describeComponentFrame(name);
   }
+  // We use the prefix to ensure our stacks line up with native stack frames.
+  return '\n' + prefix + name + suffix;
 }
 
 export function describeDebugInfoFrame(name: string, env: ?string): string {
@@ -296,28 +290,12 @@ export function describeNativeComponentFrame(
   return syntheticFrame;
 }
 
-function describeComponentFrame(name: null | string) {
-  return '\n    in ' + (name || 'Unknown');
-}
-
 export function describeClassComponentFrame(ctor: Function): string {
-  if (enableComponentStackLocations) {
-    return describeNativeComponentFrame(ctor, true);
-  } else {
-    return describeFunctionComponentFrame(ctor);
-  }
+  return describeNativeComponentFrame(ctor, true);
 }
 
 export function describeFunctionComponentFrame(fn: Function): string {
-  if (enableComponentStackLocations) {
-    return describeNativeComponentFrame(fn, false);
-  } else {
-    if (!fn) {
-      return '';
-    }
-    const name = fn.displayName || fn.name || null;
-    return describeComponentFrame(name);
-  }
+  return describeNativeComponentFrame(fn, false);
 }
 
 function shouldConstruct(Component: Function) {
@@ -334,11 +312,7 @@ export function describeUnknownElementTypeFrameInDEV(type: any): string {
     return '';
   }
   if (typeof type === 'function') {
-    if (enableComponentStackLocations) {
-      return describeNativeComponentFrame(type, shouldConstruct(type));
-    } else {
-      return describeFunctionComponentFrame(type);
-    }
+    return describeNativeComponentFrame(type, shouldConstruct(type));
   }
   if (typeof type === 'string') {
     return describeBuiltInComponentFrame(type);

packages/shared/ReactFeatureFlags.js

@@ -13,7 +13,7 @@
 // Flags that can likely be deleted or landed without consequences
 // -----------------------------------------------------------------------------
 
-export const enableComponentStackLocations = true;
+// None
 
 // -----------------------------------------------------------------------------
 // Killswitch

packages/shared/__tests__/describeComponentFrame-test.js

@@ -45,7 +45,6 @@ export const disableTextareaChildren = false;
 export const enableAsyncDebugInfo = false;
 export const enableAsyncIterableChildren = false;
 export const enableCache = true;
-export const enableComponentStackLocations = true;
 export const enableCPUSuspense = true;
 export const enableCreateEventHandleAPI = false;
 export const enableDebugTracing = false;

packages/shared/forks/ReactFeatureFlags.native-fb.js

@@ -32,7 +32,6 @@ export const disableTextareaChildren = false;
 export const enableAsyncDebugInfo = false;
 export const enableAsyncIterableChildren = false;
 export const enableCache = true;
-export const enableComponentStackLocations = true;
 export const enableCPUSuspense = false;
 export const enableCreateEventHandleAPI = false;
 export const enableDebugTracing = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

@@ -40,7 +40,6 @@ export const enableUseMemoCacheHook = true;
 export const enableNoCloningMemoCache = false;
 export const enableUseEffectEventHook = false;
 export const favorSafetyOverHydrationPerf = true;
-export const enableComponentStackLocations = true;
 export const enableLegacyFBSupport = false;
 export const enableFilterEmptyStringAttributesDOM = true;
 export const enableMoveBefore = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

@@ -24,7 +24,6 @@ export const disableTextareaChildren = false;
 export const enableAsyncDebugInfo = false;
 export const enableAsyncIterableChildren = false;
 export const enableCache = true;
-export const enableComponentStackLocations = true;
 export const enableCPUSuspense = true;
 export const enableCreateEventHandleAPI = false;
 export const enableDebugTracing = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js

@@ -42,7 +42,6 @@ export const enableUseMemoCacheHook = true;
 export const enableNoCloningMemoCache = false;
 export const enableUseEffectEventHook = false;
 export const favorSafetyOverHydrationPerf = true;
-export const enableComponentStackLocations = true;
 export const enableLegacyFBSupport = false;
 export const enableFilterEmptyStringAttributesDOM = true;
 export const enableMoveBefore = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

@@ -99,8 +99,6 @@ export const enableSuspenseCallback = true;
 
 export const enableLegacyHidden = true;
 
-export const enableComponentStackLocations = true;
-
 export const disableTextareaChildren = __EXPERIMENTAL__;
 
 export const enableFizzExternalRuntime = true;