Skip to content

Commit 40f653d

Browse files
authored
Remove WARNINGS file from FB (#27820)
The test was migrated to the generated JS file that allows Jest to track the dependencies, we can now remove this file generation.
1 parent 5bcade5 commit 40f653d

File tree

3 files changed

+7
-17
lines changed

3 files changed

+7
-17
lines changed

.circleci/config.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ jobs:
107107
- run:
108108
command: |
109109
mkdir -p ./build/__test_utils__
110-
node ./scripts/print-warnings/print-warnings.js > build/WARNINGS
111-
node ./scripts/print-warnings/print-warnings.js --js > build/__test_utils__/ReactAllWarnings.js
110+
node ./scripts/print-warnings/print-warnings.js > build/__test_utils__/ReactAllWarnings.js
112111
- persist_to_workspace:
113112
root: .
114113
paths:

.github/workflows/commit_artifacts.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,8 @@ jobs:
123123
mkdir ./compiled
124124
mv build/facebook-www ./compiled
125125
126-
# Move WARNINGS to facebook-www
126+
# Move ReactAllWarnings.js to facebook-www
127127
mkdir ./compiled/facebook-www/__test_utils__
128-
mv build/WARNINGS ./compiled/facebook-www/WARNINGS
129128
mv build/__test_utils__/ReactAllWarnings.js ./compiled/facebook-www/__test_utils__/ReactAllWarnings.js
130129
131130
# Move eslint-plugin-react-hooks into facebook-www

scripts/print-warnings/print-warnings.js

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,10 @@ gs([
7575
'!**/node_modules/**/*.js',
7676
]).pipe(
7777
through.obj(transform, cb => {
78-
if (process.argv[2] === '--js') {
79-
const warningsArray = Array.from(warnings);
80-
warningsArray.sort();
81-
process.stdout.write(
82-
`/**
78+
const warningsArray = Array.from(warnings);
79+
warningsArray.sort();
80+
process.stdout.write(
81+
`/**
8382
* Copyright (c) Meta Platforms, Inc. and affiliates.
8483
*
8584
* This source code is licensed under the MIT license found in the
@@ -92,14 +91,7 @@ gs([
9291
9392
export default ${JSON.stringify(warningsArray, null, 2)};
9493
`
95-
);
96-
} else {
97-
process.stdout.write(
98-
Array.from(warnings, warning => JSON.stringify(warning))
99-
.sort()
100-
.join('\n') + '\n'
101-
);
102-
}
94+
);
10395
cb();
10496
})
10597
);

0 commit comments

Comments
 (0)