You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update tracked value after resetting radio group (#27394)
Fixes#26876, I think. Review each commit separately (all assertions
pass in main already, except the last assertInputTrackingIsClean in
"should control radio buttons").
I'm actually a little confused on two things here:
* All the isCheckedDirty assertions are true. But I don't think we set
.checked unconditionally? So how does this happen?
* #26876 (comment)
claims that
d962f35...1f248bd contains
the faulty change, but it doesn't appear to change the restoration logic
that I've touched here. (One difference outside restoration is that
updateProperties did previously set `.checked` when `nextProp !==
lastProp` whereas the new logic in updateInput is to set it when
`node.checked !== !!checked`.)
But it seems to me like we need this call here anyway, and if it fixes
it then it fixes it? I think technically speaking we probably should do
all the updateInput() calls and then all the updateValueIfChanged()
calls—in particular I think if clicking A changed the checked radio
button from B to C then the code as I have it would be incorrect, but
that also seems unlikely so idk whether to care.
cc @zhengjitf@Luk-z who did some investigation on the original issue
DiffTrain build for commit 3c27178.
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -23998,7 +23998,7 @@ function createFiberRoot(
23998
23998
return root;
23999
23999
}
24000
24000
24001
-
var ReactVersion = "18.3.0-canary-2b3d58268-20230920";
24001
+
var ReactVersion = "18.3.0-canary-3c27178a2-20230920";
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -8620,7 +8620,7 @@ var devToolsConfig$jscomp$inline_1028 = {
8620
8620
throwError("TestRenderer does not support findFiberByHostInstance()");
8621
8621
},
8622
8622
bundleType: 0,
8623
-
version: "18.3.0-canary-2b3d58268-20230920",
8623
+
version: "18.3.0-canary-3c27178a2-20230920",
8624
8624
rendererPackageName: "react-test-renderer"
8625
8625
};
8626
8626
varinternals$jscomp$inline_1227={
@@ -8651,7 +8651,7 @@ var internals$jscomp$inline_1227 = {
Copy file name to clipboardExpand all lines: compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -9046,7 +9046,7 @@ var devToolsConfig$jscomp$inline_1070 = {
9046
9046
throwError("TestRenderer does not support findFiberByHostInstance()");
9047
9047
},
9048
9048
bundleType: 0,
9049
-
version: "18.3.0-canary-2b3d58268-20230920",
9049
+
version: "18.3.0-canary-3c27178a2-20230920",
9050
9050
rendererPackageName: "react-test-renderer"
9051
9051
};
9052
9052
varinternals$jscomp$inline_1268={
@@ -9077,7 +9077,7 @@ var internals$jscomp$inline_1268 = {
0 commit comments