[compiler] Consolidate HIRFunction return information (#33640)

We now have `HIRFunction.returns: Place` as well as `returnType: Type`.
I want to add additional return information, so as a first step i'm
consolidating everything under an object at `HIRFunction.returns:
{place: Place}`. We use the type of this place as the return type. Next
step is to add more properties to this object to represent things like
the return kind.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33640).
* #33643
* #33642
* __->__ #33640
* #33625
* #33624

DiffTrain build for [123ff13](123ff13)

Author: josephsavona

compiled/eslint-plugin-react-hooks/index.js

@@ -27076,6 +27076,9 @@ function printFunction(fn) {
     if (fn.id !== null) {
         definition += fn.id;
     }
+    else {
+        definition += '<<anonymous>>';
+    }
     if (fn.params.length !== 0) {
         definition +=
             '(' +
@@ -27094,10 +27097,8 @@ function printFunction(fn) {
     else {
         definition += '()';
     }
-    if (definition.length !== 0) {
-        output.push(definition);
-    }
-    output.push(`: ${printType(fn.returnType)} @ ${printPlace(fn.returns)}`);
+    definition += `: ${printPlace(fn.returns)}`;
+    output.push(definition);
     output.push(...fn.directives);
     output.push(printHIR(fn.body));
     return output.join('\n');
@@ -30922,7 +30923,6 @@ function lower$1(func, env, bindings = null, capturedRefs = new Map()) {
         params,
         fnType: bindings == null ? env.fnType : 'Other',
         returnTypeAnnotation: null,
-        returnType: makeType(),
         returns: createTemporaryPlace(env, (_b = func.node.loc) !== null && _b !== void 0 ? _b : GeneratedSource),
         body: builder.build(),
         context,
@@ -51683,12 +51683,13 @@ function inferMutationAliasingRanges(fn, { isFunctionExpression }) {
             }
         }
     }
+    const returns = fn.returns.identifier;
     functionEffects.push({
         kind: 'Create',
         into: fn.returns,
-        value: fn.returnType.kind === 'Primitive'
+        value: isPrimitiveType(returns)
             ? ValueKind.Primitive
-            : isJsxType(fn.returnType)
+            : isJsxType(returns.type)
                 ? ValueKind.Frozen
                 : ValueKind.Mutable,
         reason: ValueReason.KnownReturnSignature,
@@ -55272,7 +55273,8 @@ function apply(func, unifier) {
             }
         }
     }
-    func.returnType = unifier.get(func.returnType);
+    const returns = func.returns.identifier;
+    returns.type = unifier.get(returns.type);
 }
 function equation(left, right) {
     return {
@@ -55314,13 +55316,13 @@ function* generate(func) {
         }
     }
     if (returnTypes.length > 1) {
-        yield equation(func.returnType, {
+        yield equation(func.returns.identifier.type, {
             kind: 'Phi',
             operands: returnTypes,
         });
     }
     else if (returnTypes.length === 1) {
-        yield equation(func.returnType, returnTypes[0]);
+        yield equation(func.returns.identifier.type, returnTypes[0]);
     }
 }
 function setName(names, id, name) {
@@ -55531,7 +55533,7 @@ function* generateInstructionTypes(env, names, instr) {
             yield equation(left, {
                 kind: 'Function',
                 shapeId: BuiltInFunctionId,
-                return: value.loweredFunc.func.returnType,
+                return: value.loweredFunc.func.returns.identifier.type,
                 isConstructor: false,
             });
             break;
@@ -57674,7 +57676,6 @@ function emitSelectorFn(env, keys) {
         env,
         params: [obj],
         returnTypeAnnotation: null,
-        returnType: makeType(),
         returns: createTemporaryPlace(env, GeneratedSource),
         context: [],
         effects: null,
@@ -58092,7 +58093,6 @@ function emitOutlinedFn(env, jsx, oldProps, globals) {
         env,
         params: [propsObj],
         returnTypeAnnotation: null,
-        returnType: makeType(),
         returns: createTemporaryPlace(env, GeneratedSource),
         context: [],
         effects: null,

compiled/facebook-www/REVISION

@@ -1 +1 @@
-e130c08b06470b5fc4ec8095310d19e782924427
+123ff13b193cd361a61b99056dd08f2decd7f55d

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-e130c08b06470b5fc4ec8095310d19e782924427
+123ff13b193cd361a61b99056dd08f2decd7f55d

compiled/facebook-www/React-dev.classic.js

@@ -1479,7 +1479,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-classic-e130c08b-20250625";
+    exports.version = "19.2.0-www-classic-123ff13b-20250625";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1479,7 +1479,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.2.0-www-modern-e130c08b-20250625";
+    exports.version = "19.2.0-www-modern-123ff13b-20250625";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-e130c08b-20250625";
+exports.version = "19.2.0-www-classic-123ff13b-20250625";

compiled/facebook-www/React-prod.modern.js

@@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-e130c08b-20250625";
+exports.version = "19.2.0-www-modern-123ff13b-20250625";

compiled/facebook-www/React-profiling.classic.js

@@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-classic-e130c08b-20250625";
+exports.version = "19.2.0-www-classic-123ff13b-20250625";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.2.0-www-modern-e130c08b-20250625";
+exports.version = "19.2.0-www-modern-123ff13b-20250625";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -19073,10 +19073,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.2.0-www-classic-e130c08b-20250625",
+        version: "19.2.0-www-classic-123ff13b-20250625",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.2.0-www-classic-e130c08b-20250625"
+        reconcilerVersion: "19.2.0-www-classic-123ff13b-20250625"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -19110,7 +19110,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.2.0-www-classic-e130c08b-20250625";
+    exports.version = "19.2.0-www-classic-123ff13b-20250625";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&