Skip to content

Commit 66cdfab

Browse files
acdliteacdlite
committed
Gate DevTools test to fix CI (#26742)
This test started failing recently in older versions of React because the Scheduler priority inside a microtask is Normal instead of Immediate. This is expected because microtasks are not Scheduler tasks; it's an implementation detail. I gated the test to only run in v17 because it's a regression test for legacy Suspense behavior, and the implementation details of the snapshot changed in v18. Test plan --------- Using latest: ``` yarn test --build --project devtools --release-channel=experimental profilingcache ``` Using v17 (typically runs in a timed CI workflow): ``` /scripts/circleci/download_devtools_regression_build.js 17.0 --replaceBuild yarn test --build --project devtools --release-channel=experimental --reactVersion 17.0 profilingcache ``` DiffTrain build for commit 86b0e91.
1 parent 1ef6880 commit 66cdfab

File tree

13 files changed

+19
-19
lines changed

13 files changed

+19
-19
lines changed

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23894,7 +23894,7 @@ function createFiberRoot(
2389423894
return root;
2389523895
}
2389623896

23897-
var ReactVersion = "18.3.0-next-b12bea62d-20230428";
23897+
var ReactVersion = "18.3.0-next-86b0e9199-20230429";
2389823898

2389923899
// Might add PROFILE later.
2390023900

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8608,7 +8608,7 @@ var devToolsConfig$jscomp$inline_1024 = {
86088608
throw Error("TestRenderer does not support findFiberByHostInstance()");
86098609
},
86108610
bundleType: 0,
8611-
version: "18.3.0-next-b12bea62d-20230428",
8611+
version: "18.3.0-next-86b0e9199-20230429",
86128612
rendererPackageName: "react-test-renderer"
86138613
};
86148614
var internals$jscomp$inline_1209 = {
@@ -8639,7 +8639,7 @@ var internals$jscomp$inline_1209 = {
86398639
scheduleRoot: null,
86408640
setRefreshHandler: null,
86418641
getCurrentFiber: null,
8642-
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
8642+
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
86438643
};
86448644
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86458645
var hook$jscomp$inline_1210 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9034,7 +9034,7 @@ var devToolsConfig$jscomp$inline_1066 = {
90349034
throw Error("TestRenderer does not support findFiberByHostInstance()");
90359035
},
90369036
bundleType: 0,
9037-
version: "18.3.0-next-b12bea62d-20230428",
9037+
version: "18.3.0-next-86b0e9199-20230429",
90389038
rendererPackageName: "react-test-renderer"
90399039
};
90409040
var internals$jscomp$inline_1250 = {
@@ -9065,7 +9065,7 @@ var internals$jscomp$inline_1250 = {
90659065
scheduleRoot: null,
90669066
setRefreshHandler: null,
90679067
getCurrentFiber: null,
9068-
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
9068+
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
90699069
};
90709070
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90719071
var hook$jscomp$inline_1251 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-next-b12bea62d-20230428";
30+
var ReactVersion = "18.3.0-next-86b0e9199-20230429";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
);
640640
};
641641
exports.useTransition = useTransition;
642-
exports.version = "18.3.0-next-b12bea62d-20230428";
642+
exports.version = "18.3.0-next-86b0e9199-20230429";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-next-b12bea62d-20230428";
645+
exports.version = "18.3.0-next-86b0e9199-20230429";
646646

647647
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
648648
if (

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b12bea62d9cfd9a925f28cb2c93daeda3865a64e
1+
86b0e91998a04b22bb54a95d54f4a7632efa902f

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27204,7 +27204,7 @@ function createFiberRoot(
2720427204
return root;
2720527205
}
2720627206

27207-
var ReactVersion = "18.3.0-next-b12bea62d-20230428";
27207+
var ReactVersion = "18.3.0-next-86b0e9199-20230429";
2720827208

2720927209
function createPortal$1(
2721027210
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9479,7 +9479,7 @@ var roots = new Map(),
94799479
devToolsConfig$jscomp$inline_1048 = {
94809480
findFiberByHostInstance: getInstanceFromNode,
94819481
bundleType: 0,
9482-
version: "18.3.0-next-b12bea62d-20230428",
9482+
version: "18.3.0-next-86b0e9199-20230429",
94839483
rendererPackageName: "react-native-renderer",
94849484
rendererConfig: {
94859485
getInspectorDataForViewTag: function () {
@@ -9521,7 +9521,7 @@ var internals$jscomp$inline_1279 = {
95219521
scheduleRoot: null,
95229522
setRefreshHandler: null,
95239523
getCurrentFiber: null,
9524-
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
9524+
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
95259525
};
95269526
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
95279527
var hook$jscomp$inline_1280 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10188,7 +10188,7 @@ var roots = new Map(),
1018810188
devToolsConfig$jscomp$inline_1126 = {
1018910189
findFiberByHostInstance: getInstanceFromNode,
1019010190
bundleType: 0,
10191-
version: "18.3.0-next-b12bea62d-20230428",
10191+
version: "18.3.0-next-86b0e9199-20230429",
1019210192
rendererPackageName: "react-native-renderer",
1019310193
rendererConfig: {
1019410194
getInspectorDataForViewTag: function () {
@@ -10243,7 +10243,7 @@ var roots = new Map(),
1024310243
scheduleRoot: null,
1024410244
setRefreshHandler: null,
1024510245
getCurrentFiber: null,
10246-
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
10246+
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
1024710247
});
1024810248
exports.createPortal = function (children, containerTag) {
1024910249
return createPortal$1(

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27717,7 +27717,7 @@ function createFiberRoot(
2771727717
return root;
2771827718
}
2771927719

27720-
var ReactVersion = "18.3.0-next-b12bea62d-20230428";
27720+
var ReactVersion = "18.3.0-next-86b0e9199-20230429";
2772127721

2772227722
function createPortal$1(
2772327723
children,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9738,7 +9738,7 @@ var roots = new Map(),
97389738
devToolsConfig$jscomp$inline_1103 = {
97399739
findFiberByHostInstance: getInstanceFromTag,
97409740
bundleType: 0,
9741-
version: "18.3.0-next-b12bea62d-20230428",
9741+
version: "18.3.0-next-86b0e9199-20230429",
97429742
rendererPackageName: "react-native-renderer",
97439743
rendererConfig: {
97449744
getInspectorDataForViewTag: function () {
@@ -9780,7 +9780,7 @@ var internals$jscomp$inline_1348 = {
97809780
scheduleRoot: null,
97819781
setRefreshHandler: null,
97829782
getCurrentFiber: null,
9783-
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
9783+
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
97849784
};
97859785
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
97869786
var hook$jscomp$inline_1349 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10447,7 +10447,7 @@ var roots = new Map(),
1044710447
devToolsConfig$jscomp$inline_1181 = {
1044810448
findFiberByHostInstance: getInstanceFromTag,
1044910449
bundleType: 0,
10450-
version: "18.3.0-next-b12bea62d-20230428",
10450+
version: "18.3.0-next-86b0e9199-20230429",
1045110451
rendererPackageName: "react-native-renderer",
1045210452
rendererConfig: {
1045310453
getInspectorDataForViewTag: function () {
@@ -10502,7 +10502,7 @@ var roots = new Map(),
1050210502
scheduleRoot: null,
1050310503
setRefreshHandler: null,
1050410504
getCurrentFiber: null,
10505-
reconcilerVersion: "18.3.0-next-b12bea62d-20230428"
10505+
reconcilerVersion: "18.3.0-next-86b0e9199-20230429"
1050610506
});
1050710507
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
1050810508
computeComponentStackForErrorReporting: function (reactTag) {

0 commit comments

Comments
 (0)