Fix: Initialize childIndex in Task constructor (#27367)

acdlite · acdlite · commit 913006512d58 · 2023-09-13T02:21:49.000Z
This field was not being initialized. Although the property is part of the Flow type, the type error wasn't caught because the constructor itself is not covered by Flow, which is unfortunate. (I assume this is related to the dev-only componentStack property.) DiffTrain build for [69be472](69be472)
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-d07921eeda62613bfcf52ecdb66322db26393567
+69be472c11231056d297a7b73dd0b121905606d3
diff --git a/compiled/facebook-www/ReactDOMServer-dev.classic.js b/compiled/facebook-www/ReactDOMServer-dev.classic.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-classic-b080da7c";
+var ReactVersion = "18.3.0-www-classic-82e3d4f9";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");
@@ -9784,7 +9784,8 @@ function createTask(
     legacyContext: legacyContext,
     context: context,
     treeContext: treeContext,
-    thenableState: thenableState
+    thenableState: thenableState,
+    childIndex: -1
   };
 
   {
diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js
@@ -19,7 +19,7 @@ if (__DEV__) {
 var React = require("react");
 var ReactDOM = require("react-dom");
 
-var ReactVersion = "18.3.0-www-modern-7c748307";
+var ReactVersion = "18.3.0-www-modern-6e4c58de";
 
 // This refers to a WWW module.
 var warningWWW = require("warning");
@@ -9543,7 +9543,8 @@ function createTask(
     legacyContext: legacyContext,
     context: context,
     treeContext: treeContext,
-    thenableState: thenableState
+    thenableState: thenableState,
+    childIndex: -1
   };
 
   {
diff --git a/compiled/facebook-www/ReactDOMServer-prod.classic.js b/compiled/facebook-www/ReactDOMServer-prod.classic.js
@@ -2961,7 +2961,8 @@ function createTask(
     legacyContext: legacyContext,
     context: context,
     treeContext: treeContext,
-    thenableState: thenableState
+    thenableState: thenableState,
+    childIndex: -1
   };
   abortSet.add(task);
   return task;
@@ -4499,4 +4500,4 @@ exports.renderToString = function (children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-classic-10a5a8c2";
+exports.version = "18.3.0-www-classic-249420ad";
diff --git a/compiled/facebook-www/ReactDOMServer-prod.modern.js b/compiled/facebook-www/ReactDOMServer-prod.modern.js
@@ -2953,7 +2953,8 @@ function createTask(
     legacyContext: legacyContext,
     context: context,
     treeContext: treeContext,
-    thenableState: thenableState
+    thenableState: thenableState,
+    childIndex: -1
   };
   abortSet.add(task);
   return task;
@@ -4460,4 +4461,4 @@ exports.renderToString = function (children, options) {
     'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
   );
 };
-exports.version = "18.3.0-www-modern-c2a4cb0f";
+exports.version = "18.3.0-www-modern-94a61ee7";
diff --git a/compiled/facebook-www/ReactDOMServerStreaming-dev.modern.js b/compiled/facebook-www/ReactDOMServerStreaming-dev.modern.js
@@ -9446,7 +9446,8 @@ function createTask(
     legacyContext: legacyContext,
     context: context,
     treeContext: treeContext,
-    thenableState: thenableState
+    thenableState: thenableState,
+    childIndex: -1
   };
 
   {
diff --git a/compiled/facebook-www/ReactDOMServerStreaming-prod.modern.js b/compiled/facebook-www/ReactDOMServerStreaming-prod.modern.js
@@ -2746,7 +2746,8 @@ function createTask(
     legacyContext: legacyContext,
     context: context,
     treeContext: treeContext,
-    thenableState: thenableState
+    thenableState: thenableState,
+    childIndex: -1
   };
   abortSet.add(task);
   return task;
diff --git a/compiled/facebook-www/ReactTestRenderer-dev.modern.js b/compiled/facebook-www/ReactTestRenderer-dev.modern.js
@@ -24356,7 +24356,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-d9222bbe";
+var ReactVersion = "18.3.0-www-modern-c8100b99";
 
 // Might add PROFILE later.
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-d07921eeda62613bfcf52ecdb66322db26393567`
	`1`	`+69be472c11231056d297a7b73dd0b121905606d3`
Original file line number	Diff line number	Diff line change
`@@ -9446,7 +9446,8 @@ function createTask(`
`9446`	`9446`	`legacyContext: legacyContext,`
`9447`	`9447`	`context: context,`
`9448`	`9448`	`treeContext: treeContext,`
`9449`		`- thenableState: thenableState`
	`9449`	`+ thenableState: thenableState,`
	`9450`	`+ childIndex: -1`
`9450`	`9451`	`};`
`9451`	`9452`
`9452`	`9453`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24356,7 +24356,7 @@ function createFiberRoot(`
`24356`	`24356`	`return root;`
`24357`	`24357`	`}`
`24358`	`24358`
`24359`		`-var ReactVersion = "18.3.0-www-modern-d9222bbe";`
	`24359`	`+var ReactVersion = "18.3.0-www-modern-c8100b99";`
`24360`	`24360`
`24361`	`24361`	`// Might add PROFILE later.`
`24362`	`24362`