Skip to content

Commit ad10266

Browse files
author
Sebastian Silbermann
committed
In hindsight, suppressing console.log is probably a bad idea
1 parent e16d5ff commit ad10266

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

packages/react/src/__tests__/ReactStrictMode-test.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,7 +1106,7 @@ describe('context legacy', () => {
11061106

11071107
if (ReactFeatureFlags.consoleManagedByDevToolsDuringStrictMode) {
11081108
it('does not disable logs for class double render', async () => {
1109-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1109+
spyOnDevAndProd(console, 'log');
11101110

11111111
let count = 0;
11121112
class Foo extends React.Component {
@@ -1135,7 +1135,7 @@ describe('context legacy', () => {
11351135
});
11361136

11371137
it('does not disable logs for class double ctor', async () => {
1138-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1138+
spyOnDevAndProd(console, 'log');
11391139

11401140
let count = 0;
11411141
class Foo extends React.Component {
@@ -1167,7 +1167,7 @@ describe('context legacy', () => {
11671167
});
11681168

11691169
it('does not disable logs for class double getDerivedStateFromProps', async () => {
1170-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1170+
spyOnDevAndProd(console, 'log');
11711171

11721172
let count = 0;
11731173
class Foo extends React.Component {
@@ -1200,7 +1200,7 @@ describe('context legacy', () => {
12001200
});
12011201

12021202
it('does not disable logs for class double shouldComponentUpdate', async () => {
1203-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1203+
spyOnDevAndProd(console, 'log');
12041204

12051205
let count = 0;
12061206
class Foo extends React.Component {
@@ -1241,7 +1241,7 @@ describe('context legacy', () => {
12411241
});
12421242

12431243
it('does not disable logs for class state updaters', async () => {
1244-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1244+
spyOnDevAndProd(console, 'log');
12451245

12461246
let inst;
12471247
let count = 0;
@@ -1279,7 +1279,7 @@ describe('context legacy', () => {
12791279
});
12801280

12811281
it('does not disable logs for function double render', async () => {
1282-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1282+
spyOnDevAndProd(console, 'log');
12831283

12841284
let count = 0;
12851285
function Foo() {
@@ -1306,7 +1306,7 @@ describe('context legacy', () => {
13061306
});
13071307
} else {
13081308
it('disable logs for class double render', async () => {
1309-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1309+
spyOnDevAndProd(console, 'log');
13101310

13111311
let count = 0;
13121312
class Foo extends React.Component {
@@ -1335,7 +1335,7 @@ describe('context legacy', () => {
13351335
});
13361336

13371337
it('disables logs for class double ctor', async () => {
1338-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1338+
spyOnDevAndProd(console, 'log');
13391339

13401340
let count = 0;
13411341
class Foo extends React.Component {
@@ -1367,7 +1367,7 @@ describe('context legacy', () => {
13671367
});
13681368

13691369
it('disable logs for class double getDerivedStateFromProps', async () => {
1370-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1370+
spyOnDevAndProd(console, 'log');
13711371

13721372
let count = 0;
13731373
class Foo extends React.Component {
@@ -1400,7 +1400,7 @@ describe('context legacy', () => {
14001400
});
14011401

14021402
it('disable logs for class double shouldComponentUpdate', async () => {
1403-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1403+
spyOnDevAndProd(console, 'log');
14041404

14051405
let count = 0;
14061406
class Foo extends React.Component {
@@ -1440,7 +1440,7 @@ describe('context legacy', () => {
14401440
});
14411441

14421442
it('disable logs for class state updaters', async () => {
1443-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1443+
spyOnDevAndProd(console, 'log');
14441444

14451445
let inst;
14461446
let count = 0;
@@ -1478,7 +1478,7 @@ describe('context legacy', () => {
14781478
});
14791479

14801480
it('disable logs for function double render', async () => {
1481-
spyOnDevAndProd(console, 'log').mockImplementation(() => {});
1481+
spyOnDevAndProd(console, 'log');
14821482

14831483
let count = 0;
14841484
function Foo() {

0 commit comments

Comments
 (0)