Skip to content

Commit cb22111

Browse files
vzaidmanvzaidman
committed
Default native inspections config false (#29784)
## Summary To make the config `supportsNativeInspection` explicit, set it to default to `false` and only allow it in the extension. ## How did you test this change? When disabled on **React DevTools extension** <img width="419" alt="Screenshot 2024-06-06 at 17 34 02" src="https://github.com/facebook/react/assets/5188459/0052b645-2214-475c-8b41-4f9207ca3343"> When enabled on **React DevTools extension** (the chosen config) <img width="425" alt="Screenshot 2024-06-06 at 17 34 53" src="https://github.com/facebook/react/assets/5188459/df34ec8e-2039-4984-86c8-74feaf89bbdd"> When enabled on **React DevTools in Fusebox** <img width="1170" alt="Screenshot 2024-06-06 at 17 29 24" src="https://github.com/facebook/react/assets/5188459/ae52274b-583d-463c-8482-2323d502f4c0"> When disabled on **React DevTools in Fusebox** (the chosen config) <img width="1453" alt="Screenshot 2024-06-06 at 17 30 31" src="https://github.com/facebook/react/assets/5188459/cba5b51b-c973-412d-8ad0-382a4f9bf115"> When enabled on **React DevTools Inline** <img width="915" alt="Screenshot 2024-06-06 at 17 24 20" src="https://github.com/facebook/react/assets/5188459/f0d61d99-2b75-4a87-a19e-db431be697e3"> When disabled on **React DevTools Inline** (the chosen config) <img width="844" alt="Screenshot 2024-06-06 at 17 19 39" src="https://github.com/facebook/react/assets/5188459/d3bcc8a7-535d-4656-844d-f9f89bb2b248"> When enabled on **React DevTools standalone** <img width="1227" alt="Screenshot 2024-06-06 at 17 23 16" src="https://github.com/facebook/react/assets/5188459/174fbae6-1412-4539-bbe6-e1d0e8baa7d5"> When disabled on **React DevTools standalone** (the chosen config) <img width="844" alt="Screenshot 2024-06-06 at 17 19 39" src="https://github.com/facebook/react/assets/5188459/00c46907-e3a6-4766-a1b4-dd088cac2157"> DiffTrain build for commit fd6e130.
1 parent 32d7ecf commit cb22111

File tree

14 files changed

+36
-36
lines changed

14 files changed

+36
-36
lines changed

‎compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-99da76f23a-20240606
1+
19.0.0-native-fb-fd6e130b00-20240606

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8ff0896135b7b18c20904b27e0db88a8>>
10+
* @generated SignedSource<<bfa319a88e7ba395f362da35c7c6ae6d>>
1111
*/
1212

1313
'use strict';
@@ -23580,7 +23580,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2358023580
return root;
2358123581
}
2358223582

23583-
var ReactVersion = '19.0.0-native-fb-99da76f23a-20240606';
23583+
var ReactVersion = '19.0.0-native-fb-fd6e130b00-20240606';
2358423584

2358523585
/*
2358623586
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<dfd7547611fb05ceb70414ceebfd0e64>>
10+
* @generated SignedSource<<647ed1e416c3ed5bd4544633bb22aa90>>
1111
*/
1212

1313
"use strict";
@@ -9336,7 +9336,7 @@ var devToolsConfig$jscomp$inline_1048 = {
93369336
throw Error("TestRenderer does not support findFiberByHostInstance()");
93379337
},
93389338
bundleType: 0,
9339-
version: "19.0.0-native-fb-99da76f23a-20240606",
9339+
version: "19.0.0-native-fb-fd6e130b00-20240606",
93409340
rendererPackageName: "react-test-renderer"
93419341
};
93429342
var internals$jscomp$inline_1235 = {
@@ -9367,7 +9367,7 @@ var internals$jscomp$inline_1235 = {
93679367
scheduleRoot: null,
93689368
setRefreshHandler: null,
93699369
getCurrentFiber: null,
9370-
reconcilerVersion: "19.0.0-native-fb-99da76f23a-20240606"
9370+
reconcilerVersion: "19.0.0-native-fb-fd6e130b00-20240606"
93719371
};
93729372
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
93739373
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<85ef7c6c3e299bddaa219dd6a7ddb485>>
10+
* @generated SignedSource<<9f25c533425fd58fff1087add02bb332>>
1111
*/
1212

1313
"use strict";
@@ -9958,7 +9958,7 @@ var devToolsConfig$jscomp$inline_1131 = {
99589958
throw Error("TestRenderer does not support findFiberByHostInstance()");
99599959
},
99609960
bundleType: 0,
9961-
version: "19.0.0-native-fb-99da76f23a-20240606",
9961+
version: "19.0.0-native-fb-fd6e130b00-20240606",
99629962
rendererPackageName: "react-test-renderer"
99639963
};
99649964
(function (internals) {
@@ -10002,7 +10002,7 @@ var devToolsConfig$jscomp$inline_1131 = {
1000210002
scheduleRoot: null,
1000310003
setRefreshHandler: null,
1000410004
getCurrentFiber: null,
10005-
reconcilerVersion: "19.0.0-native-fb-99da76f23a-20240606"
10005+
reconcilerVersion: "19.0.0-native-fb-fd6e130b00-20240606"
1000610006
});
1000710007
exports._Scheduler = Scheduler;
1000810008
exports.act = act;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<049d661e8333442e2c93b0310afe90c8>>
10+
* @generated SignedSource<<da04ffd0168478b278088d1dd71f702c>>
1111
*/
1212

1313
'use strict';
@@ -24,7 +24,7 @@ if (
2424
}
2525
var dynamicFlagsUntyped = require('ReactNativeInternalFeatureFlags');
2626

27-
var ReactVersion = '19.0.0-native-fb-99da76f23a-20240606';
27+
var ReactVersion = '19.0.0-native-fb-fd6e130b00-20240606';
2828

2929
// Re-export dynamic flags from the internal module.
3030
var dynamicFlags = dynamicFlagsUntyped; // We destructure each value before re-exporting to avoid a dynamic look-up on

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7ecaa5f36e67e1c798758af01a9ca63a>>
10+
* @generated SignedSource<<530a2382ebd13dd17d916c2400554edd>>
1111
*/
1212

1313
"use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.0.0-native-fb-99da76f23a-20240606";
607+
exports.version = "19.0.0-native-fb-fd6e130b00-20240606";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d789297d22614ff6eb7e163ab91204f4>>
10+
* @generated SignedSource<<a797769e754cbf0362b7fbf62774837d>>
1111
*/
1212

1313
"use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
608608
exports.useTransition = function () {
609609
return ReactSharedInternals.H.useTransition();
610610
};
611-
exports.version = "19.0.0-native-fb-99da76f23a-20240606";
611+
exports.version = "19.0.0-native-fb-fd6e130b00-20240606";
612612
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
613613
"function" ===
614614
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
99da76f23ac85d279457470f8fb19a9b2f173ed0
1+
fd6e130b00d4d1fe211c75e981160131669c4412

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<961245cc1a85b2c3470d0ad37e4b4278>>
10+
* @generated SignedSource<<5c37d417b9b99eae764bfce3356ed6b3>>
1111
*/
1212

1313
'use strict';
@@ -26316,7 +26316,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2631626316
return root;
2631726317
}
2631826318

26319-
var ReactVersion = '19.0.0-rc-99da76f23a-20240606';
26319+
var ReactVersion = '19.0.0-rc-fd6e130b00-20240606';
2632026320

2632126321
/*
2632226322
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a362d8aac3277fadd6d410e4444f33bf>>
10+
* @generated SignedSource<<d1f70b65b4e74dcab410f7c82fd04449>>
1111
*/
1212

1313
"use strict";
@@ -10591,7 +10591,7 @@ var roots = new Map(),
1059110591
devToolsConfig$jscomp$inline_1125 = {
1059210592
findFiberByHostInstance: getInstanceFromNode,
1059310593
bundleType: 0,
10594-
version: "19.0.0-rc-99da76f23a-20240606",
10594+
version: "19.0.0-rc-fd6e130b00-20240606",
1059510595
rendererPackageName: "react-native-renderer",
1059610596
rendererConfig: {
1059710597
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10634,7 +10634,7 @@ var internals$jscomp$inline_1351 = {
1063410634
scheduleRoot: null,
1063510635
setRefreshHandler: null,
1063610636
getCurrentFiber: null,
10637-
reconcilerVersion: "19.0.0-rc-99da76f23a-20240606"
10637+
reconcilerVersion: "19.0.0-rc-fd6e130b00-20240606"
1063810638
};
1063910639
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1064010640
var hook$jscomp$inline_1352 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<4e94ac0a2adddffaf123f37aad23b6c1>>
10+
* @generated SignedSource<<9a3d4dc5b3bb4c3e465a4f40e76e5017>>
1111
*/
1212

1313
"use strict";
@@ -11297,7 +11297,7 @@ var roots = new Map(),
1129711297
devToolsConfig$jscomp$inline_1206 = {
1129811298
findFiberByHostInstance: getInstanceFromNode,
1129911299
bundleType: 0,
11300-
version: "19.0.0-rc-99da76f23a-20240606",
11300+
version: "19.0.0-rc-fd6e130b00-20240606",
1130111301
rendererPackageName: "react-native-renderer",
1130211302
rendererConfig: {
1130311303
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11353,7 +11353,7 @@ var roots = new Map(),
1135311353
scheduleRoot: null,
1135411354
setRefreshHandler: null,
1135511355
getCurrentFiber: null,
11356-
reconcilerVersion: "19.0.0-rc-99da76f23a-20240606"
11356+
reconcilerVersion: "19.0.0-rc-fd6e130b00-20240606"
1135711357
});
1135811358
exports.createPortal = function (children, containerTag) {
1135911359
return createPortal$1(

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d1587f949b13da755b03e380d2d73e55>>
10+
* @generated SignedSource<<f4518813211a808204705906dda9b894>>
1111
*/
1212

1313
'use strict';
@@ -26671,7 +26671,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
2667126671
return root;
2667226672
}
2667326673

26674-
var ReactVersion = '19.0.0-rc-99da76f23a-20240606';
26674+
var ReactVersion = '19.0.0-rc-fd6e130b00-20240606';
2667526675

2667626676
/*
2667726677
* The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a0d46d7052e7fca848e4e7a7783e0915>>
10+
* @generated SignedSource<<9a76a84851dc568825f326caaf8739eb>>
1111
*/
1212

1313
"use strict";
@@ -10734,11 +10734,11 @@ function traverseOwnerTreeUp(hierarchy, instance) {
1073410734
traverseOwnerTreeUp(hierarchy, instance);
1073510735
}
1073610736
var isomorphicReactPackageVersion = React.version;
10737-
if ("19.0.0-rc-99da76f23a-20240606" !== isomorphicReactPackageVersion)
10737+
if ("19.0.0-rc-fd6e130b00-20240606" !== isomorphicReactPackageVersion)
1073810738
throw Error(
1073910739
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
1074010740
(isomorphicReactPackageVersion +
10741-
"\n - react-native-renderer: 19.0.0-rc-99da76f23a-20240606\nLearn more: https://react.dev/warnings/version-mismatch")
10741+
"\n - react-native-renderer: 19.0.0-rc-fd6e130b00-20240606\nLearn more: https://react.dev/warnings/version-mismatch")
1074210742
);
1074310743
if (
1074410744
"function" !==
@@ -10788,7 +10788,7 @@ var roots = new Map(),
1078810788
devToolsConfig$jscomp$inline_1193 = {
1078910789
findFiberByHostInstance: getInstanceFromTag,
1079010790
bundleType: 0,
10791-
version: "19.0.0-rc-99da76f23a-20240606",
10791+
version: "19.0.0-rc-fd6e130b00-20240606",
1079210792
rendererPackageName: "react-native-renderer",
1079310793
rendererConfig: {
1079410794
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10831,7 +10831,7 @@ var internals$jscomp$inline_1440 = {
1083110831
scheduleRoot: null,
1083210832
setRefreshHandler: null,
1083310833
getCurrentFiber: null,
10834-
reconcilerVersion: "19.0.0-rc-99da76f23a-20240606"
10834+
reconcilerVersion: "19.0.0-rc-fd6e130b00-20240606"
1083510835
};
1083610836
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1083710837
var hook$jscomp$inline_1441 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<27e9662bdf0f1ffa6b921fa2abad124c>>
10+
* @generated SignedSource<<731a1374ea1571ee7e0c09e07dae09e9>>
1111
*/
1212

1313
"use strict";
@@ -11441,11 +11441,11 @@ function traverseOwnerTreeUp(hierarchy, instance) {
1144111441
traverseOwnerTreeUp(hierarchy, instance);
1144211442
}
1144311443
var isomorphicReactPackageVersion = React.version;
11444-
if ("19.0.0-rc-99da76f23a-20240606" !== isomorphicReactPackageVersion)
11444+
if ("19.0.0-rc-fd6e130b00-20240606" !== isomorphicReactPackageVersion)
1144511445
throw Error(
1144611446
'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
1144711447
(isomorphicReactPackageVersion +
11448-
"\n - react-native-renderer: 19.0.0-rc-99da76f23a-20240606\nLearn more: https://react.dev/warnings/version-mismatch")
11448+
"\n - react-native-renderer: 19.0.0-rc-fd6e130b00-20240606\nLearn more: https://react.dev/warnings/version-mismatch")
1144911449
);
1145011450
if (
1145111451
"function" !==
@@ -11495,7 +11495,7 @@ var roots = new Map(),
1149511495
devToolsConfig$jscomp$inline_1274 = {
1149611496
findFiberByHostInstance: getInstanceFromTag,
1149711497
bundleType: 0,
11498-
version: "19.0.0-rc-99da76f23a-20240606",
11498+
version: "19.0.0-rc-fd6e130b00-20240606",
1149911499
rendererPackageName: "react-native-renderer",
1150011500
rendererConfig: {
1150111501
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11551,7 +11551,7 @@ var roots = new Map(),
1155111551
scheduleRoot: null,
1155211552
setRefreshHandler: null,
1155311553
getCurrentFiber: null,
11554-
reconcilerVersion: "19.0.0-rc-99da76f23a-20240606"
11554+
reconcilerVersion: "19.0.0-rc-fd6e130b00-20240606"
1155511555
});
1155611556
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
1155711557
computeComponentStackForErrorReporting: function (reactTag) {

0 commit comments

Comments
 (0)