Skip to content

Commit d76cf6b

Browse files
acdliteacdlite
committed
Remove string refs (behind flag) (#28322)
Depends on: - #28398 --- This removes string refs, which has been deprecated in Strict Mode for seven years. I've left them behind a flag for Meta, but in open source this fully removes the feature. DiffTrain build for [c979895](c979895)
1 parent 9509de9 commit d76cf6b

21 files changed

+60
-33
lines changed

‎compiled/facebook-www/JSXDEVRuntime-dev.classic.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,9 @@ if (__DEV__) {
12161216
ref = config.ref;
12171217
}
12181218

1219-
warnIfStringRefCannotBeAutoConverted(config, self);
1219+
{
1220+
warnIfStringRefCannotBeAutoConverted(config, self);
1221+
}
12201222
} // Remaining properties are added to a new props object
12211223

12221224
for (propName in config) {

‎compiled/facebook-www/JSXDEVRuntime-dev.modern.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,9 @@ if (__DEV__) {
12161216
ref = config.ref;
12171217
}
12181218

1219-
warnIfStringRefCannotBeAutoConverted(config, self);
1219+
{
1220+
warnIfStringRefCannotBeAutoConverted(config, self);
1221+
}
12201222
} // Remaining properties are added to a new props object
12211223

12221224
for (propName in config) {

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3bcd2de01b5716202eabe8faa338f51bdc59ce26
1+
c9798954e26a2354a951cc65607f2901a45bf035

‎compiled/facebook-www/React-dev.classic.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-www-classic-cca960ca";
27+
var ReactVersion = "18.3.0-www-classic-e2cea41c";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,
@@ -1621,7 +1621,9 @@ if (__DEV__) {
16211621
ref = config.ref;
16221622
}
16231623

1624-
warnIfStringRefCannotBeAutoConverted(config, self);
1624+
{
1625+
warnIfStringRefCannotBeAutoConverted(config, self);
1626+
}
16251627
} // Remaining properties are added to a new props object
16261628

16271629
for (propName in config) {

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-www-modern-f3ad7d8a";
27+
var ReactVersion = "18.3.0-www-modern-c68f569b";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,
@@ -1621,7 +1621,9 @@ if (__DEV__) {
16211621
ref = config.ref;
16221622
}
16231623

1624-
warnIfStringRefCannotBeAutoConverted(config, self);
1624+
{
1625+
warnIfStringRefCannotBeAutoConverted(config, self);
1626+
}
16251627
} // Remaining properties are added to a new props object
16261628

16271629
for (propName in config) {

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -625,4 +625,4 @@ exports.useSyncExternalStore = function (
625625
exports.useTransition = function () {
626626
return ReactCurrentDispatcher.current.useTransition();
627627
};
628-
exports.version = "18.3.0-www-classic-53c0b633";
628+
exports.version = "18.3.0-www-classic-17784f7e";

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,4 +617,4 @@ exports.useSyncExternalStore = function (
617617
exports.useTransition = function () {
618618
return ReactCurrentDispatcher.current.useTransition();
619619
};
620-
exports.version = "18.3.0-www-modern-29517cf7";
620+
exports.version = "18.3.0-www-modern-7f5681e6";

‎compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-classic-10cc6982";
69+
var ReactVersion = "18.3.0-www-classic-1b14a8b4";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -198,7 +198,7 @@ if (__DEV__) {
198198
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
199199

200200
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
201-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
201+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
202202

203203
var FunctionComponent = 0;
204204
var ClassComponent = 1;
@@ -22173,6 +22173,8 @@ if (__DEV__) {
2217322173
}
2217422174
} else {
2217522175
{
22176+
// TODO: We should move these warnings to happen during the render
22177+
// phase (markRef).
2217622178
if (!ref.hasOwnProperty("current")) {
2217722179
error(
2217822180
"Unexpected ref object provided for %s. " +

‎compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-modern-615fb07a";
69+
var ReactVersion = "18.3.0-www-modern-bbc162b8";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -198,7 +198,7 @@ if (__DEV__) {
198198
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
199199

200200
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
201-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
201+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
202202

203203
var FunctionComponent = 0;
204204
var ClassComponent = 1;
@@ -21832,6 +21832,8 @@ if (__DEV__) {
2183221832
}
2183321833
} else {
2183421834
{
21835+
// TODO: We should move these warnings to happen during the render
21836+
// phase (markRef).
2183521837
if (!ref.hasOwnProperty("current")) {
2183621838
error(
2183721839
"Unexpected ref object provided for %s. " +

‎compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ if (__DEV__) {
166166

167167
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
168168
var enableSuspenseCallback = true;
169-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
169+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
170170

171171
var FunctionComponent = 0;
172172
var ClassComponent = 1;
@@ -27703,6 +27703,8 @@ if (__DEV__) {
2770327703
}
2770427704
} else {
2770527705
{
27706+
// TODO: We should move these warnings to happen during the render
27707+
// phase (markRef).
2770627708
if (!ref.hasOwnProperty("current")) {
2770727709
error(
2770827710
"Unexpected ref object provided for %s. " +
@@ -36001,7 +36003,7 @@ if (__DEV__) {
3600136003
return root;
3600236004
}
3600336005

36004-
var ReactVersion = "18.3.0-www-classic-ca77f61d";
36006+
var ReactVersion = "18.3.0-www-classic-a1d5cd42";
3600536007

3600636008
function createPortal$1(
3600736009
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ if (__DEV__) {
152152

153153
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
154154
var enableSuspenseCallback = true;
155-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
155+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
156156

157157
var ReactSharedInternals =
158158
React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
@@ -27548,6 +27548,8 @@ if (__DEV__) {
2754827548
}
2754927549
} else {
2755027550
{
27551+
// TODO: We should move these warnings to happen during the render
27552+
// phase (markRef).
2755127553
if (!ref.hasOwnProperty("current")) {
2755227554
error(
2755327555
"Unexpected ref object provided for %s. " +
@@ -35837,7 +35839,7 @@ if (__DEV__) {
3583735839
return root;
3583835840
}
3583935841

35840-
var ReactVersion = "18.3.0-www-modern-bb7d97c5";
35842+
var ReactVersion = "18.3.0-www-modern-9dd8ecfb";
3584135843

3584235844
function createPortal$1(
3584335845
children,

‎compiled/facebook-www/ReactDOM-profiling.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17473,7 +17473,7 @@ Internals.Events = [
1747317473
var devToolsConfig$jscomp$inline_1862 = {
1747417474
findFiberByHostInstance: getClosestInstanceFromNode,
1747517475
bundleType: 0,
17476-
version: "18.3.0-www-modern-615fb07a",
17476+
version: "18.3.0-www-modern-bbc162b8",
1747717477
rendererPackageName: "react-dom"
1747817478
};
1747917479
(function (internals) {
@@ -17518,7 +17518,7 @@ var devToolsConfig$jscomp$inline_1862 = {
1751817518
scheduleRoot: null,
1751917519
setRefreshHandler: null,
1752017520
getCurrentFiber: null,
17521-
reconcilerVersion: "18.3.0-www-modern-615fb07a"
17521+
reconcilerVersion: "18.3.0-www-modern-bbc162b8"
1752217522
});
1752317523
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
1752417524
exports.createPortal = function (children, container) {
@@ -17776,7 +17776,7 @@ exports.useFormState = function (action, initialState, permalink) {
1777617776
exports.useFormStatus = function () {
1777717777
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
1777817778
};
17779-
exports.version = "18.3.0-www-modern-615fb07a";
17779+
exports.version = "18.3.0-www-modern-bbc162b8";
1778017780
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1778117781
"function" ===
1778217782
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/ReactDOMServer-dev.classic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (__DEV__) {
1919
var React = require("react");
2020
var ReactDOM = require("react-dom");
2121

22-
var ReactVersion = "18.3.0-www-classic-79137864";
22+
var ReactVersion = "18.3.0-www-classic-aafe6508";
2323

2424
// This refers to a WWW module.
2525
var warningWWW = require("warning");
@@ -684,7 +684,7 @@ if (__DEV__) {
684684
enableRefAsProp = dynamicFeatureFlags.enableRefAsProp;
685685
// On WWW, false is used for a new modern build.
686686
var enableFloat = true;
687-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
687+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
688688

689689
// $FlowFixMe[method-unbinding]
690690
var hasOwnProperty = Object.prototype.hasOwnProperty;

‎compiled/facebook-www/ReactDOMServer-dev.modern.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (__DEV__) {
1919
var React = require("react");
2020
var ReactDOM = require("react-dom");
2121

22-
var ReactVersion = "18.3.0-www-modern-4a76bb56";
22+
var ReactVersion = "18.3.0-www-modern-cc760041";
2323

2424
// This refers to a WWW module.
2525
var warningWWW = require("warning");
@@ -684,7 +684,7 @@ if (__DEV__) {
684684
enableRefAsProp = dynamicFeatureFlags.enableRefAsProp;
685685
// On WWW, true is used for a new modern build.
686686
var enableFloat = true;
687-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
687+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
688688

689689
// $FlowFixMe[method-unbinding]
690690
var hasOwnProperty = Object.prototype.hasOwnProperty;

‎compiled/facebook-www/ReactDOMServerStreaming-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ if (__DEV__) {
681681
enableRefAsProp = dynamicFeatureFlags.enableRefAsProp;
682682
// On WWW, true is used for a new modern build.
683683
var enableFloat = true;
684-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
684+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
685685

686686
// $FlowFixMe[method-unbinding]
687687
var hasOwnProperty = Object.prototype.hasOwnProperty;

‎compiled/facebook-www/ReactDOMTesting-dev.classic.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ if (__DEV__) {
158158

159159
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
160160
var enableSuspenseCallback = true;
161-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
161+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
162162

163163
var FunctionComponent = 0;
164164
var ClassComponent = 1;
@@ -27840,6 +27840,8 @@ if (__DEV__) {
2784027840
}
2784127841
} else {
2784227842
{
27843+
// TODO: We should move these warnings to happen during the render
27844+
// phase (markRef).
2784327845
if (!ref.hasOwnProperty("current")) {
2784427846
error(
2784527847
"Unexpected ref object provided for %s. " +
@@ -36625,7 +36627,7 @@ if (__DEV__) {
3662536627
return root;
3662636628
}
3662736629

36628-
var ReactVersion = "18.3.0-www-classic-53c0b633";
36630+
var ReactVersion = "18.3.0-www-classic-17784f7e";
3662936631

3663036632
function createPortal$1(
3663136633
children,

‎compiled/facebook-www/ReactDOMTesting-dev.modern.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ if (__DEV__) {
144144

145145
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
146146
var enableSuspenseCallback = true;
147-
var enableBigIntSupport = false; // Flow magic to verify the exports of this file match the original version.
147+
var enableBigIntSupport = false; // TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
148148

149149
var ReactSharedInternals =
150150
React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;
@@ -27685,6 +27685,8 @@ if (__DEV__) {
2768527685
}
2768627686
} else {
2768727687
{
27688+
// TODO: We should move these warnings to happen during the render
27689+
// phase (markRef).
2768827690
if (!ref.hasOwnProperty("current")) {
2768927691
error(
2769027692
"Unexpected ref object provided for %s. " +
@@ -36461,7 +36463,7 @@ if (__DEV__) {
3646136463
return root;
3646236464
}
3646336465

36464-
var ReactVersion = "18.3.0-www-modern-ebf69536";
36466+
var ReactVersion = "18.3.0-www-modern-7c91c8e8";
3646536467

3646636468
function createPortal$1(
3646736469
children,

‎compiled/facebook-www/ReactServer-dev.modern.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1334,7 +1334,9 @@ if (__DEV__) {
13341334
ref = config.ref;
13351335
}
13361336

1337-
warnIfStringRefCannotBeAutoConverted(config, self);
1337+
{
1338+
warnIfStringRefCannotBeAutoConverted(config, self);
1339+
}
13381340
} // Remaining properties are added to a new props object
13391341

13401342
for (propName in config) {
@@ -2798,7 +2800,7 @@ if (__DEV__) {
27982800
console["error"](error);
27992801
};
28002802

2801-
var ReactVersion = "18.3.0-www-modern-7c3fd7c0";
2803+
var ReactVersion = "18.3.0-www-modern-6846d4a2";
28022804

28032805
// Patch fetch
28042806
var Children = {

‎compiled/facebook-www/ReactTestRenderer-dev.classic.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19330,6 +19330,8 @@ if (__DEV__) {
1933019330
}
1933119331
} else {
1933219332
{
19333+
// TODO: We should move these warnings to happen during the render
19334+
// phase (markRef).
1933319335
if (!ref.hasOwnProperty("current")) {
1933419336
error(
1933519337
"Unexpected ref object provided for %s. " +
@@ -26097,7 +26099,7 @@ if (__DEV__) {
2609726099
return root;
2609826100
}
2609926101

26100-
var ReactVersion = "18.3.0-www-classic-44b067ca";
26102+
var ReactVersion = "18.3.0-www-classic-b441c74f";
2610126103

2610226104
// Might add PROFILE later.
2610326105

‎compiled/facebook-www/ReactTestRenderer-dev.modern.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19330,6 +19330,8 @@ if (__DEV__) {
1933019330
}
1933119331
} else {
1933219332
{
19333+
// TODO: We should move these warnings to happen during the render
19334+
// phase (markRef).
1933319335
if (!ref.hasOwnProperty("current")) {
1933419336
error(
1933519337
"Unexpected ref object provided for %s. " +
@@ -26097,7 +26099,7 @@ if (__DEV__) {
2609726099
return root;
2609826100
}
2609926101

26100-
var ReactVersion = "18.3.0-www-modern-55fd2e28";
26102+
var ReactVersion = "18.3.0-www-modern-bcdfc2da";
2610126103

2610226104
// Might add PROFILE later.
2610326105

‎compiled/facebook-www/__test_utils__/ReactAllWarnings.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)