Skip to content

Commit da9cbdb

Browse files
rubennorterubennorte
committed
Remove unnecessary (and incorrect) code for compatibility with Paper in the Fabric version of GlobalResponderHandler (#26290)
## Summary I'm working on a refactor of the definition of `Instance` in Fabric and I came across this code that seemed to be for compatibility with Paper, but that it would actually throw an error in that case. In Paper, `stateNode` is an instance of `ReactNativeFiberHostComponent`, which doesn't have a `canonical` field. We try to access nested properties in that field in a couple of places here, which would throw a type error (cannot read property `_nativeTag` of `undefined`) if we actually happened to pass a reference to a Paper state node. In this line: ```javascript const isFabric = !!( fromOrToStateNode && fromOrToStateNode.canonical._internalInstanceHandle ); ``` If it wasn't Fabric, `fromOrToStateNode.canonical` would be undefined, and we don't check for that before accessing `fromOrToStateNode.canonical._internalInstanceHandle`. This means that we actually never use this logic in Paper or we would've seen the error. ## How did you test this change? Existing tests. DiffTrain build for [06460b6](06460b6)
1 parent c44f1bb commit da9cbdb

28 files changed

+42
-42
lines changed

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e64a8f4035024ce749bcbcf93b2618e66200a7f7
1+
06460b6fb51e99cfab840424a9514651488b2e99

‎compiled/facebook-www/REVISION_TRANSFORMS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e64a8f4035024ce749bcbcf93b2618e66200a7f7
1+
06460b6fb51e99cfab840424a9514651488b2e99

‎compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-classic-e64a8f403-20230303";
30+
var ReactVersion = "18.3.0-www-classic-06460b6fb-20230303";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-e64a8f403-20230303";
30+
var ReactVersion = "18.3.0-www-modern-06460b6fb-20230303";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
646646
);
647647
};
648648
exports.useTransition = useTransition;
649-
exports.version = "18.3.0-www-classic-e64a8f403-20230303";
649+
exports.version = "18.3.0-www-classic-06460b6fb-20230303";

‎compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
638638
);
639639
};
640640
exports.useTransition = useTransition;
641-
exports.version = "18.3.0-www-modern-e64a8f403-20230303";
641+
exports.version = "18.3.0-www-modern-06460b6fb-20230303";

‎compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
657657
);
658658
};
659659
exports.useTransition = useTransition;
660-
exports.version = "18.3.0-www-classic-e64a8f403-20230303";
660+
exports.version = "18.3.0-www-classic-06460b6fb-20230303";
661661

662662
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
663663
if (

‎compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
649649
);
650650
};
651651
exports.useTransition = useTransition;
652-
exports.version = "18.3.0-www-modern-e64a8f403-20230303";
652+
exports.version = "18.3.0-www-modern-06460b6fb-20230303";
653653

654654
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
655655
if (

‎compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-e64a8f403-20230303";
72+
var ReactVersion = "18.3.0-www-classic-06460b6fb-20230303";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;

‎compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-modern-e64a8f403-20230303";
72+
var ReactVersion = "18.3.0-www-modern-06460b6fb-20230303";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;

‎compiled/facebook-www/ReactART-prod.classic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9780,7 +9780,7 @@ var slice = Array.prototype.slice,
97809780
return null;
97819781
},
97829782
bundleType: 0,
9783-
version: "18.3.0-www-classic-e64a8f403-20230303",
9783+
version: "18.3.0-www-classic-06460b6fb-20230303",
97849784
rendererPackageName: "react-art"
97859785
};
97869786
var internals$jscomp$inline_1300 = {
@@ -9811,7 +9811,7 @@ var internals$jscomp$inline_1300 = {
98119811
scheduleRoot: null,
98129812
setRefreshHandler: null,
98139813
getCurrentFiber: null,
9814-
reconcilerVersion: "18.3.0-next-e64a8f403-20230303"
9814+
reconcilerVersion: "18.3.0-next-06460b6fb-20230303"
98159815
};
98169816
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
98179817
var hook$jscomp$inline_1301 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactART-prod.modern.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9445,7 +9445,7 @@ var slice = Array.prototype.slice,
94459445
return null;
94469446
},
94479447
bundleType: 0,
9448-
version: "18.3.0-www-modern-e64a8f403-20230303",
9448+
version: "18.3.0-www-modern-06460b6fb-20230303",
94499449
rendererPackageName: "react-art"
94509450
};
94519451
var internals$jscomp$inline_1280 = {
@@ -9476,7 +9476,7 @@ var internals$jscomp$inline_1280 = {
94769476
scheduleRoot: null,
94779477
setRefreshHandler: null,
94789478
getCurrentFiber: null,
9479-
reconcilerVersion: "18.3.0-next-e64a8f403-20230303"
9479+
reconcilerVersion: "18.3.0-next-06460b6fb-20230303"
94809480
};
94819481
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
94829482
var hook$jscomp$inline_1281 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42108,7 +42108,7 @@ function createFiberRoot(
4210842108
return root;
4210942109
}
4211042110

42111-
var ReactVersion = "18.3.0-www-classic-e64a8f403-20230303";
42111+
var ReactVersion = "18.3.0-www-classic-06460b6fb-20230303";
4211242112

4211342113
function createPortal$1(
4211442114
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41712,7 +41712,7 @@ function createFiberRoot(
4171241712
return root;
4171341713
}
4171441714

41715-
var ReactVersion = "18.3.0-www-modern-e64a8f403-20230303";
41715+
var ReactVersion = "18.3.0-www-modern-06460b6fb-20230303";
4171641716

4171741717
function createPortal$1(
4171841718
children,

‎compiled/facebook-www/ReactDOM-prod.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15490,7 +15490,7 @@ Internals.Events = [
1549015490
var devToolsConfig$jscomp$inline_1741 = {
1549115491
findFiberByHostInstance: getClosestInstanceFromNode,
1549215492
bundleType: 0,
15493-
version: "18.3.0-www-classic-e64a8f403-20230303",
15493+
version: "18.3.0-www-classic-06460b6fb-20230303",
1549415494
rendererPackageName: "react-dom"
1549515495
};
1549615496
var internals$jscomp$inline_2108 = {
@@ -15520,7 +15520,7 @@ var internals$jscomp$inline_2108 = {
1552015520
scheduleRoot: null,
1552115521
setRefreshHandler: null,
1552215522
getCurrentFiber: null,
15523-
reconcilerVersion: "18.3.0-next-e64a8f403-20230303"
15523+
reconcilerVersion: "18.3.0-next-06460b6fb-20230303"
1552415524
};
1552515525
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1552615526
var hook$jscomp$inline_2109 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15776,4 +15776,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
1577615776
);
1577715777
};
1577815778
exports.unstable_runWithPriority = runWithPriority;
15779-
exports.version = "18.3.0-next-e64a8f403-20230303";
15779+
exports.version = "18.3.0-next-06460b6fb-20230303";

‎compiled/facebook-www/ReactDOM-prod.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15019,7 +15019,7 @@ Internals.Events = [
1501915019
var devToolsConfig$jscomp$inline_1700 = {
1502015020
findFiberByHostInstance: getClosestInstanceFromNode,
1502115021
bundleType: 0,
15022-
version: "18.3.0-www-modern-e64a8f403-20230303",
15022+
version: "18.3.0-www-modern-06460b6fb-20230303",
1502315023
rendererPackageName: "react-dom"
1502415024
};
1502515025
var internals$jscomp$inline_2072 = {
@@ -15050,7 +15050,7 @@ var internals$jscomp$inline_2072 = {
1505015050
scheduleRoot: null,
1505115051
setRefreshHandler: null,
1505215052
getCurrentFiber: null,
15053-
reconcilerVersion: "18.3.0-next-e64a8f403-20230303"
15053+
reconcilerVersion: "18.3.0-next-06460b6fb-20230303"
1505415054
};
1505515055
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1505615056
var hook$jscomp$inline_2073 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15235,4 +15235,4 @@ exports.unstable_flushControlled = function (fn) {
1523515235
}
1523615236
};
1523715237
exports.unstable_runWithPriority = runWithPriority;
15238-
exports.version = "18.3.0-next-e64a8f403-20230303";
15238+
exports.version = "18.3.0-next-06460b6fb-20230303";

‎compiled/facebook-www/ReactDOM-profiling.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16267,7 +16267,7 @@ Internals.Events = [
1626716267
var devToolsConfig$jscomp$inline_1821 = {
1626816268
findFiberByHostInstance: getClosestInstanceFromNode,
1626916269
bundleType: 0,
16270-
version: "18.3.0-www-classic-e64a8f403-20230303",
16270+
version: "18.3.0-www-classic-06460b6fb-20230303",
1627116271
rendererPackageName: "react-dom"
1627216272
};
1627316273
(function (internals) {
@@ -16311,7 +16311,7 @@ var devToolsConfig$jscomp$inline_1821 = {
1631116311
scheduleRoot: null,
1631216312
setRefreshHandler: null,
1631316313
getCurrentFiber: null,
16314-
reconcilerVersion: "18.3.0-next-e64a8f403-20230303"
16314+
reconcilerVersion: "18.3.0-next-06460b6fb-20230303"
1631516315
});
1631616316
assign(Internals, {
1631716317
ReactBrowserEventEmitter: {
@@ -16554,7 +16554,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
1655416554
);
1655516555
};
1655616556
exports.unstable_runWithPriority = runWithPriority;
16557-
exports.version = "18.3.0-next-e64a8f403-20230303";
16557+
exports.version = "18.3.0-next-06460b6fb-20230303";
1655816558

1655916559
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
1656016560
if (

‎compiled/facebook-www/ReactDOM-profiling.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15786,7 +15786,7 @@ Internals.Events = [
1578615786
var devToolsConfig$jscomp$inline_1780 = {
1578715787
findFiberByHostInstance: getClosestInstanceFromNode,
1578815788
bundleType: 0,
15789-
version: "18.3.0-www-modern-e64a8f403-20230303",
15789+
version: "18.3.0-www-modern-06460b6fb-20230303",
1579015790
rendererPackageName: "react-dom"
1579115791
};
1579215792
(function (internals) {
@@ -15831,7 +15831,7 @@ var devToolsConfig$jscomp$inline_1780 = {
1583115831
scheduleRoot: null,
1583215832
setRefreshHandler: null,
1583315833
getCurrentFiber: null,
15834-
reconcilerVersion: "18.3.0-next-e64a8f403-20230303"
15834+
reconcilerVersion: "18.3.0-next-06460b6fb-20230303"
1583515835
});
1583615836
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
1583715837
exports.createPortal = function (children, container) {
@@ -16003,7 +16003,7 @@ exports.unstable_flushControlled = function (fn) {
1600316003
}
1600416004
};
1600516005
exports.unstable_runWithPriority = runWithPriority;
16006-
exports.version = "18.3.0-next-e64a8f403-20230303";
16006+
exports.version = "18.3.0-next-06460b6fb-20230303";
1600716007

1600816008
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
1600916009
if (

‎compiled/facebook-www/ReactDOMServer-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (__DEV__) {
1919
var React = require("react");
2020
var ReactDOM = require("react-dom");
2121

22-
var ReactVersion = "18.3.0-www-classic-e64a8f403-20230303";
22+
var ReactVersion = "18.3.0-www-classic-06460b6fb-20230303";
2323

2424
// This refers to a WWW module.
2525
var warningWWW = require("warning");

‎compiled/facebook-www/ReactDOMServer-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (__DEV__) {
1919
var React = require("react");
2020
var ReactDOM = require("react-dom");
2121

22-
var ReactVersion = "18.3.0-www-modern-e64a8f403-20230303";
22+
var ReactVersion = "18.3.0-www-modern-06460b6fb-20230303";
2323

2424
// This refers to a WWW module.
2525
var warningWWW = require("warning");

‎compiled/facebook-www/ReactDOMServer-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3771,4 +3771,4 @@ exports.renderToString = function (children, options) {
37713771
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
37723772
);
37733773
};
3774-
exports.version = "18.3.0-www-classic-e64a8f403-20230303";
3774+
exports.version = "18.3.0-www-classic-06460b6fb-20230303";

‎compiled/facebook-www/ReactDOMServer-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3669,4 +3669,4 @@ exports.renderToString = function (children, options) {
36693669
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
36703670
);
36713671
};
3672-
exports.version = "18.3.0-www-modern-e64a8f403-20230303";
3672+
exports.version = "18.3.0-www-modern-06460b6fb-20230303";

‎compiled/facebook-www/ReactDOMTesting-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31237,7 +31237,7 @@ function createFiberRoot(
3123731237
return root;
3123831238
}
3123931239

31240-
var ReactVersion = "18.3.0-www-classic-e64a8f403-20230303";
31240+
var ReactVersion = "18.3.0-www-classic-06460b6fb-20230303";
3124131241

3124231242
function createPortal$1(
3124331243
children,

‎compiled/facebook-www/ReactDOMTesting-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37728,7 +37728,7 @@ function createFiberRoot(
3772837728
return root;
3772937729
}
3773037730

37731-
var ReactVersion = "18.3.0-www-modern-e64a8f403-20230303";
37731+
var ReactVersion = "18.3.0-www-modern-06460b6fb-20230303";
3773237732

3773337733
function createPortal$1(
3773437734
children,

‎compiled/facebook-www/ReactDOMTesting-prod.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11521,7 +11521,7 @@ Internals.Events = [
1152111521
var devToolsConfig$jscomp$inline_1535 = {
1152211522
findFiberByHostInstance: getClosestInstanceFromNode,
1152311523
bundleType: 0,
11524-
version: "18.3.0-www-classic-e64a8f403-20230303",
11524+
version: "18.3.0-www-classic-06460b6fb-20230303",
1152511525
rendererPackageName: "react-dom"
1152611526
};
1152711527
var internals$jscomp$inline_2058 = {
@@ -11551,7 +11551,7 @@ var internals$jscomp$inline_2058 = {
1155111551
scheduleRoot: null,
1155211552
setRefreshHandler: null,
1155311553
getCurrentFiber: null,
11554-
reconcilerVersion: "18.3.0-next-e64a8f403-20230303"
11554+
reconcilerVersion: "18.3.0-next-06460b6fb-20230303"
1155511555
};
1155611556
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1155711557
var hook$jscomp$inline_2059 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14782,4 +14782,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
1478214782
);
1478314783
};
1478414784
exports.unstable_runWithPriority = runWithPriority;
14785-
exports.version = "18.3.0-next-e64a8f403-20230303";
14785+
exports.version = "18.3.0-next-06460b6fb-20230303";

‎compiled/facebook-www/ReactDOMTesting-prod.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13881,7 +13881,7 @@ Internals.Events = [
1388113881
var devToolsConfig$jscomp$inline_1652 = {
1388213882
findFiberByHostInstance: getClosestInstanceFromNode,
1388313883
bundleType: 0,
13884-
version: "18.3.0-www-modern-e64a8f403-20230303",
13884+
version: "18.3.0-www-modern-06460b6fb-20230303",
1388513885
rendererPackageName: "react-dom"
1388613886
};
1388713887
var internals$jscomp$inline_2032 = {
@@ -13912,7 +13912,7 @@ var internals$jscomp$inline_2032 = {
1391213912
scheduleRoot: null,
1391313913
setRefreshHandler: null,
1391413914
getCurrentFiber: null,
13915-
reconcilerVersion: "18.3.0-next-e64a8f403-20230303"
13915+
reconcilerVersion: "18.3.0-next-06460b6fb-20230303"
1391613916
};
1391713917
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1391813918
var hook$jscomp$inline_2033 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14240,4 +14240,4 @@ exports.unstable_flushControlled = function (fn) {
1424014240
}
1424114241
};
1424214242
exports.unstable_runWithPriority = runWithPriority;
14243-
exports.version = "18.3.0-next-e64a8f403-20230303";
14243+
exports.version = "18.3.0-next-06460b6fb-20230303";

‎compiled/facebook-www/ReactTestRenderer-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23753,7 +23753,7 @@ function createFiberRoot(
2375323753
return root;
2375423754
}
2375523755

23756-
var ReactVersion = "18.3.0-www-classic-e64a8f403-20230303";
23756+
var ReactVersion = "18.3.0-www-classic-06460b6fb-20230303";
2375723757

2375823758
// Might add PROFILE later.
2375923759

‎compiled/facebook-www/ReactTestRenderer-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23753,7 +23753,7 @@ function createFiberRoot(
2375323753
return root;
2375423754
}
2375523755

23756-
var ReactVersion = "18.3.0-www-modern-e64a8f403-20230303";
23756+
var ReactVersion = "18.3.0-www-modern-06460b6fb-20230303";
2375723757

2375823758
// Might add PROFILE later.
2375923759

0 commit comments

Comments
 (0)