Skip to content

Commit e1f80ce

Browse files
committed
The external runtime is not vetted for stability yet. We should stop publishing it with our stable build
1 parent d50323e commit e1f80ce

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

packages/shared/ReactFeatureFlags.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export const enableUseEffectEventHook = __EXPERIMENTAL__;
110110
// Test in www before enabling in open source.
111111
// Enables DOM-server to stream its instruction set as data-attributes
112112
// (handled with an MutationObserver) instead of inline-scripts
113-
export const enableFizzExternalRuntime = true;
113+
export const enableFizzExternalRuntime = __EXPERIMENTAL__;
114114

115115
export const alwaysThrottleRetries = true;
116116

scripts/rollup/bundles.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ const bundles = [
323323

324324
/******* React DOM Fizz Server External Runtime *******/
325325
{
326-
bundleTypes: [BROWSER_SCRIPT],
326+
bundleTypes: __EXPERIMENTAL__ ? [BROWSER_SCRIPT] : [],
327327
moduleType: RENDERER,
328328
entry: 'react-dom/unstable_server-external-runtime',
329329
outputPath: 'unstable_server-external-runtime.js',

scripts/rollup/packaging.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,14 @@ function filterOutEntrypoints(name) {
223223
// Let's remove it.
224224
files.splice(i, 1);
225225
i--;
226-
unlinkSync(`build/node_modules/${name}/${filename}`);
226+
try {
227+
unlinkSync(`build/node_modules/${name}/${filename}`);
228+
} catch (err) {
229+
// If the file doesn't exist we can just move on. Otherwise throw the halt the build
230+
if (err.code !== 'ENOENT') {
231+
throw err;
232+
}
233+
}
227234
changed = true;
228235
// Remove it from the exports field too if it exists.
229236
if (exportsJSON) {

0 commit comments

Comments
 (0)