Skip to content

Commit eaaebdd

Browse files
noahlemennoahlemen
committed
cleanup enableProfilerNestedUpdateScheduledHook feature flag (#28509)
## Summary Looks like this was added years ago for instrumentation at meta that never ended up rolling out. Should be safe to clean up. ## How did you test this change? `yarn test` DiffTrain build for [0d1ae5d](0d1ae5d)
1 parent 8506f82 commit eaaebdd

12 files changed

+54
-344
lines changed

‎compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
64f354cf27a17c4e5b0dfcd908e47940cf947771
1+
0d1ae5d753044fae99bc37a7815aa947447de3f8

‎compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,4 +633,4 @@ exports.useSyncExternalStore = function (
633633
exports.useTransition = function () {
634634
return ReactCurrentDispatcher.current.useTransition();
635635
};
636-
exports.version = "18.3.0-www-classic-8c94b449";
636+
exports.version = "18.3.0-www-classic-0d16943c";

‎compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 2 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-classic-81c495cd";
69+
var ReactVersion = "18.3.0-www-classic-db11990b";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -194,8 +194,6 @@ if (__DEV__) {
194194
var enableProfilerTimer = true;
195195
var enableProfilerCommitHooks = true;
196196
var enableProfilerNestedUpdatePhase = true;
197-
var enableProfilerNestedUpdateScheduledHook =
198-
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
199197
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
200198

201199
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
@@ -25344,10 +25342,7 @@ if (__DEV__) {
2534425342
}
2534525343
var hasUncaughtError = false;
2534625344
var firstUncaughtError = null;
25347-
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
25348-
// to track which root is currently committing layout effects.
25349-
25350-
var rootCommittingMutationOrLayoutEffects = null;
25345+
var legacyErrorBoundariesThatAlreadyFailed = null;
2535125346
var rootDoesHavePassiveEffects = false;
2535225347
var rootWithPendingPassiveEffects = null;
2535325348
var pendingPassiveEffectsLanes = NoLanes;
@@ -25543,32 +25538,6 @@ if (__DEV__) {
2554325538

2554425539
warnIfUpdatesNotWrappedWithActDEV(fiber);
2554525540

25546-
if (enableProfilerNestedUpdateScheduledHook) {
25547-
if (
25548-
(executionContext & CommitContext) !== NoContext &&
25549-
root === rootCommittingMutationOrLayoutEffects
25550-
) {
25551-
if (fiber.mode & ProfileMode) {
25552-
var current = fiber;
25553-
25554-
while (current !== null) {
25555-
if (current.tag === Profiler) {
25556-
var _current$memoizedProp = current.memoizedProps,
25557-
id = _current$memoizedProp.id,
25558-
onNestedUpdateScheduled =
25559-
_current$memoizedProp.onNestedUpdateScheduled;
25560-
25561-
if (typeof onNestedUpdateScheduled === "function") {
25562-
onNestedUpdateScheduled(id);
25563-
}
25564-
}
25565-
25566-
current = current.return;
25567-
}
25568-
}
25569-
}
25570-
}
25571-
2557225541
if (enableTransitionTracing) {
2557325542
var transition = ReactCurrentBatchConfig.transition;
2557425543

@@ -27548,12 +27517,6 @@ if (__DEV__) {
2754827517
// Mark the current commit time to be shared by all Profilers in this
2754927518
// batch. This enables them to be grouped later.
2755027519
recordCommitTime();
27551-
}
27552-
27553-
if (enableProfilerNestedUpdateScheduledHook) {
27554-
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
27555-
// Updates scheduled during ref detachment should also be flagged.
27556-
rootCommittingMutationOrLayoutEffects = root;
2755727520
} // The next phase is the mutation phase, where we mutate the host tree.
2755827521

2755927522
commitMutationEffects(root, finishedWork, lanes);
@@ -27585,10 +27548,6 @@ if (__DEV__) {
2758527548

2758627549
if (enableSchedulingProfiler) {
2758727550
markLayoutEffectsStopped();
27588-
}
27589-
27590-
if (enableProfilerNestedUpdateScheduledHook) {
27591-
rootCommittingMutationOrLayoutEffects = null;
2759227551
} // Tell Scheduler to yield at the end of the frame, so the browser has an
2759327552
// opportunity to paint.
2759427553

‎compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 2 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ if (__DEV__) {
6666
return self;
6767
}
6868

69-
var ReactVersion = "18.3.0-www-modern-c4d09ac8";
69+
var ReactVersion = "18.3.0-www-modern-d1dd2d63";
7070

7171
var LegacyRoot = 0;
7272
var ConcurrentRoot = 1;
@@ -194,8 +194,6 @@ if (__DEV__) {
194194
var enableProfilerTimer = true;
195195
var enableProfilerCommitHooks = true;
196196
var enableProfilerNestedUpdatePhase = true;
197-
var enableProfilerNestedUpdateScheduledHook =
198-
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
199197
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
200198

201199
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
@@ -25003,10 +25001,7 @@ if (__DEV__) {
2500325001
}
2500425002
var hasUncaughtError = false;
2500525003
var firstUncaughtError = null;
25006-
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
25007-
// to track which root is currently committing layout effects.
25008-
25009-
var rootCommittingMutationOrLayoutEffects = null;
25004+
var legacyErrorBoundariesThatAlreadyFailed = null;
2501025005
var rootDoesHavePassiveEffects = false;
2501125006
var rootWithPendingPassiveEffects = null;
2501225007
var pendingPassiveEffectsLanes = NoLanes;
@@ -25202,32 +25197,6 @@ if (__DEV__) {
2520225197

2520325198
warnIfUpdatesNotWrappedWithActDEV(fiber);
2520425199

25205-
if (enableProfilerNestedUpdateScheduledHook) {
25206-
if (
25207-
(executionContext & CommitContext) !== NoContext &&
25208-
root === rootCommittingMutationOrLayoutEffects
25209-
) {
25210-
if (fiber.mode & ProfileMode) {
25211-
var current = fiber;
25212-
25213-
while (current !== null) {
25214-
if (current.tag === Profiler) {
25215-
var _current$memoizedProp = current.memoizedProps,
25216-
id = _current$memoizedProp.id,
25217-
onNestedUpdateScheduled =
25218-
_current$memoizedProp.onNestedUpdateScheduled;
25219-
25220-
if (typeof onNestedUpdateScheduled === "function") {
25221-
onNestedUpdateScheduled(id);
25222-
}
25223-
}
25224-
25225-
current = current.return;
25226-
}
25227-
}
25228-
}
25229-
}
25230-
2523125200
if (enableTransitionTracing) {
2523225201
var transition = ReactCurrentBatchConfig.transition;
2523325202

@@ -27198,12 +27167,6 @@ if (__DEV__) {
2719827167
// Mark the current commit time to be shared by all Profilers in this
2719927168
// batch. This enables them to be grouped later.
2720027169
recordCommitTime();
27201-
}
27202-
27203-
if (enableProfilerNestedUpdateScheduledHook) {
27204-
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
27205-
// Updates scheduled during ref detachment should also be flagged.
27206-
rootCommittingMutationOrLayoutEffects = root;
2720727170
} // The next phase is the mutation phase, where we mutate the host tree.
2720827171

2720927172
commitMutationEffects(root, finishedWork, lanes);
@@ -27235,10 +27198,6 @@ if (__DEV__) {
2723527198

2723627199
if (enableSchedulingProfiler) {
2723727200
markLayoutEffectsStopped();
27238-
}
27239-
27240-
if (enableProfilerNestedUpdateScheduledHook) {
27241-
rootCommittingMutationOrLayoutEffects = null;
2724227201
} // Tell Scheduler to yield at the end of the frame, so the browser has an
2724327202
// opportunity to paint.
2724427203

‎compiled/facebook-www/ReactDOM-dev.classic.js

Lines changed: 2 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,6 @@ if (__DEV__) {
160160
var enableProfilerTimer = true;
161161
var enableProfilerCommitHooks = true;
162162
var enableProfilerNestedUpdatePhase = true;
163-
var enableProfilerNestedUpdateScheduledHook =
164-
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
165163
var enableFormActions = true;
166164
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
167165

@@ -31163,10 +31161,7 @@ if (__DEV__) {
3116331161
}
3116431162
var hasUncaughtError = false;
3116531163
var firstUncaughtError = null;
31166-
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
31167-
// to track which root is currently committing layout effects.
31168-
31169-
var rootCommittingMutationOrLayoutEffects = null;
31164+
var legacyErrorBoundariesThatAlreadyFailed = null;
3117031165
var rootDoesHavePassiveEffects = false;
3117131166
var rootWithPendingPassiveEffects = null;
3117231167
var pendingPassiveEffectsLanes = NoLanes;
@@ -31362,32 +31357,6 @@ if (__DEV__) {
3136231357

3136331358
warnIfUpdatesNotWrappedWithActDEV(fiber);
3136431359

31365-
if (enableProfilerNestedUpdateScheduledHook) {
31366-
if (
31367-
(executionContext & CommitContext) !== NoContext &&
31368-
root === rootCommittingMutationOrLayoutEffects
31369-
) {
31370-
if (fiber.mode & ProfileMode) {
31371-
var current = fiber;
31372-
31373-
while (current !== null) {
31374-
if (current.tag === Profiler) {
31375-
var _current$memoizedProp = current.memoizedProps,
31376-
id = _current$memoizedProp.id,
31377-
onNestedUpdateScheduled =
31378-
_current$memoizedProp.onNestedUpdateScheduled;
31379-
31380-
if (typeof onNestedUpdateScheduled === "function") {
31381-
onNestedUpdateScheduled(id);
31382-
}
31383-
}
31384-
31385-
current = current.return;
31386-
}
31387-
}
31388-
}
31389-
}
31390-
3139131360
if (enableTransitionTracing) {
3139231361
var transition = ReactCurrentBatchConfig$1.transition;
3139331362

@@ -33429,12 +33398,6 @@ if (__DEV__) {
3342933398
// Mark the current commit time to be shared by all Profilers in this
3343033399
// batch. This enables them to be grouped later.
3343133400
recordCommitTime();
33432-
}
33433-
33434-
if (enableProfilerNestedUpdateScheduledHook) {
33435-
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
33436-
// Updates scheduled during ref detachment should also be flagged.
33437-
rootCommittingMutationOrLayoutEffects = root;
3343833401
} // The next phase is the mutation phase, where we mutate the host tree.
3343933402

3344033403
commitMutationEffects(root, finishedWork, lanes);
@@ -33474,10 +33437,6 @@ if (__DEV__) {
3347433437

3347533438
if (enableSchedulingProfiler) {
3347633439
markLayoutEffectsStopped();
33477-
}
33478-
33479-
if (enableProfilerNestedUpdateScheduledHook) {
33480-
rootCommittingMutationOrLayoutEffects = null;
3348133440
} // Tell Scheduler to yield at the end of the frame, so the browser has an
3348233441
// opportunity to paint.
3348333442

@@ -36034,7 +35993,7 @@ if (__DEV__) {
3603435993
return root;
3603535994
}
3603635995

36037-
var ReactVersion = "18.3.0-www-classic-3e5b27d2";
35996+
var ReactVersion = "18.3.0-www-classic-26a9fc54";
3603835997

3603935998
function createPortal$1(
3604035999
children,

‎compiled/facebook-www/ReactDOM-dev.modern.js

Lines changed: 2 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,6 @@ if (__DEV__) {
155155
var enableProfilerTimer = true;
156156
var enableProfilerCommitHooks = true;
157157
var enableProfilerNestedUpdatePhase = true;
158-
var enableProfilerNestedUpdateScheduledHook =
159-
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
160158
var enableFormActions = true;
161159
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
162160

@@ -31019,10 +31017,7 @@ if (__DEV__) {
3101931017
}
3102031018
var hasUncaughtError = false;
3102131019
var firstUncaughtError = null;
31022-
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
31023-
// to track which root is currently committing layout effects.
31024-
31025-
var rootCommittingMutationOrLayoutEffects = null;
31020+
var legacyErrorBoundariesThatAlreadyFailed = null;
3102631021
var rootDoesHavePassiveEffects = false;
3102731022
var rootWithPendingPassiveEffects = null;
3102831023
var pendingPassiveEffectsLanes = NoLanes;
@@ -31218,32 +31213,6 @@ if (__DEV__) {
3121831213

3121931214
warnIfUpdatesNotWrappedWithActDEV(fiber);
3122031215

31221-
if (enableProfilerNestedUpdateScheduledHook) {
31222-
if (
31223-
(executionContext & CommitContext) !== NoContext &&
31224-
root === rootCommittingMutationOrLayoutEffects
31225-
) {
31226-
if (fiber.mode & ProfileMode) {
31227-
var current = fiber;
31228-
31229-
while (current !== null) {
31230-
if (current.tag === Profiler) {
31231-
var _current$memoizedProp = current.memoizedProps,
31232-
id = _current$memoizedProp.id,
31233-
onNestedUpdateScheduled =
31234-
_current$memoizedProp.onNestedUpdateScheduled;
31235-
31236-
if (typeof onNestedUpdateScheduled === "function") {
31237-
onNestedUpdateScheduled(id);
31238-
}
31239-
}
31240-
31241-
current = current.return;
31242-
}
31243-
}
31244-
}
31245-
}
31246-
3124731216
if (enableTransitionTracing) {
3124831217
var transition = ReactCurrentBatchConfig$1.transition;
3124931218

@@ -33276,12 +33245,6 @@ if (__DEV__) {
3327633245
// Mark the current commit time to be shared by all Profilers in this
3327733246
// batch. This enables them to be grouped later.
3327833247
recordCommitTime();
33279-
}
33280-
33281-
if (enableProfilerNestedUpdateScheduledHook) {
33282-
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
33283-
// Updates scheduled during ref detachment should also be flagged.
33284-
rootCommittingMutationOrLayoutEffects = root;
3328533248
} // The next phase is the mutation phase, where we mutate the host tree.
3328633249

3328733250
commitMutationEffects(root, finishedWork, lanes);
@@ -33321,10 +33284,6 @@ if (__DEV__) {
3332133284

3332233285
if (enableSchedulingProfiler) {
3332333286
markLayoutEffectsStopped();
33324-
}
33325-
33326-
if (enableProfilerNestedUpdateScheduledHook) {
33327-
rootCommittingMutationOrLayoutEffects = null;
3332833287
} // Tell Scheduler to yield at the end of the frame, so the browser has an
3332933288
// opportunity to paint.
3333033289

@@ -35881,7 +35840,7 @@ if (__DEV__) {
3588135840
return root;
3588235841
}
3588335842

35884-
var ReactVersion = "18.3.0-www-modern-b7723bc0";
35843+
var ReactVersion = "18.3.0-www-modern-9c67d6cd";
3588535844

3588635845
function createPortal$1(
3588735846
children,

0 commit comments

Comments
 (0)