Skip to content

Commit f0534ae

Browse files
authored
Avoid replaying SelectiveHydrationException in dev (#25754)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary This is discovered by @acdlite. In dev we replay errors so debugger will treat them as uncaught errors, but we need to ignore internal exceptions. <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## How did you test this change? manually console.log in some tests, and noticed replay didn't happen. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. -->
1 parent 7fab379 commit f0534ae

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

packages/react-reconciler/src/ReactFiberWorkLoop.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3771,6 +3771,7 @@ if (__DEV__ && replayFailedUnitOfWorkWithInvokeGuardedCallback) {
37713771
if (
37723772
didSuspendOrErrorWhileHydratingDEV() ||
37733773
originalError === SuspenseException ||
3774+
originalError === SelectiveHydrationException ||
37743775
(originalError !== null &&
37753776
typeof originalError === 'object' &&
37763777
typeof originalError.then === 'function')

0 commit comments

Comments
 (0)