Skip to content

Commit faf027a

Browse files
committed
Bugfix: useDeferredValue loop during popstate transition (#27559)
During a popstate event, we attempt to render updates synchronously even if they are transitions, to preserve scroll position if possible. We do this by entangling the transition lane with the Sync lane. However, if rendering the transition spawns additional transition updates (e.g. a setState inside useEffect), there's no reason to render those synchronously, too. We should use the normal transition behavior. This fixes an issue where useDeferredValue during a popstate event would spawn a transition update that was itself also synchronous. DiffTrain build for commit 6db7f42.
1 parent 064c29c commit faf027a

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24878,7 +24878,7 @@ function createFiberRoot(
2487824878
return root;
2487924879
}
2488024880

24881-
var ReactVersion = "18.3.0-canary-90172d12e-20231020";
24881+
var ReactVersion = "18.3.0-canary-6db7f4209-20231021";
2488224882

2488324883
// Might add PROFILE later.
2488424884

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9022,7 +9022,7 @@ var devToolsConfig$jscomp$inline_1031 = {
90229022
throw Error("TestRenderer does not support findFiberByHostInstance()");
90239023
},
90249024
bundleType: 0,
9025-
version: "18.3.0-canary-90172d12e-20231020",
9025+
version: "18.3.0-canary-6db7f4209-20231021",
90269026
rendererPackageName: "react-test-renderer"
90279027
};
90289028
var internals$jscomp$inline_1224 = {
@@ -9053,7 +9053,7 @@ var internals$jscomp$inline_1224 = {
90539053
scheduleRoot: null,
90549054
setRefreshHandler: null,
90559055
getCurrentFiber: null,
9056-
reconcilerVersion: "18.3.0-canary-90172d12e-20231020"
9056+
reconcilerVersion: "18.3.0-canary-6db7f4209-20231021"
90579057
};
90589058
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90599059
var hook$jscomp$inline_1225 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9448,7 +9448,7 @@ var devToolsConfig$jscomp$inline_1073 = {
94489448
throw Error("TestRenderer does not support findFiberByHostInstance()");
94499449
},
94509450
bundleType: 0,
9451-
version: "18.3.0-canary-90172d12e-20231020",
9451+
version: "18.3.0-canary-6db7f4209-20231021",
94529452
rendererPackageName: "react-test-renderer"
94539453
};
94549454
var internals$jscomp$inline_1265 = {
@@ -9479,7 +9479,7 @@ var internals$jscomp$inline_1265 = {
94799479
scheduleRoot: null,
94809480
setRefreshHandler: null,
94819481
getCurrentFiber: null,
9482-
reconcilerVersion: "18.3.0-canary-90172d12e-20231020"
9482+
reconcilerVersion: "18.3.0-canary-6db7f4209-20231021"
94839483
};
94849484
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
94859485
var hook$jscomp$inline_1266 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-canary-90172d12e-20231020";
30+
var ReactVersion = "18.3.0-canary-6db7f4209-20231021";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
580580
exports.useTransition = function () {
581581
return ReactCurrentDispatcher.current.useTransition();
582582
};
583-
exports.version = "18.3.0-canary-90172d12e-20231020";
583+
exports.version = "18.3.0-canary-6db7f4209-20231021";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ exports.useSyncExternalStore = function (
583583
exports.useTransition = function () {
584584
return ReactCurrentDispatcher.current.useTransition();
585585
};
586-
exports.version = "18.3.0-canary-90172d12e-20231020";
586+
exports.version = "18.3.0-canary-6db7f4209-20231021";
587587

588588
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
589589
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
90172d12e8f06936ade78ed916397c16a2bec4f8
1+
6db7f4209e6f32ebde298a0b7451710dd6aa3e19

0 commit comments

Comments
 (0)