Skip to content

SVG dy attribute is ignored #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avh4 opened this issue May 20, 2014 · 8 comments
Closed

SVG dy attribute is ignored #1573

avh4 opened this issue May 20, 2014 · 8 comments

Comments

@avh4
Copy link

avh4 commented May 20, 2014

Rendering a text element with a dy attribute in react does not actually render the dy element. It is simply ignored.

Repro: http://jsfiddle.net/avh4/B2R5s/

@jonase
Copy link
Contributor

jonase commented May 20, 2014

I could add this to #1557

@avh4
Copy link
Author

avh4 commented May 20, 2014

You'll note that dy is already present there jonase@8071a5e#diff-31a14f541eaccb5d1a1912e9d055b8b2L33

@avh4
Copy link
Author

avh4 commented May 20, 2014

Hmm... seems like it's probably in master but not in 0.10, but I was expecting an error. Let em verify this again and maybe this is already fixed.

@jonase
Copy link
Contributor

jonase commented May 20, 2014

Yes I noticed that. OTOH, I'm not able to reproduce the issue on master.

@avh4
Copy link
Author

avh4 commented May 20, 2014

I can't quickly upgrade to master because the jsx tool seems to have drastically changed, but it looks like the code is there, so I'm closing this for now.

@avh4 avh4 closed this as completed May 20, 2014
@zpao
Copy link
Member

zpao commented May 20, 2014

dx and dy were added in #1306.

@syranide
Copy link
Contributor

@avh4 If you are on less than React 0.8 (I think?), there's a "whitespace tool" in the repo that automatically "upgrades" all your files to produce identical output with the newer versions.

@sophiebits
Copy link
Collaborator

It's available on npm:

https://www.npmjs.org/package/jsx_whitespace_transformer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants