Skip to content

Drop upper-casing of ReactDOMComponent.tagName #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
syranide opened this issue Oct 3, 2014 · 2 comments
Closed

Drop upper-casing of ReactDOMComponent.tagName #2288

syranide opened this issue Oct 3, 2014 · 2 comments

Comments

@syranide
Copy link
Contributor

syranide commented Oct 3, 2014

https://github.com/facebook/react/blob/master/src/browser/ui/ReactDOMComponent.js#L113

It works well for visually highlighting HTML tags in print, but it's somewhat weird for SVG and web components. Also because it's a public property that could be used for other purposes. This would also mean that we can drop the internal _tagName and just use tag unless there are other considerations.

@jimfb
Copy link
Contributor

jimfb commented Jan 9, 2015

Looks like tagName isn't really being used for much, we may be able to remove it completely.

@jimfb
Copy link
Contributor

jimfb commented Feb 18, 2015

A little history for the next person who investigates, since the original link no longer points to a meaningful target:

Looks like tagName was taken off ReactDOMComponent and put onto the wrapper in: sebmarkbage@9c3e2d8

Then it got moved to ReactDefaultInjection in:
sebmarkbage@e3f95ea

TagName appears on the wrappers of DOM elements, which mimics the tagName that already exists on the native dom elements. These wrappers are temporary and will be going away. When that happens, users will get the native dom elements, which have the native tagName property with the same semantics. So, since these are scheduled for deletion and will happen naturally as part of that future commit, I'm going to close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants