From 0f0328f0930d7fcf0b92cde40b1d6966cd747054 Mon Sep 17 00:00:00 2001 From: Sven Helmberger Date: Thu, 6 Feb 2014 05:18:13 +0100 Subject: [PATCH 1/2] Current set of must-have SVG attributes / tag The current set of SVG attributes / tag I felt like I needed them absolutely for my React/SVG editor app. --- src/browser/ReactDOM.js | 3 ++- src/browser/ui/dom/SVGDOMPropertyConfig.js | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/browser/ReactDOM.js b/src/browser/ReactDOM.js index 5cd3b3517ff62..32bb9e3b60891 100644 --- a/src/browser/ReactDOM.js +++ b/src/browser/ReactDOM.js @@ -184,7 +184,8 @@ var ReactDOM = mapObject({ rect: false, stop: false, svg: false, - text: false + text: false, + tspan: false }, createDOMComponentClass); var injection = { diff --git a/src/browser/ui/dom/SVGDOMPropertyConfig.js b/src/browser/ui/dom/SVGDOMPropertyConfig.js index 6bcea2bfed31d..3bd327a742a9d 100644 --- a/src/browser/ui/dom/SVGDOMPropertyConfig.js +++ b/src/browser/ui/dom/SVGDOMPropertyConfig.js @@ -38,6 +38,7 @@ var SVGDOMPropertyConfig = { gradientUnits: MUST_USE_ATTRIBUTE, offset: MUST_USE_ATTRIBUTE, points: MUST_USE_ATTRIBUTE, + preserveAspectRatio: MUST_USE_ATTRIBUTE, r: MUST_USE_ATTRIBUTE, rx: MUST_USE_ATTRIBUTE, ry: MUST_USE_ATTRIBUTE, @@ -45,6 +46,7 @@ var SVGDOMPropertyConfig = { stopColor: MUST_USE_ATTRIBUTE, stopOpacity: MUST_USE_ATTRIBUTE, stroke: MUST_USE_ATTRIBUTE, + strokeDasharray: MUST_USE_ATTRIBUTE, strokeLinecap: MUST_USE_ATTRIBUTE, strokeWidth: MUST_USE_ATTRIBUTE, textAnchor: MUST_USE_ATTRIBUTE, @@ -61,9 +63,11 @@ var SVGDOMPropertyConfig = { DOMAttributeNames: { gradientTransform: 'gradientTransform', gradientUnits: 'gradientUnits', + preserveAspectRatio: 'preserveAspectRatio', spreadMethod: 'spreadMethod', stopColor: 'stop-color', stopOpacity: 'stop-opacity', + strokeDasharray: 'stroke-dasharray', strokeLinecap: 'stroke-linecap', strokeWidth: 'stroke-width', textAnchor: 'text-anchor', From 8e0d17c756ae2b0485316ba63530079ed9608a18 Mon Sep 17 00:00:00 2001 From: Sven Helmberger Date: Sun, 13 Apr 2014 13:57:12 +0200 Subject: [PATCH 2/2] Add tspan to JSX transform --- vendor/fbtransform/transforms/xjs.js | 1 + 1 file changed, 1 insertion(+) diff --git a/vendor/fbtransform/transforms/xjs.js b/vendor/fbtransform/transforms/xjs.js index 9811c45d23138..acac965f87b9b 100644 --- a/vendor/fbtransform/transforms/xjs.js +++ b/vendor/fbtransform/transforms/xjs.js @@ -143,6 +143,7 @@ var knownTags = { title: true, tr: true, track: true, + tspan: true, u: true, ul: true, 'var': true,