From d172311e2a989500c7b32af66b3400a9016ff9f1 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Wed, 9 Dec 2020 22:23:06 +0000 Subject: [PATCH 1/2] Put .server.js at the end of bundle filenames --- .../npm/writer.browser.server.js | 4 ++-- .../npm/writer.node.server.js | 4 ++-- packages/react/npm/unstable-index.server.js | 4 ++-- scripts/rollup/bundles.js | 14 +++++++++++++- 4 files changed, 19 insertions(+), 7 deletions(-) diff --git a/packages/react-server-dom-webpack/npm/writer.browser.server.js b/packages/react-server-dom-webpack/npm/writer.browser.server.js index e15f6bdec7f8a..3f6729883fda2 100644 --- a/packages/react-server-dom-webpack/npm/writer.browser.server.js +++ b/packages/react-server-dom-webpack/npm/writer.browser.server.js @@ -1,7 +1,7 @@ 'use strict'; if (process.env.NODE_ENV === 'production') { - module.exports = require('./cjs/react-server-dom-webpack-writer.browser.server.production.min.js'); + module.exports = require('./cjs/react-server-dom-webpack-writer.browser.production.min.server.js'); } else { - module.exports = require('./cjs/react-server-dom-webpack-writer.browser.server.development.js'); + module.exports = require('./cjs/react-server-dom-webpack-writer.browser.development.server.js'); } diff --git a/packages/react-server-dom-webpack/npm/writer.node.server.js b/packages/react-server-dom-webpack/npm/writer.node.server.js index b40cc946ea2fd..0254033b0b9c1 100644 --- a/packages/react-server-dom-webpack/npm/writer.node.server.js +++ b/packages/react-server-dom-webpack/npm/writer.node.server.js @@ -1,7 +1,7 @@ 'use strict'; if (process.env.NODE_ENV === 'production') { - module.exports = require('./cjs/react-server-dom-webpack-writer.node.server.production.min.js'); + module.exports = require('./cjs/react-server-dom-webpack-writer.node.production.min.server.js'); } else { - module.exports = require('./cjs/react-server-dom-webpack-writer.node.server.development.js'); + module.exports = require('./cjs/react-server-dom-webpack-writer.node.development.server.js'); } diff --git a/packages/react/npm/unstable-index.server.js b/packages/react/npm/unstable-index.server.js index 431f257867779..c84b65bf312f1 100644 --- a/packages/react/npm/unstable-index.server.js +++ b/packages/react/npm/unstable-index.server.js @@ -1,7 +1,7 @@ 'use strict'; if (process.env.NODE_ENV === 'production') { - module.exports = require('./cjs/react-unstable-index.server.production.min.js'); + module.exports = require('./cjs/react-unstable-index.production.min.server.js'); } else { - module.exports = require('./cjs/react-unstable-index.server.development.js'); + module.exports = require('./cjs/react-unstable-index.development.server.js'); } diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js index e97f7aa8d3067..82bef47d805bd 100644 --- a/scripts/rollup/bundles.js +++ b/scripts/rollup/bundles.js @@ -834,7 +834,7 @@ deepFreeze(bundles); deepFreeze(bundleTypes); deepFreeze(moduleTypes); -function getFilename(bundle, bundleType) { +function getOriginalFilename(bundle, bundleType) { let name = bundle.entry; const globalName = bundle.global; // we do this to replace / to -, for react-dom/server @@ -871,6 +871,18 @@ function getFilename(bundle, bundleType) { } } +function getFilename(bundle, bundleType) { + const originalFilename = getOriginalFilename(bundle, bundleType); + if (originalFilename.indexOf('.server.') !== -1) { + // Ensure .server.js is the final suffix. + // This is important for the Server tooling convention. + return originalFilename + .replace('.server.', '.') + .replace('.js', '.server.js'); + } + return originalFilename; +} + module.exports = { bundleTypes, moduleTypes, From 3a423df320f60f5fbbad7cd4a36c61eee1e4d0b0 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Wed, 9 Dec 2020 22:32:58 +0000 Subject: [PATCH 2/2] Client too --- scripts/rollup/bundles.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js index 82bef47d805bd..90f1f50e3ef65 100644 --- a/scripts/rollup/bundles.js +++ b/scripts/rollup/bundles.js @@ -873,13 +873,18 @@ function getOriginalFilename(bundle, bundleType) { function getFilename(bundle, bundleType) { const originalFilename = getOriginalFilename(bundle, bundleType); + // Ensure .server.js or .client.js is the final suffix. + // This is important for the Server tooling convention. if (originalFilename.indexOf('.server.') !== -1) { - // Ensure .server.js is the final suffix. - // This is important for the Server tooling convention. return originalFilename .replace('.server.', '.') .replace('.js', '.server.js'); } + if (originalFilename.indexOf('.client.') !== -1) { + return originalFilename + .replace('.client.', '.') + .replace('.js', '.client.js'); + } return originalFilename; }