From e35d4642a4b1f83da00fa248f45715de4ac87acd Mon Sep 17 00:00:00 2001 From: Rick Hanlon Date: Thu, 15 Apr 2021 15:07:02 -0400 Subject: [PATCH 1/2] Add dynamic flags to React Native --- packages/shared/forks/ReactFeatureFlags.native-fb.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index 47a2ea6ee2ab5..d3161382049c3 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -9,6 +9,11 @@ import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags'; import typeof * as ExportsType from './ReactFeatureFlags.native-fb'; +import * as DynamicFeatureFlags from './ReactFeatureFlags.www-dynamic'; + +// Re-export dynamic flags. +const dynamicFeatureFlags: DynamicFeatureFlags = require('ReactFeatureFlags'); +export const {enableSyncDefaultUpdates} = dynamicFeatureFlags; // The rest of the flags are static for better dead code elimination. export const enableDebugTracing = false; @@ -60,7 +65,6 @@ export const enableUseRefAccessWarning = false; export const enableRecursiveCommitTraversal = false; export const disableSchedulerTimeoutInWorkLoop = false; export const enableLazyContextPropagation = false; -export const enableSyncDefaultUpdates = true; // Flow magic to verify the exports of this file match the original version. // eslint-disable-next-line no-unused-vars From 9aff2c4f4109bada14a3f16a02e3fd02f448f91e Mon Sep 17 00:00:00 2001 From: Rick Hanlon Date: Thu, 15 Apr 2021 15:19:53 -0400 Subject: [PATCH 2/2] Hardcode the setting to false instead --- packages/shared/forks/ReactFeatureFlags.native-fb.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index d3161382049c3..4cff778708655 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -9,11 +9,6 @@ import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags'; import typeof * as ExportsType from './ReactFeatureFlags.native-fb'; -import * as DynamicFeatureFlags from './ReactFeatureFlags.www-dynamic'; - -// Re-export dynamic flags. -const dynamicFeatureFlags: DynamicFeatureFlags = require('ReactFeatureFlags'); -export const {enableSyncDefaultUpdates} = dynamicFeatureFlags; // The rest of the flags are static for better dead code elimination. export const enableDebugTracing = false; @@ -65,6 +60,7 @@ export const enableUseRefAccessWarning = false; export const enableRecursiveCommitTraversal = false; export const disableSchedulerTimeoutInWorkLoop = false; export const enableLazyContextPropagation = false; +export const enableSyncDefaultUpdates = false; // Flow magic to verify the exports of this file match the original version. // eslint-disable-next-line no-unused-vars