Skip to content
This repository was archived by the owner on Sep 11, 2021. It is now read-only.

Update MSBuild to 2017? #72

Closed
d3x0r opened this issue Dec 11, 2017 · 6 comments
Closed

Update MSBuild to 2017? #72

d3x0r opened this issue Dec 11, 2017 · 6 comments

Comments

@d3x0r
Copy link

d3x0r commented Dec 11, 2017

https://blogs.msdn.microsoft.com/vcblog/2016/11/16/introducing-the-visual-studio-build-tools/?__hstc=268264337.e3768af73965ec808da4e31112e1f89f.1512986621574.1512986621574.1512986621574.1&__hssc=268264337.1.1512986621575&__hsfp=1993959496

Could update to 2017 tools (it's only a little over a year since they were released)

@felixrieseberg
Copy link
Owner

We could! It's supported from npm@5 on, so we should have a new major version that introduces that. It's a good idea though!

@felixrieseberg
Copy link
Owner

Brand new: 2.0-beta uses 2017.

npm i --global --production [email protected]

@jacobq
Copy link
Collaborator

jacobq commented Feb 3, 2018

Is there a document somewhere that summarizes what MS build tool version is recommended for use with which version of node? (I thought that it was advisable to keep these "in sync". Is that right?)

@felixrieseberg
Copy link
Owner

I don't think anyone has made a clear authoritative decision. The 2017 build tools install a lot quicker and in theory, it shouldn't really matter which version of the compiler you use.

That said, I'd love to leave this in beta for a while to make sure that it actually works. 2.0 is on the 2.0 branch - once I get around to it, I'll install a few blank VMs from Modern.ie and will try to compile your typical modules with 2.0 beta. If that all works, we might be doing people a service by upgrading.

@jtatum
Copy link

jtatum commented Feb 26, 2018

Might be interesting to get the CI pipeline to install and use windows-build-tools to build those common packages.

@tdurie24
Copy link

Had the same issue after installing VS2019 when l already had VS2017. To resolve this l went to my installation and sorted by date for when l installed vs 2019 and uni-stalled the .Net SDK installed on that day.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants