Skip to content

Commit 4465f60

Browse files
VinayGuthalashwinraghav
VinayGuthal
authored andcommitted
add version info for sdks (#210)
1 parent 99e457a commit 4465f60

File tree

6 files changed

+32
-2
lines changed

6 files changed

+32
-2
lines changed

firebase-common/firebase-common.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ android {
2525
defaultConfig {
2626
minSdkVersion 14
2727
targetSdkVersion androidVersion
28-
28+
versionName version
2929
multiDexEnabled true
3030
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
3131
}
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
// Copyright 2018 Google LLC
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
package com.google.firebase;
16+
17+
import static com.google.common.truth.Truth.assertThat;
18+
19+
import org.junit.Test;
20+
21+
public class VersionGenerationTest {
22+
23+
@Test
24+
public void isVersionGenerated_shouldNotBeEmpty() {
25+
assertThat(BuildConfig.VERSION_NAME).isNotEmpty();
26+
}
27+
}

firebase-database/firebase-database.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ android {
3636
defaultConfig {
3737
targetSdkVersion androidVersion
3838
minSdkVersion 14
39+
versionName version
3940
multiDexEnabled true
4041
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
4142
}

firebase-firestore/firebase-firestore.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ android {
5757
defaultConfig {
5858
targetSdkVersion androidVersion
5959
minSdkVersion 14
60+
versionName version
6061
multiDexEnabled true
6162
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
6263
}

firebase-functions/firebase-functions.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ android {
2525
defaultConfig {
2626
targetSdkVersion androidVersion
2727
minSdkVersion 14
28-
28+
versionName version
2929
multiDexEnabled true
3030
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
3131
}

firebase-storage/firebase-storage.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ android {
3737
targetSdkVersion androidVersion
3838
minSdkVersion 14
3939
multiDexEnabled true
40+
versionName version
4041
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
4142
}
4243

0 commit comments

Comments
 (0)