Skip to content

Commit 50da8b3

Browse files
committed
Review feedback
1 parent 1f4be55 commit 50da8b3

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/Query.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -901,6 +901,7 @@ private ListenerRegistration addSnapshotListenerInternal(
901901
@Nullable Activity activity,
902902
EventListener<QuerySnapshot> userListener) {
903903

904+
// Convert from ViewSnapshots to QuerySnapshots.
904905
EventListener<ViewSnapshot> viewListener =
905906
(@Nullable ViewSnapshot snapshot, @Nullable FirebaseFirestoreException error) -> {
906907
if (error != null) {
@@ -914,6 +915,7 @@ private ListenerRegistration addSnapshotListenerInternal(
914915
userListener.onEvent(querySnapshot, null);
915916
};
916917

918+
// Call the viewListener on the userExecutor.
917919
AsyncEventListener<ViewSnapshot> asyncListener =
918920
new AsyncEventListener<>(executor, viewListener);
919921

firebase-firestore/src/main/java/com/google/firebase/firestore/core/ListenerRegistrationImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ public class ListenerRegistrationImpl implements ListenerRegistration {
2727
/** The event listener for the query that raises events asynchronously. */
2828
private final AsyncEventListener<ViewSnapshot> asyncEventListener;
2929

30-
/** Creates a new ListenerRegistration. Is activity-scoped if and only if activity is non-null. */
3130
public ListenerRegistrationImpl(
3231
FirestoreClient client,
3332
QueryListener queryListener,

0 commit comments

Comments
 (0)