When searching for gRPC certificates, search the main bundle as well (#2183)

When the project is manually configured, it's possible that the certificates file gets added to the main bundle, not the Firestore framework bundle; make sure the bundle can be loaded in that case as well.

Author: var-const

Firestore/core/src/firebase/firestore/remote/grpc_root_certificate_finder_apple.mm

@@ -34,28 +34,49 @@
 using util::StatusOr;
 using util::StringFormat;
 
-std::string LoadGrpcRootCertificate() {
-  // Try to load certificates bundled by gRPC-C++ if available (depends on
-  // gRPC-C++ version).
-  // Note that `mainBundle` may be nil in certain cases (e.g., unit tests).
-  NSBundle* bundle = [NSBundle bundleWithIdentifier:@"org.cocoapods.grpcpp"];
-  NSString* path;
-  if (bundle) {
-    path =
-        [bundle pathForResource:@"gRPCCertificates.bundle/roots" ofType:@"pem"];
-  }
-  if (path) {
-    LOG_DEBUG("Using roots.pem file from gRPC-C++ pod");
-  } else {
+NSString* FindPathToCertificatesFile() {
+  // Certificates file might be present in one of several bundles, based on
+  // the environment.
+  NSArray<NSBundle*>* bundles = @[
+    // First, try to load certificates bundled by gRPC-C++ if available
+    // (pod versions 0.0.6+).
+    [NSBundle bundleWithIdentifier:@"org.cocoapods.grpcpp"],
     // Fall back to the certificates bundled with Firestore if necessary.
-    LOG_DEBUG("Using roots.pem file from Firestore pod");
+    [NSBundle bundleForClass:FSTFirestoreClient.class],
+    // Finally, users manually adding resources to the project may add the
+    // certificate to the main application bundle. Note that `mainBundle` is nil
+    // for unit tests of library projects, so it cannot fully substitute for
+    // checking framework bundles.
+    [NSBundle mainBundle],
+  ];
+
+  for (NSBundle* bundle in bundles) {
+    if (!bundle) {
+      continue;
+    }
+
+    NSString* resource = @"gRPCCertificates.bundle/roots";
+    NSString* path = [bundle pathForResource:resource ofType:@"pem"];
+    if (!path) {
+      resource = @"gRPCCertificates-Firestore.bundle/roots";
+      path = [bundle pathForResource:resource ofType:@"pem"];
+    }
 
-    bundle = [NSBundle bundleForClass:FSTFirestoreClient.class];
-    HARD_ASSERT(bundle, "Could not find Firestore bundle");
-    path = [bundle pathForResource:@"gRPCCertificates-Firestore.bundle/roots"
-                            ofType:@"pem"];
+    if (path) {
+      LOG_DEBUG("%s.pem found in bundle %s", resource,
+                [bundle bundleIdentifier]);
+      return path;
+    } else {
+      LOG_DEBUG("%s.pem not found in bundle %s", resource,
+                [bundle bundleIdentifier]);
+    }
   }
 
+  return nil;
+}
+
+std::string LoadGrpcRootCertificate() {
+  NSString* path = FindPathToCertificatesFile();
   HARD_ASSERT(
       path,
       "Could not load root certificates from the bundle. SSL cannot work.");