Don't create credential when VerifyAssertionResponse is empty

Yue-Wang-Google · web-flow · commit 1540a771ea41 · 2019-03-12T14:37:23.000-07:00
Fix #2522
diff --git a/Firebase/Auth/Source/RPCs/FIRAuthBackend.m b/Firebase/Auth/Source/RPCs/FIRAuthBackend.m
@@ -1058,11 +1058,13 @@ + (nullable NSError *)clientErrorWithServerErrorMessage:(NSString *)serverErrorM
     NSString *email;
     if ([response isKindOfClass:[FIRVerifyAssertionResponse class]]) {
       FIRVerifyAssertionResponse *verifyAssertion = (FIRVerifyAssertionResponse *)response;
-      credential =
-          [[FIROAuthCredential alloc] initWithProviderID:verifyAssertion.providerID
-                                                 IDToken:verifyAssertion.oauthIDToken
-                                             accessToken:verifyAssertion.oauthAccessToken
-                                            pendingToken:verifyAssertion.pendingToken];
+      if (verifyAssertion.oauthIDToken.length || verifyAssertion.oauthAccessToken.length) {
+        credential =
+            [[FIROAuthCredential alloc] initWithProviderID:verifyAssertion.providerID
+                                                   IDToken:verifyAssertion.oauthIDToken
+                                               accessToken:verifyAssertion.oauthAccessToken
+                                              pendingToken:verifyAssertion.pendingToken];
+      }
       email = verifyAssertion.email;
     }
     return [FIRAuthErrorUtils credentialAlreadyInUseErrorWithMessage:serverDetailErrorMessage
